Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve Concept Exercise] : Black Jack (comparisons) #2428

Closed
3 tasks
cmccandless opened this issue May 13, 2021 · 3 comments · Fixed by #2592
Closed
3 tasks

[Improve Concept Exercise] : Black Jack (comparisons) #2428

cmccandless opened this issue May 13, 2021 · 3 comments · Fixed by #2592
Assignees
@pranasziaukas
Labels
claimed 🐾 For new exercises being written by contributors and maintainers.

Comments

@cmccandless
Copy link
Contributor

RE: #2420 (review)

Improvements are still needed before the comparisons Concept Exercise can graduate from wip to active. These improvements include (but are not limited to):

  • Spelling/Grammar corrections
  • Reference link checking
  • Exemplar/test code cleanup
@BethanyG BethanyG added this to the V3 Concept Exercises for Beta milestone May 21, 2021
@BethanyG BethanyG changed the title comparisons: General cleanup/improvements [Improve Concept Exercise] : Black Jack (comparisons) Jun 16, 2021
@BethanyG
Copy link
Member

Improving this concept exercise will also address #2482, which has been temporarily fixed via pull #2481 & removal of the exercise from the beta site.

@BethanyG BethanyG mentioned this issue Aug 16, 2021
Closed
@pranasziaukas
Copy link
Contributor

Where is an exercise set as wip or active?
My best guess was config.json but doesn't look like it.

@BethanyG
Copy link
Member

It is indeed config.json 😄 -- but it's the track config.json. Here's the entry for BlackJack. Note that the status flag says 'wip`. WIP exercises are not accessible on the site, but will (eventually) be viewable by maintainers. :

@pranasziaukas pranasziaukas mentioned this issue Sep 21, 2021
Merged
@BethanyG BethanyG added the claimed 🐾 For new exercises being written by contributors and maintainers. label Sep 21, 2021
@BethanyG BethanyG linked a pull request Sep 23, 2021 that will close this issue
Implement black-jack concept exercise #2592
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pranasziaukas pranasziaukas

Labels
claimed 🐾 For new exercises being written by contributors and maintainers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement black-jack concept exercise pranasziaukas/exercism-python
3 participants
@BethanyG @cmccandless @pranasziaukas