Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Concept Documents] : comparisons concept #2456

Closed
BethanyG opened this issue Jun 18, 2021 · 1 comment · Fixed by #2733
Closed

[New Concept Documents] : comparisons concept #2456

BethanyG opened this issue Jun 18, 2021 · 1 comment · Fixed by #2733
Labels
claimed 🐾 For new exercises being written by contributors and maintainers. new reference doc ✨ x:action/create Work on something from scratch x:knowledge/intermediate Quite a bit of Exercism knowledge required x:module/concept Work on Concepts x:rep/large Large amount of reputation x:size/medium Medium amount of work x:status/claimed Someone is working on this issue x:type/content Work on content (e.g. exercises, concepts)

Comments

@BethanyG
Copy link
Member

BethanyG commented Jun 18, 2021

This issue describes how to implement the comparisons concept documents for the python track.


Getting started

Please please please read the docs before starting. Posting PRs without reading these docs will be a lot more frustrating for you during the review cycle, and exhaust Exercism's maintainers' time. So, before diving into the implementation, please read up on the following documents:


Concept Description

Please see the following for more details on concepts & concept exercises.

Topics under this concept:

  • Comparison priority in Python
  • Comparison operators ==, >, <, !=
  • Identity methods is and is not
  • Equality applied to built-in types
  • Equivalence vs equality
  • Inequality

Resources to get started writing:


introduction.md

Spec detail can be found here: concept introduction.md

This can also be a summary/paraphrase of the about.md file, and will provide a brief introduction of the concept for a student who has not yet completed the concept exercise. It should contain a good summation of the concept, but not go into lots of detail/discussion. Here is a partial screengrab of the page where introduction.md displays:


about.md

Spec detail can be found here: concept about.md

This file provides information about this concept for a student who has completed the corresponding concept exercise. It is intended as a reference/ jumping off point for continued learning, and may go into detail about performance, variation, or other interesting details. Here is a partial screengrab of the page where about.md displays:


links.json

Spec detail can be found here: concept links.json

This file provides links to information and resources about the concept, including official documentation, tutorials, blog posts, essays, etc. These links show at the bottom of the concept page:

  • We strongly prefer OSS/free resources and those that do not require an account/signup. Please do not link to resources that are paid.
  • The same resources listed in this issue can be used, but they're just a starting point. Feel free to add/amend/edit them.
  • If there are particularly good/interesting information sources for this concept that extend it or discuss alternative/interesting applications, -- please feel free to add them. These are intended to help the student explore the concept in more detail, so they can include topics that are related or tangental to the concept.

Concept Metadata Files Under .meta/config.json

For more information on concept .meta/ files and formatting, see concept metadata files

blurb --- We recommend starting with the first paragraph of either the concepts introduction.md or about.md files, and editing it down to the <= 350 character limit. Here are screengrabs of a blurb (in this case basics and strings) in a couple different contexts:

On the Concepts "journey" page:

On the Exercise Details Page, under the "unlocked" section:



Implementation Notes

  • We use AmEn (American English), and write in a semi-formal (not completely conversational, but not academic either). Like explaining something to your class at school, or your colleagues at work.
  • Code examples should follow the same format as the Python Docs. Here's a short example:


Getting Help

If you have any questions while implementing the exercise, please post the questions as comments in this issue, or contact one of the maintainers on our Slack channel. _We're happy to help!

@BethanyG BethanyG added x:action/create Work on something from scratch x:knowledge/intermediate Quite a bit of Exercism knowledge required x:module/concept Work on Concepts x:size/medium Medium amount of work x:type/content Work on content (e.g. exercises, concepts) help wanted We'd like your help with this. new reference doc ✨ labels Sep 18, 2021
@BethanyG
Copy link
Member Author

BethanyG commented Sep 23, 2021

PLEASE NOTE: PR592 is the implementation of the associated concept exercise. However, that exercise cannot "go live" without this associated concept write-up.

Please review the documents for the associated concept exercise as well as its design document to make sure this write-up is of similar tone and subject.

@BethanyG BethanyG linked a pull request Nov 8, 2021 that will close this issue
@BethanyG BethanyG added claimed 🐾 For new exercises being written by contributors and maintainers. x:status/claimed Someone is working on this issue and removed help wanted We'd like your help with this. labels Nov 9, 2021
J08K added a commit that referenced this issue Nov 15, 2021
* Add blurb for Comparison concept

* Add introduction for Comparisons concept

* Add documentation for about.md for Comparisons concept on python track

* Add links to resources for comparisons concept in python track

* Update concepts/comparisons/.meta/config.json

Co-authored-by: BethanyG <[email protected]>

* Update concepts/comparisons/.meta/config.json

Co-authored-by: BethanyG <[email protected]>

* Update concepts/comparisons/.meta/config.json

Co-authored-by: BethanyG <[email protected]>

* Update concepts/comparisons/about.md

Co-authored-by: BethanyG <[email protected]>

* Update concepts/comparisons/links.json

Co-authored-by: Isaac Good <[email protected]>

* Update concepts/comparisons/links.json

Co-authored-by: Isaac Good <[email protected]>

* Update concepts/comparisons/introduction.md

Co-authored-by: BethanyG <[email protected]>

* Update description for official python operators

* Add note about short circuiting in comparison chaining

* changed unpacking declaration to simple declaration

* Update concepts/comparisons/about.md

Co-authored-by: Isaac Good <[email protected]>

* Update example of membership test with better variable names

* Changed double quotes to single ones for consistency

* Update concepts/comparisons/about.md

Co-authored-by: BethanyG <[email protected]>

* Update concepts/comparisons/links.json

Co-authored-by: Isaac Good <[email protected]>

* Add comparisons link at the bottom of the document

* Add note for comparison priority

* Update concepts/comparisons/about.md

Co-authored-by: BethanyG <[email protected]>

* Add link for arithmetic conversions

* Add example for complex number comparison

* Update concepts/comparisons/about.md

Co-authored-by: BethanyG <[email protected]>

* Update concepts/comparisons/about.md

Co-authored-by: BethanyG <[email protected]>

* Update concepts/comparisons/about.md

Co-authored-by: Isaac Good <[email protected]>

* Add period and convert statement to h3

* Replace single letter variable with more verbose ones

* Update example of membership test

* Update concepts/comparisons/about.md

Co-authored-by: BethanyG <[email protected]>

* Minor apostrophe update

* Update concepts/comparisons/about.md

Co-authored-by: Isaac Good <[email protected]>

* Update concepts/comparisons/about.md

Co-authored-by: BethanyG <[email protected]>

* Update concepts/comparisons/introduction.md

Co-authored-by: BethanyG <[email protected]>

* Update concepts/comparisons/about.md

Co-authored-by: BethanyG <[email protected]>

* Add chinese and korean strings for comparison

* Update concepts/comparisons/about.md

Co-authored-by: BethanyG <[email protected]>

* Update concepts/comparisons/about.md

Co-authored-by: BethanyG <[email protected]>

* Fix broken link due to mistyped word

* Remove code samples and change prose as per about.md

* Update concepts/comparisons/.meta/config.json

* Apply suggestions from code review

Markdown style standards: one-sentence-per-line changes.

Co-authored-by: Victor Goff <[email protected]>

* Change examples of chinese and korean words

* Mention Chinese and Korean in title case

* Update concepts/comparisons/about.md

Co-authored-by: BethanyG <[email protected]>

* Update concepts/comparisons/about.md

Co-authored-by: BethanyG <[email protected]>

Co-authored-by: BethanyG <[email protected]>
Co-authored-by: Isaac Good <[email protected]>
Co-authored-by: Victor Goff <[email protected]>
Co-authored-by: Job van der Wal <[email protected]>
@BethanyG BethanyG added the x:rep/large Large amount of reputation label Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
claimed 🐾 For new exercises being written by contributors and maintainers. new reference doc ✨ x:action/create Work on something from scratch x:knowledge/intermediate Quite a bit of Exercism knowledge required x:module/concept Work on Concepts x:rep/large Large amount of reputation x:size/medium Medium amount of work x:status/claimed Someone is working on this issue x:type/content Work on content (e.g. exercises, concepts)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant