Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protein-translation: Implement canonical-data.json #577

Closed
kytrinyx opened this issue Feb 13, 2017 · 2 comments
Closed

protein-translation: Implement canonical-data.json #577

kytrinyx opened this issue Feb 13, 2017 · 2 comments

Comments

@kytrinyx
Copy link
Member

kytrinyx commented Feb 13, 2017

We want to have a standard set of test inputs and outputs for each exercise to
make it easier to port them to new languages, as well as to help keep the
exercises in sync.

The Protein Translation exercise can be found in the ./exercises/protein-translation/ directory.

The step-by-step instructions for how to compile a canonical-data.json file is
described in this section of the contributing guide.

See http://exercism.io/contribute/canonical-data/protein-translation for the up-to-date list of
language tracks that have an implementation of the Protein Translation exercise.

The tracking issue has more context.

@petertseng
Copy link
Member

Here is a thing to consider for whoever takes this on:

As you will see in #268, we deprecated an exercise called nucleotide-codons in favour of protein-translation. Both these exercises deal with converting codons into protein names.

The exercises worked in slightly different ways, which I summarise but you can see the original analysis at exercism/rust#267 (comment).

When creating the canonical data for this exercise, you should consider which of these two concepts to include.

@Smarticles101 Smarticles101 self-assigned this Jul 17, 2017
@Smarticles101 Smarticles101 removed their assignment Aug 7, 2017
sjwarner-bp pushed a commit to sjwarner/problem-specifications that referenced this issue Nov 8, 2017
ErikSchierboom pushed a commit that referenced this issue Nov 10, 2017
* Add protein translation canonical data as per #577.

* Update properties to reflect different return types.

* Update to test only one property, and fix formatting.

* Update test description for clarity.

* Reduced length of test descriptions.

* Update tests including 'STOP' codons for consistency.

* Update 'STOP' test description

* Update 'STOP' codon tests to expect an empty list.

* Rename 'property', add a larger range of STOP codon tests, rearrange existing stop codon tests, remove testing for invalid data.
@ErikSchierboom
Copy link
Member

Closed by #997.

emcoding pushed a commit that referenced this issue Nov 19, 2018
Revert "extract template metadata into own class"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants