Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement canonical data for all non-deprecated exercises #552

Open
kytrinyx opened this issue Feb 13, 2017 · 8 comments
Open

Implement canonical data for all non-deprecated exercises #552

kytrinyx opened this issue Feb 13, 2017 · 8 comments

Comments

@kytrinyx
Copy link
Member

kytrinyx commented Feb 13, 2017

A number of the exercises are still missing canonical data. Adding this would help make it easier for people to get involved in contributing to Exercism language tracks.

Canonical data is a standardized set of test inputs/outputs that makes it easier to implement exercises from specifications and keep exercises consistent as the test suites evolve.

These issues link back to this one. Once they're all fixed and closed, this issue can also be closed.

This was referenced Feb 13, 2017
@stkent
Copy link
Contributor

stkent commented Feb 13, 2017

Should canonical data be required for any new exercises added (if it isn't already)?

@kytrinyx
Copy link
Member Author

That's a good question. I think that it should be encouraged, but another option is to open a "canonical data" issue for the new exercise and let someone else tackle it.

@kotp
Copy link
Member

kotp commented Feb 20, 2017

Given a "Proof of Concept" as the given example program and tests, the canonical is probably not a leap for a second party to tackle, and, presumably, the creator is interested and so still available for input. I think that works.

@petertseng
Copy link
Member

petertseng commented Feb 26, 2017

Don't mind me, just putting this somewhere where I can find it easily again:

curl http://x.exercism.io/v3/problems/data-todos | jq '.[] | map(select(.["slug"] == "accumulate"))'

Note that the contribute page http://exercism.io/contribute/canonical-data/accumulate https://web.archive.org/web/20170811032845/http://exercism.io:80/contribute/canonical-data/accumulate¹ does a good job of showing this, making curl | jq mostly unnecessary.


1: Link updated to show, as it has moved since this was posted.

@petertseng
Copy link
Member

Hi. I'm going to mark all the subtasks of this task as good first patch.

@ilya-khadykin
Copy link
Contributor

Both links mentioned in the description are dead now:

I assume the valid one should be Getting Involved in an Exercism Language Track to avoid any confusion for newcomers.
I also think there is no point of updating any sub issues as long as the parent has correct info

@kytrinyx, could you please update the description, here is the link:
[Getting Involved in an Exercism Language Track](https://github.com/exercism/docs/tree/master/contributing-to-language-tracks)

@kytrinyx
Copy link
Member Author

kytrinyx commented Aug 5, 2017

Good call, @m-a-ge, I've rewritten a bit to add the suggested link, and fix the two dead ones.

@ErikSchierboom
Copy link
Member

I've just ran a command (find . -type d -maxdepth 1 -mindepth 1 -exec ls {}/canonical-data.json \; | grep 'No such' ) to check which canonical data are not yet implemented:

ls: ./error-handling/canonical-data.json: No such file or directory
ls: ./ledger/canonical-data.json: No such file or directory
ls: ./strain/canonical-data.json: No such file or directory
ls: ./dot-dsl/canonical-data.json: No such file or directory
ls: ./lens-person/canonical-data.json: No such file or directory
ls: ./tree-building/canonical-data.json: No such file or directory
ls: ./hangman/canonical-data.json: No such file or directory
ls: ./paasio/canonical-data.json: No such file or directory
ls: ./point-mutations/canonical-data.json: No such file or directory
ls: ./nucleotide-codons/canonical-data.json: No such file or directory
ls: ./bank-account/canonical-data.json: No such file or directory
ls: ./robot-name/canonical-data.json: No such file or directory
ls: ./counter/canonical-data.json: No such file or directory
ls: ./hexadecimal/canonical-data.json: No such file or directory
ls: ./octal/canonical-data.json: No such file or directory
ls: ./simple-linked-list/canonical-data.json: No such file or directory
ls: ./parallel-letter-frequency/canonical-data.json: No such file or directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants