Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anagram: Add test generator #869

Merged
merged 2 commits into from
Sep 30, 2017
Merged

Conversation

shaleh
Copy link

@shaleh shaleh commented Sep 22, 2017

For #605

I did not have a way to wake up #695 so I started a new one.

This generator mimics the output of the connect generator so the output is
a little nicer IMHO. I bumped the testVersion.

For exercism#605

I did not have a way to wake up exercism#695 so I started a new one.

This generator mimics the output of the connect generator so the output is
a little nicer IMHO. I bumped the `testVersion`.
@shaleh
Copy link
Author

shaleh commented Sep 23, 2017

Did I break a check? The logs are pretty empty.

@robphoenix
Copy link
Contributor

thanks @shaleh I'll have to have a proper look at this on Monday.

Did I break a check? The logs are pretty empty.

It looks like Travis is complaining about the testVersion. We've just removed all test versioning in the nextercism branch.

# github.com/exercism/go/exercises/anagram
exercises/anagram/anagram_test.go:22: undefined: testVersion
exercises/anagram/anagram_test.go:23: undefined: testVersion

@shaleh
Copy link
Author

shaleh commented Sep 23, 2017

Ah. I see. That is disappointing.

@shaleh
Copy link
Author

shaleh commented Sep 23, 2017

All better @robphoenix, thx

@tleen
Copy link
Member

tleen commented Sep 30, 2017

backlogged will review ASAP.

Copy link
Contributor

@leenipper leenipper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@tleen
Copy link
Member

tleen commented Sep 30, 2017

Found #847 while verifying this one. Looks ok in and of itself but this specific exercise does make the bug show up as it has a multiline most recent remote commit on its canonical-data.json file.

@tleen
Copy link
Member

tleen commented Sep 30, 2017

I don't see how this passes travis if #847 is a real bug. I'm gonna mess with the build a bit before committing this.

@tleen
Copy link
Member

tleen commented Sep 30, 2017

Oh I see why, I don't think Travis runs the generators!

@tleen tleen merged commit bf96670 into exercism:nextercism Sep 30, 2017
robphoenix pushed a commit to robphoenix/exercism-go that referenced this pull request Oct 9, 2017
For exercism#605

I did not have a way to wake up exercism#695 so I started a new one.

This generator mimics the output of the connect generator so the output is
a little nicer IMHO.
robphoenix pushed a commit that referenced this pull request Oct 10, 2017
For #605

I did not have a way to wake up #695 so I started a new one.

This generator mimics the output of the connect generator so the output is
a little nicer IMHO.
robphoenix pushed a commit to robphoenix/exercism-go that referenced this pull request Oct 10, 2017
For exercism#605

I did not have a way to wake up exercism#695 so I started a new one.

This generator mimics the output of the connect generator so the output is
a little nicer IMHO.
robphoenix pushed a commit to robphoenix/exercism-go that referenced this pull request Oct 10, 2017
For exercism#605

I did not have a way to wake up exercism#695 so I started a new one.

This generator mimics the output of the connect generator so the output is
a little nicer IMHO.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants