pov: why is root not in leaves or otherwise used?

[shaleh]

The sequence is:

graph := New()
for _, l := range leaves {
    graph.AddNode(l)
}
for _, p := range arcPairs {
    graph.AddArc(p.from, p.to)
}

No where in there is the value for "root" added. So when AddArc is called the value of from is unknown.

The singleton test which is the first test has one leaf which matches the value of root. Most of the others use "parent" which is never explicitly defined.

The comments in the test file say that to will always exist but is quiet on from. It seems odd that the expectation is to create missing from. Or did I missed something?

[tleen]

If it is unclear to you than it is probably unclear and we should fix.

[robphoenix]

@shaleh do you have a fix for this?

I have to admit I don't fully understand what the issue is, would you be able to expand on it so we can outline what a fix for this might look like. Thanks.

[ferhatelmas]

Actually, every node is root. IMHO, it's the point of the exercise. It changes according to where you're looking from.

However, you're right. Current implementation has hidden assumptions and isn't aligned with problem canonical data

Anyway, we will need to write a generator for it so we can rework. @shaleh do you want to give a try ?

[junedev]

Since this will be solved by writing the generator and that is tracked in another issue (#605) I am closing this one.