-
-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
anagram: create test case generator #695
Conversation
Tests will fail see updated example first in #694. |
var testCases = []testcase{ | ||
{{range .J.Cases}} | ||
{ | ||
subject: {{printf "%q" .Subject}}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would take a look at the whitespace at these four lines, looks like there are some tabs and spaces mixed. It does not matter in the end since the end result gets formatted anyway, but helps to use just one (I don't care which) in case tab widths differ.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using tabs will be consistent with rest of file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ferhatelmas, this one only needs a couple of changes and it will be ready for merging. I think with a rebase to exercism/go master and minor adjustments mentioned, will do it. Thanks.
var testCases = []testcase{ | ||
{{range .J.Cases}} | ||
{ | ||
subject: {{printf "%q" .Subject}}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using tabs will be consistent with rest of file.
import ( | ||
"text/template" | ||
|
||
"github.com/exercism/xgo/gen" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The import path used in other generators for referencing the gen package is:
"../../../gen"
Will remove the need to have github.com/ ... in the xgo tree/workspace.
For exercism#605 I did not have a way to wake up exercism#695 so I started a new one. This generator mimics the output of the connect generator so the output is a little nicer IMHO. I bumped the `testVersion`.
For exercism#605 I did not have a way to wake up exercism#695 so I started a new one. This generator mimics the output of the connect generator so the output is a little nicer IMHO.
For exercism#605 I did not have a way to wake up exercism#695 so I started a new one. This generator mimics the output of the connect generator so the output is a little nicer IMHO.
For exercism#605 I did not have a way to wake up exercism#695 so I started a new one. This generator mimics the output of the connect generator so the output is a little nicer IMHO.
For #605.