Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anagram: create test case generator #695

Closed
wants to merge 1 commit into from

Conversation

ferhatelmas
Copy link
Contributor

For #605.

@ferhatelmas
Copy link
Contributor Author

ferhatelmas commented Jun 4, 2017

Tests will fail see updated example first in #694.

var testCases = []testcase{
{{range .J.Cases}}
{
subject: {{printf "%q" .Subject}},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would take a look at the whitespace at these four lines, looks like there are some tabs and spaces mixed. It does not matter in the end since the end result gets formatted anyway, but helps to use just one (I don't care which) in case tab widths differ.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using tabs will be consistent with rest of file.

Copy link
Contributor

@leenipper leenipper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ferhatelmas, this one only needs a couple of changes and it will be ready for merging. I think with a rebase to exercism/go master and minor adjustments mentioned, will do it. Thanks.

var testCases = []testcase{
{{range .J.Cases}}
{
subject: {{printf "%q" .Subject}},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using tabs will be consistent with rest of file.

import (
"text/template"

"github.com/exercism/xgo/gen"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path used in other generators for referencing the gen package is:

  "../../../gen"

Will remove the need to have github.com/ ... in the xgo tree/workspace.

shaleh pushed a commit to shaleh/exercism-go that referenced this pull request Sep 22, 2017
For exercism#605

I did not have a way to wake up exercism#695 so I started a new one.

This generator mimics the output of the connect generator so the output is
a little nicer IMHO. I bumped the `testVersion`.
@tleen
Copy link
Member

tleen commented Sep 30, 2017

I think #874 may be the reason this failed on Travis.

Going to close this as #869 duplicates it.

@tleen tleen closed this Sep 30, 2017
tleen pushed a commit that referenced this pull request Sep 30, 2017
For #605

I did not have a way to wake up #695 so I started a new one.

This generator mimics the output of the connect generator so the output is
a little nicer IMHO.
robphoenix pushed a commit to robphoenix/exercism-go that referenced this pull request Oct 9, 2017
For exercism#605

I did not have a way to wake up exercism#695 so I started a new one.

This generator mimics the output of the connect generator so the output is
a little nicer IMHO.
robphoenix pushed a commit that referenced this pull request Oct 10, 2017
For #605

I did not have a way to wake up #695 so I started a new one.

This generator mimics the output of the connect generator so the output is
a little nicer IMHO.
robphoenix pushed a commit to robphoenix/exercism-go that referenced this pull request Oct 10, 2017
For exercism#605

I did not have a way to wake up exercism#695 so I started a new one.

This generator mimics the output of the connect generator so the output is
a little nicer IMHO.
robphoenix pushed a commit to robphoenix/exercism-go that referenced this pull request Oct 10, 2017
For exercism#605

I did not have a way to wake up exercism#695 so I started a new one.

This generator mimics the output of the connect generator so the output is
a little nicer IMHO.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants