Add new features vrrp_track_file, track_files, (no) accept, and safeguards. #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kariton
changed the title
evrardjp
changed the title
|
hmpf. after matching the used versions I was able to reproduce this error. |
|
looks fine for me. except:
|
|
forgot to push... |
will be fixed soon. Right now, you can temporarily constrain the max version of ansible-lint if you like. |
evrardjp
changed the title
evrardjp
reviewed
Jul 12, 2022
| @@ -5,3 +5,6 @@ | |||
| skip_list: | |||
| - '106' # Role name {} does not match ``^[a-z][a-z0-9_]+$`` pattern | |||
| - 'fqcn-builtins' | |||
|
|
|||
| warn_list: # or 'skip_list' to silence them completely | |||
There was a problem hiding this comment.
can you explain why you added this?
I am rebasing your changes, so I will add this to the commit message.
There was a problem hiding this comment.
IMO a fail on an experimental lint feature is not feasible.
Its more a safety measure.
|
I have updated the PR text, so that it automatically closes issues/PR. I will update the commit messages so we can merge this. Great work. |
Instead, we move the experimental features to a warn list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in (draft) PR 1, we need to split the new features
and the general code updates. This tackles the feature additions
that are pending for a while.
Closes: #140 #176 #195