Add support for vrrp_track_file and track_files
#140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evrardjp
requested changes
May 12, 2020
| file "{{ details.file }}" | ||
| weight {{ details.weight | default(1) }} # multiply with weight in file (default: 1, i.e. literal value from file) | ||
| {% if details.init_file | default(false) %} | ||
| init_file{% if details.init_file_value is defined %} {{ details.init_file_value }}{% endif %}{% if details.init_file_overwrite | default(false) %} overwrite{% endif %} |
There was a problem hiding this comment.
I would prefer if you add | bool to all those default(false) conditionals. If it's defined and truth-y, it won't necessary work. It's a more Ansible-y way to add the | bool to verify the input is as expected. This applies to L87 and L88.
evrardjp
added
the
no-answer
Kariton
added a commit
to Kariton/ansible-keepalived
that referenced
this pull request
Jun 9, 2022
Kariton
added a commit
to Kariton/ansible-keepalived
that referenced
this pull request
Jun 9, 2022
Kariton
added a commit
to Kariton/ansible-keepalived
that referenced
this pull request
Jun 9, 2022
Kariton
added a commit
to Kariton/ansible-keepalived
that referenced
this pull request
Jun 9, 2022
Kariton
added a commit
to Kariton/ansible-keepalived
that referenced
this pull request
Jun 9, 2022
Kariton
added a commit
to Kariton/ansible-keepalived
that referenced
this pull request
Jun 9, 2022
Kariton
added a commit
to Kariton/ansible-keepalived
that referenced
this pull request
Jun 9, 2022
Kariton
added a commit
to Kariton/ansible-keepalived
that referenced
this pull request
Jun 9, 2022
Kariton
added a commit
to Kariton/ansible-keepalived
that referenced
this pull request
Jun 9, 2022
Kariton
added a commit
to Kariton/ansible-keepalived
that referenced
this pull request
Jun 9, 2022
Kariton
added a commit
to Kariton/ansible-keepalived
that referenced
this pull request
Jun 9, 2022
Kariton
added a commit
to Kariton/ansible-keepalived
that referenced
this pull request
Jun 9, 2022
Kariton
added a commit
to Kariton/ansible-keepalived
that referenced
this pull request
Jun 9, 2022
* Add support for ``vrrp_track_file`` and ``track_files`` evrardjp#140 evrardjp#140 Credits to @jjungnickel
Kariton
added a commit
to Kariton/ansible-keepalived
that referenced
this pull request
Jun 16, 2022
evrardjp
pushed a commit
that referenced
this pull request
Jul 12, 2022
evrardjp
pushed a commit
to Kariton/ansible-keepalived
that referenced
this pull request
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.