Add support for accept/no_accept for instances. #176
Closed
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evrardjp
requested changes
Jul 16, 2021
| @@ -93,6 +93,13 @@ vrrp_instance {{ name }} { | |||
| {% if instance.dont_track_primary is defined and instance.dont_track_primary | bool %} | |||
| dont_track_primary # Override VRRP RFC dont_track_primary default | |||
| {% endif %} | |||
| {% if instance.accept is defined and instance.accept | bool %} | |||
There was a problem hiding this comment.
Suggested change
| {% if instance.accept is defined and instance.accept | bool %} | |
| {% if instance.accept is defined %} |
There was a problem hiding this comment.
This way if the user doesn't define accept (the default), there is no change in the config file.
And if someone writes instance.accept false, would write no_accept appropriately.
There was a problem hiding this comment.
I've not tested the alternative (nor do I have an objection to it) but I'd have thought that my if which is checking if accept is defined and a boolean wouldn't pass in the case of accept: , thus not writing out accept or no_accept to the file.
| @@ -93,6 +93,13 @@ vrrp_instance {{ name }} { | |||
| {% if instance.dont_track_primary is defined and instance.dont_track_primary | bool %} | |||
| dont_track_primary # Override VRRP RFC dont_track_primary default | |||
| {% endif %} | |||
| {% if instance.accept is defined and instance.accept | bool %} | |||
| {% if instance.accept %} | |||
There was a problem hiding this comment.
Suggested change
| {% if instance.accept %} | |
| {% if instance.accept | bool %} |
evrardjp
added
the
no-answer
Kariton
added a commit
to Kariton/ansible-keepalived
that referenced
this pull request
Jun 9, 2022
evrardjp@d59c740 Credits to @naphta I implemented @evrardjp suggested changes.
Kariton
added a commit
to Kariton/ansible-keepalived
that referenced
this pull request
Jun 16, 2022
evrardjp
pushed a commit
that referenced
this pull request
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming to this role wanting to implement the keepalived configuration offered by nginx plus and they have accept inside that configuration. Had a quick dig into the manpage and thought this should suffice.