Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish @brightlayer-ui/[email protected] #54

Merged
merged 10 commits into from
Jan 14, 2022
Merged

Publish @brightlayer-ui/[email protected] #54

merged 10 commits into from
Jan 14, 2022

Conversation

emclaug2
Copy link
Contributor

Changes proposed in this Pull Request:

  • Publish version 3.0.0 of the new lint config (only uses new dependencies & changes 1 rule).

To Test:

I've updated the showcase to use the beta package & all required deps. If you run lint, everything is already linted.

@emclaug2 emclaug2 requested review from huayunh, joebochill, daileytj, ektasawant and jeffvg and removed request for huayunh and joebochill January 13, 2022 18:58
@emclaug2 emclaug2 added the master For PRs going into the master branch label Jan 13, 2022
andrupu
andrupu approved these changes Jan 13, 2022
View reviewed changes
Copy link

@andrupu andrupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the Yoda from Star Wars reference in blui-rules.js file.
image

@emclaug2 emclaug2 merged commit 87fb1f7 into master Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrupu andrupu andrupu approved these changes

@jeffvg jeffvg jeffvg approved these changes

@daileytj daileytj daileytj approved these changes

@huayunh huayunh huayunh approved these changes

@ektasawant ektasawant Awaiting requested review from ektasawant

Assignees
No one assigned
Labels
master For PRs going into the master branch
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@emclaug2 @huayunh @daileytj @jeffvg @andrupu @EvanMcLaughlin-eaton