Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2789 new rules and deps #51

Merged
merged 4 commits into from
Jan 11, 2022
Merged

Conversation

emclaug2
Copy link
Contributor

@emclaug2 emclaug2 commented Jan 7, 2022

Fixes #50 #33

Changes proposed in this Pull Request:

  • Updated all deps to latest, still testing locally.
  • Adjusted rule for shadow-vars.

@emclaug2
Copy link
Contributor Author

emclaug2 commented Jan 7, 2022

Instead of making this a major breaking change, I'm thinking we can start to introduce dependency ranges. Still thinking this over.

@emclaug2
Copy link
Contributor Author

emclaug2 commented Jan 10, 2022

Looking more closely at this, updating eslint to the v8.0.0 will introduce an incompatible peer dependency warning, so I'm thinking we can make this a major version change:

Dependencies & their Peer Dependencies

AFTER

"eslint-plugin-react": "^7.28.0", "eslint": "^3 || ^4 || ^5 || ^6 || ^7 || ^8"
"eslint-config-prettier": ">= 8.0.0" "eslint": ">=7.0.0"
"@typescript-eslint/parser": "^5.9.0", "eslint": "^6.0.0 || ^7.0.0 || ^8.0.0"
"@typescript-eslint/eslint-plugin": "^5.9.0", "@typescript-eslint/parser": "^5.0.0", "eslint": "^6.0.0 || ^7.0.0 || ^8.0.0"
"eslint": ">= 8.6.0",

BEFORE
"eslint-plugin-react": "^7.16.0"
"eslint-config-prettier": ">= 6.3.0"
"@typescript-eslint/parser": "^4.8.0",
"@typescript-eslint/eslint-plugin": "^4.8.0",
"eslint": ">= 5.0.0",

Updating @typescript-eslint/eslint-plugin to the latest version will introduce the missing peer dep since it doesn't support eslint@^5.0.0.

@emclaug2 emclaug2 marked this pull request as ready for review January 10, 2022 17:37
Copy link
Contributor

@huayunh huayunh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can verify this works when I mess around with docit.

@jeffvg
Copy link
Contributor

jeffvg commented Jan 10, 2022

with these upgrades, (react) should we do anything about typescript-eslint warnings we see or is this out of scope for this particular effort?

image

@emclaug2
Copy link
Contributor Author

with these upgrades, (react) should we do anything about typescript-eslint warnings we see or is this out of scope for this particular effort?

image

I'll take a look and see if we can get away with using v4.5.0 for TS; I'll merge this in so we can work with a beta package but I'll be doing some more testing using our cli-generated projects.

@emclaug2 emclaug2 merged commit 25a0367 into dev Jan 11, 2022
@delete-merged-branch delete-merged-branch bot deleted the feature/2789-new-rules-and-deps branch January 11, 2022 13:49
@emclaug2
Copy link
Contributor Author

I'll take a look and see if we can get away with using v4.5.0 for TS; I'll merge this in so we can work with a beta package but I'll be doing some more testing using our cli-generated projects.

This warning goes away when using BLUI CLI & latest deps required in the beta package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Need to support latest versions of eslint packages
3 participants