-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/2789 new rules and deps #51
Conversation
Instead of making this a major breaking change, I'm thinking we can start to introduce dependency ranges. Still thinking this over. |
Looking more closely at this, updating eslint to the v8.0.0 will introduce an incompatible peer dependency warning, so I'm thinking we can make this a major version change: Dependencies & their Peer Dependencies AFTER "eslint-plugin-react": "^7.28.0", "eslint": "^3 || ^4 || ^5 || ^6 || ^7 || ^8" BEFORE Updating |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can verify this works when I mess around with docit.
I'll take a look and see if we can get away with using v4.5.0 for TS; I'll merge this in so we can work with a beta package but I'll be doing some more testing using our cli-generated projects. |
This warning goes away when using BLUI CLI & latest deps required in the beta package. |
Fixes #50 #33
Changes proposed in this Pull Request: