Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2789 new rules and deps #51

Merged
merged 4 commits into from
Jan 11, 2022
Merged

Feature/2789 new rules and deps #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
028542c
Use typescript-eslint no-shadow rule only
emclaug2 Jan 7, 2022
bd5c69d
Update deps to latest
emclaug2 Jan 7, 2022
8c0923a
Update more deps to latest, add all deps to devDeps list
emclaug2 Jan 7, 2022
4dc6aed
Update change log
emclaug2 Jan 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions eslint-config/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Changelog

## v3.0.0 (Not yet published)

### Changed

- Updated all dependencies to latest available versions. (`[email protected]` `@typescript-eslint/[email protected]`, `[email protected]`) ([#50](https://github.com/brightlayer-ui/code-standards/issues/50)).
- Removed duplicated `no-shadow` rule and only use the `@typescript-eslint/no-shadow` rule. ([#33](https://github.com/brightlayer-ui/code-standards/issues/33)).

## v2.0.5 (October 19, 2021)

### Changed
Expand Down
3 changes: 2 additions & 1 deletion eslint-config/blui-rules.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ const bluiRules = {
'no-return-assign': 'error',
'no-self-compare': 'error',
'no-sequences': 'error',
'no-shadow': 'error',
'no-throw-literal': 'error',
'no-unused-expressions': 'error',
'no-useless-call': 'error',
Expand All @@ -105,6 +104,8 @@ const bluiRules = {
'prefer-spread': 'error',
'prefer-template': 'error',
'sort-imports': 'off',
"no-shadow": "off",
"@typescript-eslint/no-shadow": ["error"]
};

module.exports = bluiRules;
22 changes: 13 additions & 9 deletions eslint-config/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@brightlayer-ui/eslint-config",
"version": "2.0.5",
"version": "3.0.0-beta.0",
"description": "ESLint profile for Brightlayer UI",
"author": "Brightlayer UI <[email protected]>",
"main": "index.js",
Expand Down Expand Up @@ -30,16 +30,16 @@
"prettier": "prettier \"**/**.{ts,tsx,js,jsx,json,css,scss,html,md}\" --write"
},
"peerDependencies": {
"@typescript-eslint/eslint-plugin": "^4.8.0",
"eslint": ">= 5.0.0",
"typescript": ">= 3.4.0"
"@typescript-eslint/eslint-plugin": "^5.9.0",
"eslint": ">= 8.6.0",
"typescript": ">= 4.0.0"
},
"dependencies": {
"@typescript-eslint/parser": "^4.8.0",
"eslint-config-prettier": ">= 6.3.0"
"@typescript-eslint/parser": "^5.9.0",
"eslint-config-prettier": ">= 8.0.0"
},
"optionalDependencies": {
"eslint-plugin-react": "^7.16.0"
"eslint-plugin-react": "^7.28.0"
},
"keywords": [
"eslint",
Expand All @@ -50,7 +50,11 @@
],
"prettier": "@brightlayer-ui/prettier-config",
"devDependencies": {
"@brightlayer-ui/prettier-config": "latest",
"prettier": "^2.2.1"
"@brightlayer-ui/prettier-config": "^1.0.3",
"@typescript-eslint/eslint-plugin": "^5.9.0",
"eslint": ">= 8.6.0",
"eslint-plugin-react": "^7.28.0",
"prettier": "2.5.1",
"typescript": ">= 4.0.0"
}
}
Loading