Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule Tweak #52

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Rule Tweak #52

merged 1 commit into from
Jan 12, 2022

Conversation

emclaug2
Copy link
Contributor

Changes proposed in this Pull Request:

  • This rule @typescript-eslint/no-unsafe-argument was previously off, but after updating dependencies it has been switched on by default. This PR switches this rule back to 'off' since it's causing some linting issues in our templates and can be perceived as more annoying than helpful.

@huayunh
Copy link
Contributor

huayunh commented Jan 11, 2022

what's an example of a piece of code that you would love to write but is impeded by this linting rule?

@emclaug2
Copy link
Contributor Author

emclaug2 commented Jan 11, 2022

what's an example of a piece of code that you would love to write but is impeded by this linting rule?

Incorrect
<ThemeProvider theme={createMuiTheme(BLUIThemes.blue)}>

createMuiTheme is a function that accepts a ThemeOptions | undefined, & this rule throws an error because BLUIThemes.blue is only typed as a ThemeOptions. It has to be typed as both, which is just lame.

Correct
<ThemeProvider theme={createMuiTheme(BLUIThemes.blue as ThemeOptions | undefined)}>

@emclaug2 emclaug2 changed the title Update change log Rule Tweak Jan 11, 2022
@emclaug2 emclaug2 merged commit 6407b0e into dev Jan 12, 2022
@delete-merged-branch delete-merged-branch bot deleted the feature/new-rule branch January 12, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants