Add a few CSS classes to help with styling FidesJS button groups #4789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Passing run #7202 ↗︎
Details:
Review all test suite changes for PR #4789 ↗︎ |
||||||||||||||||||||
NevilleS
requested changes
Apr 11, 2024
There was a problem hiding this comment.
This is a super safe change to make and helps with the styling, so this is OK. I'd like to merge this into main and pull into our active release candidate, so let's keep the CHANGELOG as-is since this is aligned with #4782 .
Just need to get the ci checks green though to get my 👍 on it!
EDIT: Changed my mind, I think a basic CHANGELOG entry is warranted. I'll land this
NevilleS
changed the title
NevilleS
approved these changes
Apr 11, 2024
NevilleS
added a commit
that referenced
this pull request
Apr 12, 2024
Co-authored-by: Neville Samuell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
A small and backwards compatible change to add a few classes to the different button-groups to be able to differentiate between them in custom CSS.
Pre-Merge Checklist