Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 2.34.0 #4784

Closed
wants to merge 8 commits into from
Closed

release 2.34.0 #4784

wants to merge 8 commits into from

Conversation

adamsachs
Copy link
Contributor

@adamsachs adamsachs commented Apr 10, 2024

Release Checklist

The release checklist is a manual set of checks done before each release to ensure functionality of the most critical components of the application. Some of these steps are redundant with automated tests, while others are only tested here as part of this check.

This checklist should be copy/pasted into the final pre-release PR, and checked off as you complete each step.

Additionally, there is a robust Release Process page available in Confluence (internal only).

Pre-Release Steps

General

From the release branch, confirm the following:

  • Quickstart works: nox -s quickstart (verify you can complete the interactive prompts from the command-line)
  • Test environment works: nox -s "fides_env(test)" (verify the admin UI on localhost:8080, privacy center on localhost:3001, CLI and webserver)
  • Have Roger run a QATouch automation run

Next, run the following checks via the test environment:

API

CLI

Run these from within the test environment shell:

  • git reset --hard - Note: This is required for the pull command to work
  • fides user login
  • fides push src/fides/data/sample_project/sample_resources/
  • fides pull src/fides/data/sample_project/sample_resources/
  • fides evaluate src/fides/data/sample_project/sample_resources/
  • fides generate dataset db --credentials-id app_postgres test.yml - Note: Because the filesystem isn't mounted, the new file will only show up within the container
  • fides scan dataset db --credentials-id app_postgres

Privacy Center

  • Every navigation button works
  • DSR submission succeeds
  • Consent request submission succeeds

Admin UI

  • Every navigation button works
  • DSR approval succeeds
  • DSR execution succeeds

Documentation

  • Verify that the CHANGELOG is formatted correctly and clean up verbiage where needed
  • Verify that the CHANGELOG is representative of the actual changes

⚠️ Note that any updates that need to be made to the CHANGELOG should not be commited directly to the release branch.
Instead, they should be committed on a branch off of main and then PR'd and merged into main, before being cherry-picked
over to the release branch. This ensures that the CHANGELOG stays consistent between the release branch and main.

Publishing the release

When publishing the release, be sure to include the following sections in the release description:

  • ## Release Pull Request section that includes a link back to the release PR (i.e., this one!) for tracking purposes
  • ## QA Touch Test Run section that includes a link to the QATouch test run (QA team should provide this)

Post-Release Steps

@adamsachs adamsachs added the do not merge Please don't merge yet, bad things will happen if you do label Apr 10, 2024
Copy link

vercel bot commented Apr 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Apr 12, 2024 10:03pm

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 86.61%. Comparing base (a0faefa) to head (c1d0a02).
Report is 8 commits behind head on main.

Files Patch % Lines
src/fides/api/service/connectors/sql_connector.py 25.00% 3 Missing ⚠️
src/fides/api/util/saas_util.py 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4784      +/-   ##
==========================================
- Coverage   86.61%   86.61%   -0.01%     
==========================================
  Files         339      339              
  Lines       20078    20090      +12     
  Branches     2583     2586       +3     
==========================================
+ Hits        17391    17400       +9     
- Misses       2215     2217       +2     
- Partials      472      473       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Apr 11, 2024

Passing run #7247 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge c1d0a02 into a9d3ea9...
Project: fides Commit: 007c971bec ℹ️
Status: Passed Duration: 00:34 💡
Started: Apr 12, 2024 10:16 PM Ended: Apr 12, 2024 10:17 PM

Review all test suite changes for PR #4784 ↗︎

Copy link

cypress bot commented Apr 11, 2024

Passing run #7246 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Setuptools Handling of Dashes (#4794)
Project: fides Commit: c1d0a02f55
Status: Passed Duration: 00:35 💡
Started: Apr 12, 2024 10:15 PM Ended: Apr 12, 2024 10:15 PM

Review all test suite changes for PR #4784 ↗︎

@adamsachs
Copy link
Contributor Author

@Kelsey-Ethyca now that we've released, would you mind approving so i can close out the PR? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Please don't merge yet, bad things will happen if you do
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants