Disabling Cookie House loyalty database in default demo #4788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Passing run #7215 ↗︎
Details:
Review all test suite changes for PR #4788 ↗︎ |
||||||||||||||||||||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4788 +/- ##
==========================================
- Coverage 86.61% 86.28% -0.33%
==========================================
Files 339 339
Lines 20088 20088
Branches 2586 2586
==========================================
- Hits 17399 17333 -66
- Misses 2216 2289 +73
+ Partials 473 466 -7 ☔ View full report in Codecov by Sentry. |
NevilleS
approved these changes
Apr 11, 2024
NevilleS
reviewed
Apr 11, 2024
Comment on lines
45
to
46
| # uncomment the line below to enable the "loyalty database" | ||
| # FIDES_DEPLOY__CONNECTORS__POSTGRES_LOYALTY__HOST: postgres-test |
There was a problem hiding this comment.
NOTE: locally, the fides_env nox command will automatically provide your local .env file to fides deploy, so you shouldn't need to even modify this compose file - just have FIDES_DEPLOY__CONNECTORS__POSTGRES_LOYALTY__HOST set in your .env and it's good to go.
There was a problem hiding this comment.
Nice! In that case, I'll remove this mapping from the docker-compose
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Puts the Cookie House loyalty house behind an environment variable to keep demos simple but allow testing of custom identities.
Code Changes
docker-compose.ymlfor the demo environmentSteps to Confirm
nox -s "fides_env(test)"Loyalty IDPre-Merge Checklist
CHANGELOG.md