Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a few CSS classes to help with styling FidesJS button groups #4789

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Add a few CSS classes to help with styling FidesJS button groups #4789

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38d3464
Add a few CSS classes to help with styling
guncha Apr 11, 2024
ffed220
Format & update CHANGELOG
NevilleS Apr 11, 2024
91fd967
Add fides-modal-primary-actions class
NevilleS Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ The types of changes are:
- Changed display of Data Uses, Categories and Subjects to user friendly names in the Data map report [#4774](https://github.com/ethyca/fides/pull/4774)
- Update active disabled Fides.js toggle color to light grey [#4778](https://github.com/ethyca/fides/pull/4778)
- Update FidesJS fides_embed option to support embedding both banner & modal components [#4782](https://github.com/ethyca/fides/pull/4782)
- Add a few CSS classes to help with styling FidesJS button groups [#4789](https://github.com/ethyca/fides/pull/4789)

### Fixed
- Fixed select dropdowns being cut off by edges of modal forms [#4757](https://github.com/ethyca/fides/pull/4757)
Expand Down
6 changes: 4 additions & 2 deletions clients/fides-js/src/components/ConsentButtons.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export const ConsentButtons = ({
<LanguageSelector i18n={i18n} options={options} />
)}
{!!onManagePreferencesClick && (
<div className="fides-banner-button-group">
<div className="fides-banner-button-group fides-manage-preferences-button-group">
<Button
buttonType={isMobile ? ButtonType.SECONDARY : ButtonType.TERTIARY}
label={i18n.t("exp.privacy_preferences_link_label")}
Expand All @@ -52,7 +52,9 @@ export const ConsentButtons = ({
{includePrivacyPolicy && <PrivacyPolicyLink i18n={i18n} />}
<div
className={
isInModal ? "fides-modal-button-group" : "fides-banner-button-group"
isInModal
? "fides-modal-button-group"
NevilleS marked this conversation as resolved.
Show resolved Hide resolved
: "fides-banner-button-group fides-banner-primary-actions"
}
>
{firstButton}
Expand Down
Loading