-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TCF modal display data #3879
TCF modal display data #3879
Conversation
Passing run #3460 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
@@ -122,41 +122,3 @@ export const NoticeConsentButtons = ({ | |||
/> | |||
); | |||
}; | |||
|
|||
interface TcfConsentButtonProps { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved this to its own file
@@ -28,7 +28,7 @@ const Toggle = ({ | |||
onChange={() => { | |||
onChange(id); | |||
}} | |||
defaultChecked={checked} | |||
checked={checked} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is kind of a weird thing, but it turns out defaultChecked
only provides the initial value. this started not to work when I added the "select all/deselect toggles" which wanted to control other toggles' state. This seems to work well, though I had to update the cypress tests now that the checked
prop is a lil different
Closes #3809
Description Of Changes
https://www.loom.com/share/0c8b1c05f6be4f99aab109435d808a8a?sid=ebaa2503-68b3-43ff-aa07-b925982eddb5
Important caveats
fides_consent
cookie. We likely want to initialize values in the cookie the same way we do for notices. We haven't talked too much about what thenotice_key
s for these will be yet though. Initialize TCF preferences infides_consent
cookie and window object #3886Code Changes
Steps to Confirm
tcf_enabled
needs to be set to True: make a PATCH to/consent-settings
and settcf_enabled: true
in the request bodyturbo dev
inclients/admin-ui
and then visit localhost:3000clients/privacy-center
, runturbo dev
. If you have the admin-ui running, this will start the privacy center at localhost:3001Pre-Merge Checklist
CHANGELOG.md