-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fides-js consent reporting calls #3845
Conversation
Passing run #3369 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Trying to get this working for testing too! |
This looks really nice @allisonking! I verified that all of the appropriate columns are being filled out in the backend - saving that a notice was served creates two records, a ServedNoticeHistory (for every single time a notice served) as well as upserts a LastServedNotice that consolidates the last time a notice was served across versions/across time/across different identities of the same user. All of that looked good to me here - Verified that things look good on the backend too when you save preferences - How do you keep everything matched up on the FE? |
Whew, nice! The general flow is:
let me know if that answers your question? |
Got it that makes sense! |
Closes #3780
Description Of Changes
Adds calls to consent reporting in fides-js! We need fides-js to make one extra PATCH call to a new
/notices-served
endpoint when the modal is showing.This patch returns a list of served notice IDs, which needs to go into the existing PATCH to user preferences.
Code Changes
FidesUIShown
. I thought this would be a clean way to implement this feature since we only want to patch when the UI is shown (specifically, the modal). Also, I think we'll need this event for TCF work, so I thought it made sense to try it out now.FidesEvent
to take the whole cookie object as well asextraDetails
useConsentServed
which checks if this was from the modal, then issues the patchSteps to Confirm
turbo dev
/notices-served
. The payload should have aserving_component
ofoverlay
and some other parts that match your data (fides_user_device_id
, user geography, etc)/privacy-preferences
and make sure that thepreferences
has aserved_notice_history_id
, i.e.Pre-Merge Checklist
CHANGELOG.md