Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy center consent reporting #3847

Merged

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Jul 21, 2023

Closes #3780

Description Of Changes

This is the privacy center half of #3780. This part is more straightforward since there is only one view where users see notices, and we can use our handy RTK calls

Code Changes

  • Copies the relevant TS types to the privacy center
  • Add API call for consent reporting to redux
  • Call consent reporting API and include its response when we save user preferences
  • Cypress test

Steps to Confirm

  • Run the privacy center and visit the consent page
  • Observe that there is a call to /notices-served in the network tab which returns a list of served_notice_history_ids
  • Save your preferences
  • Observe in the call to /privacy-preferences that the served_notice_history_id is included with each preference

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@cypress
Copy link

cypress bot commented Jul 21, 2023

Passing run #3264 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge c489d22 into 7fe95ba...
Project: fides Commit: 550b4590f8 ℹ️
Status: Passed Duration: 01:03 💡
Started: Jul 21, 2023 4:11 PM Ended: Jul 21, 2023 4:12 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@allisonking allisonking marked this pull request as ready for review July 21, 2023 16:18
Copy link
Contributor

@eastandwestwind eastandwestwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great @allisonking !

@allisonking allisonking merged commit 74c6458 into aking/3780/consent-reporting-calls Jul 27, 2023
@allisonking allisonking deleted the aking/3780/pc-consent-reporting branch July 27, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants