Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

draft(op-challenger): support attackV2 & stepV2 for MSFDG #67

Closed
wants to merge 4 commits into from
Closed

draft(op-challenger): support attackV2 & stepV2 for MSFDG #67

wants to merge 4 commits into from

Conversation

JustXxx
Copy link

@JustXxx JustXxx commented Oct 2, 2024 •
edited by dajuguan
Loading

Todo

Add overall description

Tests

go test -v -tags faultdisputegamen ./game/fault/types/ -test.run TestMoveN
go test -v -tags faultdisputegamen ./game/fault/contracts -test.run TestAttackV2Tx

@JustXxx JustXxx requested review from qizhou and dajuguan October 2, 2024 17:56
@qizhou
Copy link

qizhou commented Oct 3, 2024

It is still a draft or not?

@JustXxx
Copy link
Author

JustXxx commented Oct 7, 2024

It is still a draft or not?

Yes, it's a draft version, mainly to see if the way of changes is appropriate.

@dajuguan dajuguan mentioned this pull request Oct 8, 2024
Closed
@JustXxx JustXxx changed the title Draft，Support Multi-section fault-proof dispute game in op-challenger, attackV2 function Draft,Support Multi-section fault-proof dispute game in op-challenger, attackV2 & stepV2 function Oct 13, 2024
@JustXxx JustXxx mentioned this pull request Oct 13, 2024
Closed
@dajuguan dajuguan changed the title Draft,Support Multi-section fault-proof dispute game in op-challenger, attackV2 & stepV2 function Draft: support Multi-section fault-proof dispute game in op-challenger, attackV2 & stepV2 function Oct 20, 2024
@dajuguan dajuguan changed the title Draft: support Multi-section fault-proof dispute game in op-challenger, attackV2 & stepV2 function draft(op-challenger): support Multi-section fault-proof dispute game in op-challenger, attackV2 & stepV2 function Oct 20, 2024
@dajuguan dajuguan changed the title draft(op-challenger): support Multi-section fault-proof dispute game in op-challenger, attackV2 & stepV2 function draft(op-challenger): support attackV2 & stepV2 for MSFDG Oct 20, 2024
qizhou pushed a commit that referenced this pull request Oct 23, 2024
@agusduha
fix: remove immutables from superchain erc20 beacon (ethereum-optimis…
3af1faf 
…m#12207)

* fix: remove immutables from superchain erc20 beacon (#67)

* fix: remove immutables from superchain erc20 beacon

* test: add superchain erc20 beacon tests

* fix: superchain erc20 beacon interface (#99)
Base automatically changed from bill/attackbranch to develop October 30, 2024 16:07
@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Nov 14, 2024
@github-actions github-actions bot closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qizhou qizhou Awaiting requested review from qizhou

@dajuguan dajuguan Awaiting requested review from dajuguan

Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JustXxx @qizhou