fix: remove immutables from superchain erc20 beacon #12207
Merged
+41
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: remove immutables from superchain erc20 beacon * test: add superchain erc20 beacon tests
tynes
previously approved these changes
Sep 30, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
|
cc @agusduha Looks like this needs a rebase now |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12207 +/- ##
===========================================
- Coverage 64.10% 63.91% -0.19%
===========================================
Files 52 52
Lines 4312 4312
===========================================
- Hits 2764 2756 -8
- Misses 1374 1383 +9
+ Partials 174 173 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
auto-merge was automatically disabled
October 15, 2024 20:35
Head branch was pushed to by a user without write access
maurelian
approved these changes
Oct 16, 2024
…erchain-beacon fix: merge develop
Merged
via the queue into
ethereum-optimism:develop
with commit Oct 17, 2024
3af1faf
47 checks passed
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
…m#12207) * fix: remove immutables from superchain erc20 beacon (ethereum-optimism#67) * fix: remove immutables from superchain erc20 beacon * test: add superchain erc20 beacon tests * fix: superchain erc20 beacon interface (ethereum-optimism#99)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
OptimismSuperchainERC20Beaconbecame proxiable in #11617 so we need to remove immutables variables from it.Tests
Add
OptimismSuperchainERC20BeaconTest