-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin typescript dependency to 4.4.4 for VM nightly tests #1602
Conversation
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
I will spend some time tomorrow and see if I can fix this on the karma-typescript side, then we won't need to pin the TS version and we can use my temporary fork until merged upstream. |
@@ -2,7 +2,10 @@ name: VM Nightly | |||
on: | |||
schedule: | |||
- cron: 0 0 * * * | |||
|
|||
push: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not disable the nightly tests right? It just adds it to this specific branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I'll remove it from our final PR if we end up going with this solution. This was just to allow me to test without running the entire ci suite every time I committed.
PR in flight to fix monounity/karma-typescript#502 |
The fix was merged into karma so we just need to keep an eye out for the next release so we can bump our dependency. I'll try building locally off whatever their latest commit from GitHub is and verify that it resolves the issue for us |
I went down the rabbit hole in ethereumjs/rlp to see if this could be patched by using an updated karma-typescript location, but since it's a monorepo it needs some transformation with https://gitpkg.now.sh and then some custom scripts for a build step. This monstrosity is what I came up with, that works here:
It does these things:
|
Wow. I guess that works. Nice work! |
libp2p-bootstrap
to 0.14.0 to resolve missing dependency issue within that depkarma
issue that causesvm
browser tests on nightly to fail.