-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin typescript dependency to 4.4.4 for VM nightly tests #1602
Closed
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4fae98f
pin typescript dependency to 4.4.4
acolytec3 126785b
Print package-lock.json to see typescript version
acolytec3 cee4c3e
Run nightly test on this branch
acolytec3 5886ecc
Update node to 14 for ci
acolytec3 db1cc7a
Remove package-lock dump to console
acolytec3 03e3b07
Update libp2p bootstrap ver
acolytec3 27622a9
Force Typescript to 4.4.4
acolytec3 78de029
Update typescript for all VM tests
acolytec3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,10 @@ name: VM Nightly | |
| on: | ||
| schedule: | ||
| - cron: 0 0 * * * | ||
|
|
||
| push: | ||
| branches: | ||
| - vm-nightly-typescript-version | ||
|
|
||
| env: | ||
| cwd: ${{github.workspace}}/packages/vm | ||
|
|
||
|
|
@@ -35,6 +38,12 @@ jobs: | |
| - run: npm i | ||
| working-directory: ${{github.workspace}} | ||
|
|
||
| # The API:browser tests are failing due to this Typescript issue | ||
| # https://github.com/monounity/karma-typescript/issues/499 | ||
| # so reverting to Typescript 4.4.4 for browser tests | ||
| - run: npm i [email protected] | ||
| working-directory: ${{github.workspace}} | ||
|
|
||
| - run: npm run test:API | ||
| - run: npm run test:API:browser | ||
|
|
||
|
|
@@ -62,6 +71,12 @@ jobs: | |
| - run: npm i | ||
| working-directory: ${{github.workspace}} | ||
|
|
||
| # The API:browser tests are failing due to this Typescript issue | ||
| # https://github.com/monounity/karma-typescript/issues/499 | ||
| # so reverting to Typescript 4.4.4 for browser tests | ||
| - run: npm i [email protected] | ||
| working-directory: ${{github.workspace}} | ||
|
|
||
| - run: npm run test:state:allForks | ||
|
|
||
| test-vm-blockchain: | ||
|
|
@@ -88,6 +103,9 @@ jobs: | |
| - run: npm i | ||
| working-directory: ${{github.workspace}} | ||
|
|
||
| - run: npm i [email protected] | ||
| working-directory: ${{github.workspace}} | ||
|
|
||
| - run: npm run test:blockchain:allForks | ||
| working-directory: '${{ env.cwd }}' | ||
|
|
||
|
|
@@ -115,4 +133,7 @@ jobs: | |
| - run: npm i | ||
| working-directory: ${{github.workspace}} | ||
|
|
||
| - run: npm i [email protected] | ||
| working-directory: ${{github.workspace}} | ||
|
|
||
| - run: npm run test:state:slow | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -86,7 +86,7 @@ | |
| "tape": "^5.3.1", | ||
| "ts-node": "^10.2.1", | ||
| "typedoc": "^0.22.4", | ||
| "typescript": "^4.4.2" | ||
| "typescript": "4.4.4" | ||
| }, | ||
| "contributors": [ | ||
| "Alex Beregszaszi <[email protected]>" | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not disable the nightly tests right? It just adds it to this specific branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I'll remove it from our final PR if we end up going with this solution. This was just to allow me to test without running the entire ci suite every time I committed.