-
Notifications
You must be signed in to change notification settings - Fork 36
Fix karma, readme updates, combine source to one file #109
Conversation
I know using 3 files instead of 1 is much more readable, just not sure about ESM support - or Deno support. I have been making my stuff work with those, and there are some things that you need to take into account. For example, in Deno you can't import .js files, and you need to specify extensions in imports. In ESM, you cannot import .ts files. My suggestion would be to move everything into one file and place it in root. After that, after the release, we could work on .esm tsconfig and Deno package. I could help here. I have worked around "many files" thing in bls12-381 by using export maps but we definitely don't want to force Deno users to do that (a separate .json file) |
…lint, renamings
…th browserify and was able to RLP encode in the browser from dist/index.js
dd03799
to
ab338ad
Compare
@paulmillr sounds good, thanks for the feedback, we already had 2 files (index, types) so I thought a third for utils would be harmless (the improved readability is great), but I am also in favor of broader ecosystem support, so whatever we need to do here - if it is one file then that's fine by me too. Appreciate your help with esm and Deno insights, we can probably bring these learnings over to our monorepo as well. |
For the karma-typescript fix, I wrote some of my findings in this comment: ethereumjs/ethereumjs-monorepo#1602 (comment) |
@talentlessguy has helped us with Deno compatibility in the past, let us know how this PR is looking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me!
thanks! |
This PR updates the karma-typescript dependency to a built version from master using gitpkg for the unreleased fix.
It also includes some refactoring and readme updates.