Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/ethapi: fix defaults for blob fields #29037

Merged
merged 4 commits into from
Feb 21, 2024
Merged

internal/ethapi: fix defaults for blob fields #29037

merged 4 commits into from
Feb 21, 2024

Conversation

s1na
Copy link
Contributor

@s1na s1na commented Feb 20, 2024 •
edited
Loading

setDefaults has shortcuts to avoid doing extra work if gasPrice or EIP-1559 fee fields are already provided by the user. This shortcut caused us not to fill the maxBlobFee as well.

fjl
fjl reviewed Feb 20, 2024
View reviewed changes
internal/ethapi/transaction_args.go Outdated
if args.BlobFeeCap != nil && args.BlobFeeCap.ToInt().Sign() == 0 {
return errors.New("maxFeePerBlobGas must be non-zero")
}
if b.ChainConfig().IsCancun(head.Number, head.Time) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part I don't agree with. Geth should always be able to create blob transactions, it shouldn't depend on the chain head for that. If there is a restriction about sending them, it will be enforced by the txpool, but AFAIK even the pool accepts them before Cancun.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I liked to have it because setDefaults doubles as a pre-validation for the EVM sometimes (createAccessList). Removed that check.

holiman
holiman reviewed Feb 20, 2024
View reviewed changes
internal/ethapi/transaction_args.go
Comment on lines +231 to +232
if args.MaxFeePerGas != nil || args.MaxPriorityFeePerGas != nil {
return errors.New("maxFeePerGas and maxPriorityFeePerGas are not valid before London is active")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this clause is also part of what @fjl would oppose (and I think I agree)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm so it's a good question what to do in this case. Should we set gasPrice or no?

holiman
holiman reviewed Feb 20, 2024
View reviewed changes
internal/ethapi/transaction_args.go Outdated
Comment on lines 289 to 292
isCancun := b.ChainConfig().IsCancun(b.CurrentHeader().Number, b.CurrentHeader().Time)
if !isCancun && (args.Blobs != nil || args.Commitments != nil || args.Proofs != nil || args.BlobHashes != nil) {
return errors.New("blobs are only valid after Cancun is active")
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be removed. But just so I understand, this would happen if the user passes in sidecar, but geth is not in cancun mode?
IF so, I think we should let the user proceed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed. Exactly if user sends in blobs to compute the proofs and commitments, however chain is still behind cancun.

holiman
holiman reviewed Feb 21, 2024
View reviewed changes
internal/ethapi/transaction_args.go Outdated Show resolved Hide resolved
internal/ethapi/transaction_args.go
if args.BlobFeeCap != nil && args.BlobFeeCap.ToInt().Sign() == 0 {
return errors.New("maxFeePerBlobGas must be non-zero")
}
if err := args.setCancunFeeDefaults(ctx, head, b); err != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

previously, setCancunFeeDefaults also internally called setLondonFeeDefaults, which makes sense to me -- makes it so it by default recursively does The Right Thing. You changed it so we now must make two explicit invocations.
Why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decoupled them. Reason is sometimes we should set cancun fields but we can skip london fields, as they are already provided by the user.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense because setCancunFeeDefaults is now just one step in a series of steps.

@fjl fjl added this to the 1.13.13 milestone Feb 21, 2024
@fjl fjl merged commit b47cf8f into ethereum:master Feb 21, 2024
2 of 3 checks passed
@dnhn dnhn mentioned this pull request Feb 21, 2024
Merged
shaspitz added a commit to primev/mev-commit-geth that referenced this pull request Apr 23, 2024
@shaspitz
Squashed commit of the following:
c5f325d 
commit 94579932b18931115f28aa7f87f02450bda084c9
Author: Mario Vega <[email protected]>
Date:   Tue Apr 23 07:10:24 2024 -0600

    core/vm: fix Prague contracts (#29612)

    core/vm: fix prague contracts

commit 256d4b099cf540ba99181d6e746d4a1eaebef054
Author: Felföldi Zsolt <[email protected]>
Date:   Tue Apr 23 13:31:32 2024 +0200

    beacon/light: request finality update explicitly when necessary (#29567)

    This PR adds an extra mechanism to sync.HeadSync that tries to retrieve the latest finality update from every server each time it sends an optimistic update in a new epoch (unless we already have a validated finality update attested in the same epoch).

    Note that this is not necessary and does not happen if the new finality update is delivered before the optimistic update. The spec only mandates light_client_finality_update events when a new epoch is finalized. If the chain does not finalize for a while then we might need an explicit request that returns a finality proof that proves the same finality epoch from the latest attested epoch.

commit b2b0e1da8cac279bf0466885d1abdc5d93402f41
Author: haoran <[email protected]>
Date:   Tue Apr 23 18:09:42 2024 +0800

    all: fix various typos (#29600)

    * core: fix typo

    * rpc: fix typo

    * snap: fix typo

    * trie: fix typo

    * main: fix typo

    * abi: fix typo

    * main: fix field comment for basicOp

commit 709e0b399712f113a907936b9f73da8c33afd3f1
Author: Aaron Chen <[email protected]>
Date:   Tue Apr 23 18:08:02 2024 +0800

    metrics: remove librato (#29624)

commit 0e380ddaf7d9ccba87d3a3688a3fb419b562451c
Author: HAOYUatHZ <[email protected]>
Date:   Tue Apr 23 18:06:25 2024 +0800

    miner: fix typos (#29625)

commit 853e0c23f36579423dbac8b4bcb9eeedb53daa9b
Author: Martin HS <[email protected]>
Date:   Tue Apr 23 10:33:36 2024 +0200

    eth/catalyst, trie/pathdb: fix flaky tests (#29571)

    This change fixes three flaky tests `TestEth2AssembleBlock`,`TestEth2NewBlock`, `TestEth2PrepareAndGetPayload` and `TestDisable`.

    ---------

    Co-authored-by: Gary Rong <[email protected]>

commit acd1eaae2c5006dd7f5ae42455bc7f61e5471013
Author: rjl493456442 <[email protected]>
Date:   Tue Apr 23 01:00:42 2024 +0800

    core: remove bad block checks (#29609)

commit e6689fe090cc56cb3f0c1948c5e5356ea1d20c1e
Author: Felföldi Zsolt <[email protected]>
Date:   Mon Apr 22 13:19:42 2024 +0200

    beacon/light/sync: print error log if checkpoint retrieval fails (#29532)

    Co-authored-by: Felix Lange <[email protected]>

commit 1ec7af261223d6dad9370ee8263f86347b190bab
Author: Ryan Schneider <[email protected]>
Date:   Mon Apr 22 03:17:06 2024 -0700

    eth: Add eth_blobBaseFee RPC and blob fields to eth_feeHistory (#29140)

    Co-authored-by: lightclient <[email protected]>
    Co-authored-by: Felix Lange <[email protected]>

commit c2dfe7a0c7321615e2524f1c677266de26d30d05
Author: Péter Szilágyi <[email protected]>
Date:   Mon Apr 22 12:56:54 2024 +0300

    go.mod: update golang/x repos (#29604)

commit 82b0dec7135b281c1b03064d50959dc992c2f94f
Author: Felix Lange <[email protected]>
Date:   Mon Apr 22 10:31:17 2024 +0200

    eth/filters: remove support for pending logs (#29574)

    This change removes support for subscribing to pending logs.

    "Pending logs" were always an odd feature, because it can never be fully reliable. When support for it was added many years ago, the intention was for this to be used by wallet apps to show the 'potential future token balance' of accounts, i.e. as a way of notifying the user of incoming transfers before they were mined. In order to generate the pending logs, the node must pick a subset of all public mempool transactions, execute them in the EVM, and then dispatch the resulting logs to API consumers.

commit ad3d8cb12a368ea901a2b36b0708480065235308
Author: xiaodong <[email protected]>
Date:   Mon Apr 22 16:13:03 2024 +0800

    cmd/geth: remove unused parameter (#29602)

commit 28ccb2bbf82af487da856d459d4daaa7c0d9b064
Author: Aaron Chen <[email protected]>
Date:   Sun Apr 21 17:14:13 2024 +0800

    build: fix string compare for SortFunc (#29595)

commit 98f504f69fad798c03ad43a1fc40f243d2fc8215
Author: bugmaker9371 <[email protected]>
Date:   Sun Apr 21 17:13:36 2024 +0800

    p2p/discover: fix test error messages (#29592)

commit 2e06fbd409d64a400c19d26d7af383f868e34f11
Author: Marius van der Wijden <[email protected]>
Date:   Fri Apr 19 13:46:43 2024 +0200

    core/vm: add KZG benchmark (#29583)

commit cce879b71b772ca9df83ada499127d6ca8e7c8f6
Author: Mario Vega <[email protected]>
Date:   Fri Apr 19 02:07:52 2024 -0600

    tests: define cancun-to-prague at 15K chainconig (#29557)

    tests: add cancun->prague config

commit 81349ff6e53a5bcb7adee210274171c22ae64053
Author: ids <[email protected]>
Date:   Fri Apr 19 15:58:14 2024 +0800

    eth/catalyst: fix typo (#29580)

commit 823719b9e1b72174cd8245ae9e6f6f7d7072a8d6
Author: Martin HS <[email protected]>
Date:   Thu Apr 18 09:08:25 2024 +0200

    core/vm: enable bls-precompiles for Prague (#29552)

    enables the bls-contracts on the "Prague" config, so that the testing-team can activate them to make tests.

commit b5902cf595b3d83f6fa96b5a501213daec169f15
Author: rjl493456442 <[email protected]>
Date:   Thu Apr 18 14:48:50 2024 +0800

    core: remove unused fields (#29569)

commit 5f9514530818c4436238d4740111bd699470f0f1
Author: ucwong <[email protected]>
Date:   Thu Apr 18 07:21:23 2024 +0100

    eth/ethconfig: regenerate autogen files (#29559)

    eth/ethconfig/gen_config.go : go generate fix

commit 0da69e84c0d481e42f60cecc1562c208525117eb
Author: Felföldi Zsolt <[email protected]>
Date:   Wed Apr 17 17:07:28 2024 +0200

    beacon/blsync: proceed with empty finalized hash if proof is not expected soon (#29449)

    * beacon/blsync: proceed with empty finalized hash if proof is not expected soon

    * Update beacon/blsync/block_sync.go

    Co-authored-by: Felix Lange <[email protected]>

    * beacon/blsync: fixed linter warning

    * Update beacon/blsync/block_sync.go

    Co-authored-by: lightclient <[email protected]>

    ---------

    Co-authored-by: Felix Lange <[email protected]>
    Co-authored-by: lightclient <[email protected]>

commit 1e9bf2a09ed3d82ac1aa69750a556f3ce127721d
Author: Aaron Chen <[email protected]>
Date:   Wed Apr 17 19:55:31 2024 +0800

    core/state: fix bug in statedb.Copy and remove unnecessary preallocation (#29563)

    This change removes an unnecessary preallocation and fixes a flaw with no-op copies of some parts of the statedb

commit 74e8d2da97aacc2589d39584f6af74cb9d62ee3f
Author: Aaron Chen <[email protected]>
Date:   Wed Apr 17 14:24:30 2024 +0800

    trie/utils: simplify codeChunkIndex (#29480)

    minor simplification to the code

commit 27de7dec658839722c8d84963d0a9b0c09a25d25
Author: rjl493456442 <[email protected]>
Date:   Wed Apr 17 13:52:08 2024 +0800

    ethdb/pebble: print warning log if pebble performance degrades (#29478)

commit 92da96b7d5400f006774e15d154f5fa8ea1ebd9f
Author: Devon Bear <[email protected]>
Date:   Tue Apr 16 08:57:57 2024 -0400

    core/vm: refactor push-functions to use `min` builtin (#29515)

    * optimize-push

    * revert push1 change

    * Update instructions.go

    * core/vm: go format

    * core/vm: fix nit

    ---------

    Co-authored-by: Felix Lange <[email protected]>
    Co-authored-by: Martin Holst Swende <[email protected]>
    Co-authored-by: Péter Szilágyi <[email protected]>

commit 0a5102881975120b5d321e40c325edba778314d8
Author: persmor <[email protected]>
Date:   Tue Apr 16 21:44:00 2024 +0900

    all: fix various typos (#29542)

    * core/rawdb: fix typos

    * accounts/abi: fix typos

    * metrics: fix typo

    * beacon: fix typo

    * crypto: fix typo

    * rpc: fix typo

    * rpc: fix typo

commit 5ffd940b7e67ba7bb3810a9ed234b5dc45c23cdb
Author: ucwong <[email protected]>
Date:   Tue Apr 16 13:42:16 2024 +0100

    core: go fmt (#29544)

commit 65e32d47ea336b56d6c4bcfe212c11e8f38032bf
Author: ucwong <[email protected]>
Date:   Tue Apr 16 13:32:50 2024 +0100

    go.mod: clean up indirection (#29553)

commit 72f69366de1d09fbe4738982fec9948ed5a69892
Author: Chris Ziogas <[email protected]>
Date:   Tue Apr 16 15:31:19 2024 +0300

    c.d/utils: rename vmtrace.config to vmtrace.jsonconfig (#29554)

    rename vmtrace.config to vmtrace.jsonconfig

    for consinstency with t8ntool trace.jsonconfig

commit fadd9d8b81324b0d4405de2837ac9939b2cef6c5
Author: law wang <[email protected]>
Date:   Tue Apr 16 17:21:20 2024 +0800

    eth/catalyst: fix log (#29549)

    log:output the correct variable

    Co-authored-by: steven <[email protected]>

commit f437307877f4c8e423f787de5c9636b985d322f5
Author: Marius van der Wijden <[email protected]>
Date:   Tue Apr 16 10:53:43 2024 +0200

    core/vm: update gascosts for BLS12-381 + use gnark instead of kilic (#29441)

    This PR updates the bls contracts from our internal implementation which is an unmaintained fork of the kilic library to the gnark-crypto library that is actively maintained by consensys.

    It also updates the gas-costs according to the EIP

commit 71c78bf56da29dc8b85cddc9da09eabf18131ee8
Author: Darioush Jalali <[email protected]>
Date:   Tue Apr 16 01:38:25 2024 -0700

    rpc: close Clients in tests (#29512)

commit e4ecaf89cf5ee6233094f738c4978020fe63e237
Author: Marcus Baldassarre <[email protected]>
Date:   Tue Apr 16 04:37:18 2024 -0400

    rpc: implement Unwrap() for wsHandshakeError (#29522)

commit d3c4466edd43fff9ac30162073795d8776070c5d
Author: rjl493456442 <[email protected]>
Date:   Tue Apr 16 15:05:36 2024 +0800

    core, eth/protocols/snap, trie: fix cause for snap-sync corruption, implement gentrie (#29313)

    This pull request defines a gentrie for snap sync purpose.

    The stackTrie is used to generate the merkle tree nodes upon receiving a state batch. Several additional options have been added into stackTrie to handle incomplete states (either missing states before or after).

    In this pull request, these options have been relocated from stackTrie to genTrie, which serves as a wrapper for stackTrie specifically for snap sync purposes.

    Further, the logic for managing incomplete state has been enhanced in this change. Originally, there are two cases handled:

    -    boundary node filtering
    -    internal (covered by extension node) node clearing

    This changes adds one more:

    - Clearing leftover nodes on the boundaries.

    This feature is necessary if there are leftover trie nodes in database, otherwise node inconsistency may break the state healing.

commit ef5ac3fb7ae5bf41a465cc32845631f01ff823ef
Author: Martin HS <[email protected]>
Date:   Mon Apr 15 17:35:35 2024 +0200

    eth/filters: enforce topic-limit early on filter criterias (#29535)

    This PR adds a limit of 1000 to the "inner" topics in a filter-criteria

commit 67422e2a565784edaeade7d3bb747dc13f6863cf
Author: Seungbae Yu <[email protected]>
Date:   Mon Apr 15 21:58:17 2024 +0900

    p2p/nat: fix typos in comments (#29536)

commit 84b12df09e0a67e99a3943f26ccf1b6e6c19a85a
Author: Martin HS <[email protected]>
Date:   Mon Apr 15 14:54:51 2024 +0200

    core/rawdb: add sanity-limit to header accessor (#29534)

commit 3705acd1a97b2cc9bbb092b326a9d8cfbc42037a
Author: yudrywet <[email protected]>
Date:   Mon Apr 15 14:40:42 2024 +0800

    cmd/utils: fix typo in comment (#29528)

commit b179b7b8e7c9cac7ac21da385dbedc9f24ce3755
Author: Abirdcfly <[email protected]>
Date:   Mon Apr 15 14:34:31 2024 +0800

    all: remove duplicate word in comments (#29531)

    This change removes some duplicate words in in comments

commit bd91810462187086b2715fd343aa427e181d89a2
Author: forestkeeperio.eth <[email protected]>
Date:   Thu Apr 11 05:06:49 2024 -0600

    cmd: fix some typos in readmes (#29405)

    * Update README.md

    updated for readability

    * Update rules.md

    Updated for readability and typos

commit b9010f3e872492c1513c853cb5f3f8ce03eff2b5
Author: Newt6611 <[email protected]>
Date:   Thu Apr 11 16:30:15 2024 +0800

    rpc: fix comment grammar (#29507)

commit 9dcf8aae4742cc4220065489a5bdcf045c398616
Author: rjl493456442 <[email protected]>
Date:   Wed Apr 10 17:02:45 2024 +0800

    eth/protocols/snap: skip retrieval for completed storages (#29378)

    * eth/protocols/snap: skip retrieval for completed storages

    * eth/protocols/snap: address comments from peter

    * eth/protocols/snap: add comments

commit 34aac1d7562bf141fe6da1d4f3cdea8819e7b23b
Author: Aaron Chen <[email protected]>
Date:   Tue Apr 9 18:14:30 2024 +0800

    all: use big.Sign to compare with zero (#29490)

commit f202dfdd478467ffa44217fe414ec8c31a793dff
Author: Sina M <[email protected]>
Date:   Tue Apr 9 12:12:02 2024 +0200

    core/tracing: add changelog (#29388)

    Co-authored-by: Matthieu Vachon <[email protected]>

commit 0bbd88bda04698c457077318ae8442e2611ea3b0
Author: Bin <[email protected]>
Date:   Tue Apr 9 14:51:54 2024 +0800

    all: use timer instead of time.After in loops, to avoid memleaks (#29241)

    time.After is equivalent to NewTimer(d).C, and does not call Stop if the timer is no longer needed. This can cause memory leaks. This change changes many such occations to use NewTimer instead, and calling Stop once the timer is no longer needed.

commit 1126c6d8a57f1b7d9af0b39ac52f6eeb435f66f9
Author: rjl493456442 <[email protected]>
Date:   Tue Apr 9 14:37:18 2024 +0800

    core: add txlookup lock (#29343)

    This change adds a lock to the transaction lookup cache, to avoid the case where reorgs make the lookup return inconsistent results.

commit 3caf617dcdee9fc1d2e9070bfdba370b20231884
Author: cui <[email protected]>
Date:   Tue Apr 9 14:33:36 2024 +0800

    core/vm: move bls precompiles to correct addresses (#29445)

    core: make bls precompiled contract use the correct address as in eip

commit f447de936c31e6a64470f3c102da85f245fe9640
Author: Mohanson <[email protected]>
Date:   Tue Apr 9 14:27:13 2024 +0800

    rlp: replace reflect.PtrTo with reflect.PointerTo (#29488)

    reflect.PtrTo has been deprecated and superseded by reflect.PointerTo

commit 70bf94c34e4a6320c865a90cbfeec38a0aef7378
Author: Aaron Chen <[email protected]>
Date:   Tue Apr 9 14:22:53 2024 +0800

    internal, signer/core: replace path.Join with filepath.Join (#29489)

commit c170cc0ab0a1f60adcde80d0af8e3050ee19da93
Author: rjl493456442 <[email protected]>
Date:   Mon Apr 8 21:48:37 2024 +0800

    core/vm: reject contract creation if the storage is non-empty (#28912)

    This change implements EIP-7610, which rejects the contract deployment if the destination has non-empty storage.

commit 3c75c64e6bbf64f842c6f725a595713262c2f8fe
Author: seayyyy <[email protected]>
Date:   Mon Apr 8 19:02:56 2024 +0800

    core: fix typo (#29438)

commit c3465cb5ba94e8ee4153319416db9484406084ee
Author: Sina M <[email protected]>
Date:   Mon Apr 8 13:01:22 2024 +0200

    core: fix dev mode genesis difficulty (#29469)

    The dev mode is nowadays in Merge-mode from genesis, hence the difficulty of the first block should be zero.

commit ed4bc7f27ba071403484240fa71b4878c4ca9756
Author: Aaron Chen <[email protected]>
Date:   Mon Apr 8 18:59:17 2024 +0800

    all: replace fmt.Errorf() with errors.New() if no param required (#29472)

commit cfc7d06cc91122f44d09592ddc616fb189bc4ca4
Author: Aaron Chen <[email protected]>
Date:   Mon Apr 8 18:58:37 2024 +0800

    signer/core/apitypes: use slices.Contains (#29474)

commit 0dc09da7db47de4a9a9eb6ea335e2e367fae6015
Author: imalasong <[email protected]>
Date:   Mon Apr 8 17:29:49 2024 +0800

    all: replace path.Join with filepath.Join (#29479)

    * core/rawdb: replace file.Join with filepath.Join

    Signed-off-by: xiaochangbai <[email protected]>

    * internal/build: replace file.Join with filepath.Join

    Signed-off-by: xiaochangbai <[email protected]>

    ---------

    Signed-off-by: xiaochangbai <[email protected]>

commit 7aafad2233b676b7beaf56e89f82360704d669d0
Author: Martin HS <[email protected]>
Date:   Sat Apr 6 12:22:55 2024 +0200

    core/vm: better error-info for vm errors (#29354)

commit 8876868bb831cef307d7e72c6848bd0943ba1e24
Author: Roberto Bayardo <[email protected]>
Date:   Sat Apr 6 03:17:41 2024 -0700

    log: default JSON log handler should log all verbosity levels (#29471)

    Co-authored-by: lightclient <[email protected]>

commit ccb76c01d7b1ce4d77d2bb309419cc78f42659ca
Author: Aaron Chen <[email protected]>
Date:   Sat Apr 6 18:16:25 2024 +0800

    eth/tracers: use slices.Contains (#29461)

commit 74995bf8a169bb9d07333e56623ea039b8664710
Author: Aaron Chen <[email protected]>
Date:   Sat Apr 6 18:05:06 2024 +0800

    all: use slices.Contains (#29459)

    Co-authored-by: Felix Lange <[email protected]>

commit cc348a601ee816d6c0e2c4d7246c810f3b61e798
Author: georgehao <[email protected]>
Date:   Sat Apr 6 17:09:30 2024 +0800

    common/prque: fix godoc comments (#29460)

    Co-authored-by: Felix Lange <[email protected]>

commit 4458905f261d5d9ba5fda3d664f9bb80346ab404
Author: Martin HS <[email protected]>
Date:   Fri Apr 5 21:01:39 2024 +0200

    signer/core/apitypes: fix apitypes breakage due to bitrotted PR (#29470)

commit 7ee9a6e89f59cee21b5852f5f6ffa2bcfc05a25f
Author: Martin HS <[email protected]>
Date:   Fri Apr 5 19:29:44 2024 +0200

    signer: implement blob txs sendtxargs, enable blobtx-signing (#28976)

    This change makes it possible to sign blob transactions

commit 35fcf9c52b806d2a7eba0da4f65c97975200a2b2
Author: Felföldi Zsolt <[email protected]>
Date:   Thu Apr 4 16:30:27 2024 +0200

    beacon/types: enforce fork order based on known forks list (#29380)

    Co-authored-by: Felix Lange <[email protected]>

commit 15ff066a24964ea16742420abecc7e4ae5e9bce0
Author: Aaron Chen <[email protected]>
Date:   Thu Apr 4 21:52:38 2024 +0800

    trie/utils: change Div+Mod to DivMod (#29413)

    * trie/utils: change Div+Mod to DivMod

    * trie/utils: gofmt

commit e3bdd84e9881041e6004ebc3e78c1211d58ebe83
Author: Péter Szilágyi <[email protected]>
Date:   Thu Apr 4 16:51:10 2024 +0300

    core/txpool: repair the limbo Billy too on unclean shutdowns (#29451)

commit a851e39cbecf116ef2dc64f0b37b0300dc762931
Author: lmittmann <[email protected]>
Date:   Thu Apr 4 15:50:31 2024 +0200

    core/types: use new atomic types in caches (#29411)

    * use generic atomic types in tx caches

    * use generic atomic types in block caches

    * eth/catalyst: avoid copying tx in test

    ---------

    Co-authored-by: lmittmann <[email protected]>
    Co-authored-by: Felix Lange <[email protected]>

commit 9cb8de87037be7c38343b2f84c534887e7525c5d
Author: lightclient <[email protected]>
Date:   Thu Apr 4 06:26:10 2024 -0400

    internal/debug: convert legacy log level value in debug_verbosity (#29356)

commit 9dfe728909bc7ff0709c69d3f090804d2516652c
Author: cui <[email protected]>
Date:   Thu Apr 4 18:24:49 2024 +0800

    p2p/discover: using slices.Contains (#29395)

commit 8bd03341689c992d633f3988b3a7fbc15aec75e6
Author: guangwu <[email protected]>
Date:   Thu Apr 4 18:20:54 2024 +0800

    crypto/signify: close tmp key file in test (#29444)

commit 2e0c5e05ba355a722eb6eb9bc338de4949eee20d
Author: cui <[email protected]>
Date:   Thu Apr 4 18:19:48 2024 +0800

    p2p/dnsdisc: using clear builtin func (#29418)

    Co-authored-by: Felix Lange <[email protected]>

commit eea0acc54959df779189dbfc972578ae56ac4d33
Author: cui <[email protected]>
Date:   Thu Apr 4 17:59:54 2024 +0800

    log: using maps.Clone (#29392)

commit 6b39e9236c278d9c4722505bb88a769fd21ca4b8
Author: cui <[email protected]>
Date:   Thu Apr 4 17:58:44 2024 +0800

    beacon/engine: using slices.Contains (#29396)

commit 1f8f1377e62d2ca8aba04f0df7772ed665662bf7
Author: Marius Kjærstad <[email protected]>
Date:   Thu Apr 4 11:00:27 2024 +0200

    build: upgrade -dlgo version to Go 1.22.2 (#29448)

commit 7bb3fb1481acbffd91afe19f802c29b1ae6ea60c
Author: cui <[email protected]>
Date:   Wed Apr 3 14:08:52 2024 +0800

    eth: simplify peer counting logic (#29420)

commit dfb3d46098520e90811c6ada3f8e142789c25832
Author: Ng Wei Han <[email protected]>
Date:   Wed Apr 3 03:18:28 2024 +0800

    p2p: add inbound and outbound peers metric (#29424)

commit a83e57666d5a691883ab2890b63bda1b2c3e1c64
Author: cui <[email protected]>
Date:   Wed Apr 3 03:17:34 2024 +0800

    eth/fetcher: using slices.Contains (#29383)

commit 12dcc162d05e87b6492c065458f2d7310b3cf791
Author: cui <[email protected]>
Date:   Tue Apr 2 21:45:25 2024 +0800

    common/lru: use clear builtin (#29399)

commit ab6419ccd8b11e041e27f8865f59ab111a2c6161
Author: cui <[email protected]>
Date:   Tue Apr 2 20:56:12 2024 +0800

    core/state: use maps.Clone (#29365)

    core: using maps.Clone

commit fe0bf325a68504292f910240f8da6243defffa71
Author: rjl493456442 <[email protected]>
Date:   Tue Apr 2 20:25:06 2024 +0800

    cmd/evm: reopen the statedb for dumping (#29437)

commit 0bd03dbc5597175d79067270c0710604cba489cf
Author: cui <[email protected]>
Date:   Tue Apr 2 17:25:57 2024 +0800

    eth/filter: using atomic.Pointer instead of atomic.Value (#29435)

commit e63f992fed51d5a576ea2890cd7eb3000c9e6884
Author: Miles Chen <[email protected]>
Date:   Tue Apr 2 17:25:19 2024 +0800

    rpc: fix ipc max path size (#29385)

commit 31e63fcf66188504e0b1941059394cf5df49bc17
Author: cui <[email protected]>
Date:   Tue Apr 2 16:47:15 2024 +0800

    rlp: using maps.Clone (#29434)

commit fde90443a4af0c8a0c0d7bdaf833a223de560cb3
Author: carehabit <[email protected]>
Date:   Tue Apr 2 15:05:53 2024 +0800

    log: replace the outdated link (#29412)

commit 8c5576b1ac89473c7ec15c9b03d1ca02e9499dcc
Author: Delweng <[email protected]>
Date:   Mon Apr 1 20:53:56 2024 +0800

    eth/tracers: fix base fee and set blob fee in tests (#29376)

    Signed-off-by: jsvisa <[email protected]>
    Co-authored-by: Sina Mahmoodi <[email protected]>

commit 6c9f7029823cac48291558aa0a76cbd653830f51
Author: cui <[email protected]>
Date:   Mon Apr 1 11:45:56 2024 +0800

    core/types: using maps.Clone (#29398)

commit c39d00e316943fa613f10ceff262482ea3aa2c65
Author: cui <[email protected]>
Date:   Mon Apr 1 11:42:50 2024 +0800

    trie: using maps.Clone (#29419)

commit a3829178af6cec64d6def9131b9340a3328cc4fc
Author: Brandon Liu <[email protected]>
Date:   Fri Mar 29 00:35:40 2024 +0800

    eth/tracers/js: consistent name for method receivers (#29375)

commit 0183c7ad8225f82e2c23b9bc6329c19d7f0269c5
Author: cui <[email protected]>
Date:   Thu Mar 28 21:09:21 2024 +0800

    eth/tracers/logger: using maps.Equal (#29384)

    Co-authored-by: Felix Lange <[email protected]>

commit 7481398a2471f52de277627cc473190f0c2569c8
Author: cui <[email protected]>
Date:   Thu Mar 28 19:13:41 2024 +0800

    core/state: using slices.Clone (#29366)

commit 3754a6cc922f88f50ed0479cfb836676936384d3
Author: cui <[email protected]>
Date:   Thu Mar 28 19:07:38 2024 +0800

    p2p/dnsdisc: using maps.Copy (#29377)

commit 3b77e0ff4bcce8c0c9f18f23625a6fe69d17bbed
Author: rjl493456442 <[email protected]>
Date:   Thu Mar 28 19:06:57 2024 +0800

    core: remove unused code (#29381)

commit 7aba6511b0cbe910a0db9d345487d2c6ef301e53
Author: cui <[email protected]>
Date:   Thu Mar 28 19:06:44 2024 +0800

    ethdb/dbtest: replace reflect.DeepEqual with slices.Equal (#29382)

commit 767b00b0b514771a663f3362dd0310fc28d40c25
Author: Sina M <[email protected]>
Date:   Wed Mar 27 16:12:57 2024 +0100

    t8ntool: add optional call frames to json logger (#29353)

    Adds a flag `--trace.callframes` to t8n which will log info when entering or exiting a call frame in addition to the execution steps.

    ---------

    Co-authored-by: Mario Vega <[email protected]>

commit fa5019de196274afd2426d300cab01d60b2a0c56
Author: crazeteam <[email protected]>
Date:   Wed Mar 27 20:16:29 2024 +0800

    accounts/keystore: fix typos in comments (#29336)

commit 8bb8f23bb25ab69cfb7065d7dbb3fd6e5f6227a8
Author: Pawan Dhananjay <[email protected]>
Date:   Wed Mar 27 17:45:57 2024 +0530

    beacon/engine: Fix json param name in GetClientVersionV1 (#29351)

    Fix json param name

commit 304879da20200f6912d241ccd471e140d3487093
Author: rjl493456442 <[email protected]>
Date:   Wed Mar 27 09:35:33 2024 +0800

    eth/protocols/snap: check storage root existence for hash scheme (#29341)

commit da7469e5c44feec120555c8f697f75b94b2884bb
Author: Guillaume Ballet <[email protected]>
Date:   Tue Mar 26 21:25:41 2024 +0100

    core: add an end-to-end verkle test (#29262)

    core: add a simple verkle test

    triedb, core: skip hash comparison in verkle

    core: remove legacy daoFork logic in verkle chain maker

    fix: nil pointer in tests

    triedb/pathdb: add blob hex

    core: less defensive

    Co-authored-by: Ignacio Hagopian <[email protected]>
    Co-authored-by: Martin HS <[email protected]>
    Co-authored-by: Gary Rong <[email protected]>

commit 723b1e36ad6a9e998f06f74cc8b11d51635c6402
Author: Aaron Chen <[email protected]>
Date:   Wed Mar 27 04:01:28 2024 +0800

    all: fix mismatched names in comments (#29348)

    * all: fix mismatched names in comments

    * metrics: fix mismatched name in UpdateIfGt

commit 58a3e2f1802eb7dd8e893a6a7be7f009edeeffd8
Author: jwasinger <[email protected]>
Date:   Tue Mar 26 07:21:39 2024 -0700

    core/state: perform updates before deletions when mutating tries (#29201)

    This addresses an edge-case (detailed in the code comment) where the computation of the intermediate trie root would force the unnecessary resolution of a hash node. The change makes it so that when we process changes from a block, we first process trie-updates and afterwards process trie-deletions.

commit 1dd898c24e85980a3ba9fcc203f00a3ea2f060d6
Author: Martin HS <[email protected]>
Date:   Tue Mar 26 15:04:15 2024 +0100

    tests: fix panic via state test runner using json logger (#29349)

    * tests: fix panic via state test runner using json logger

    * tests: also invoke OnTxEnd

commit f2a6ac17b255fe037bf528bc8368e61051cd4df4
Author: Aaron Chen <[email protected]>
Date:   Tue Mar 26 19:26:44 2024 +0800

    eth/catalyst: fix flaw in withdrawal-gathering in simulated beacon (#29344)

    return after reaching maxCount

commit 738b5a586e329965539877434b695bb61015d4c7
Author: Matthieu Vachon <[email protected]>
Date:   Tue Mar 26 00:01:13 2024 -0400

    Removes some leftover `err` check (#29339)

    Before, `ToMessage` was returning both the resulting `Message` and an error while no error is returned now.

    Those error checks were probably leftover from the past.

commit 100c0f47debad7924acefd48382bd799b67693cf
Author: Felföldi Zsolt <[email protected]>
Date:   Mon Mar 25 20:28:55 2024 +0100

    beacon/blsync: fixed blsync command line params (#29335)

commit eda9cb7b362b02c9c4550d77385997ed86981757
Author: Felix Lange <[email protected]>
Date:   Mon Mar 25 20:27:50 2024 +0100

    beacon/light/api: improve handling of event stream setup failures (#29308)

    The StartHeadListener method will only be called once. So it can't just make one attempt
    to connect to the eventsource endpoint, it has to keep trying. Note that once the stream
    is established, the eventsource implementation itself will keep retrying.

commit 5cea7a6230a6f070dd484aa6d883605f148445a4
Author: Roberto Bayardo <[email protected]>
Date:   Mon Mar 25 10:03:44 2024 -0700

    ethclient/simulated: clean up Node resources when simulated backend is closed (#29316)

commit 14cc967d1964d3366252193cadd4bfcb4c927ac1
Author: Martin HS <[email protected]>
Date:   Mon Mar 25 07:50:18 2024 +0100

    all: remove dependency on golang.org/exp (#29314)

    This change includes a leftovers from https://github.com/ethereum/go-ethereum/pull/29307
    - using the [new `slices` package](https://go.dev/doc/go1.21#slices) and
    - using the [new `cmp.Ordered`](https://go.dev/doc/go1.21#cmp) instead of exp `constraints.Ordered`

commit ae470044878f15beb67eb7e66c117c9ad48f3a7b
Author: deterclosed <[email protected]>
Date:   Mon Mar 25 10:16:44 2024 +0800

    eth: fix typo (#29320)

commit 6f1fb0c29ff25318e688c15581d0c28dcefb75ce
Author: Nathan <[email protected]>
Date:   Sun Mar 24 20:51:34 2024 +0800

    metrics/influxdb: skip float64-precision-dependent tests on arm64 (#29047)

    metrics/influxdb: fix failed cases caused by float64 precision on arm64

commit 064f37d6f67a012eea0bf8d410346fb1684004b4
Author: Sina M <[email protected]>
Date:   Fri Mar 22 18:53:53 2024 +0100

    eth/tracers: live chain tracing with hooks (#29189)

    Here we add a Go API for running tracing plugins within the main block import process.

    As an advanced user of geth, you can now create a Go file in eth/tracers/live/, and within
    that file register your custom tracer implementation. Then recompile geth and select your tracer
    on the command line. Hooks defined in the tracer will run whenever a block is processed.

    The hook system is defined in package core/tracing. It uses a struct with callbacks, instead of
    requiring an interface, for several reasons:

    - We plan to keep this API stable long-term. The core/tracing hook API does not depend on
      on deep geth internals.
    - There are a lot of hooks, and tracers will only need some of them. Using a struct allows you
       to implement only the hooks you want to actually use.

    All existing tracers in eth/tracers/native have been rewritten to use the new hook system.

    This change breaks compatibility with the vm.EVMLogger interface that we used to have.
    If you are a user of vm.EVMLogger, please migrate to core/tracing, and sorry for breaking
    your stuff. But we just couldn't have both the old and new tracing APIs coexist in the EVM.

    ---------

    Co-authored-by: Matthieu Vachon <[email protected]>
    Co-authored-by: Delweng <[email protected]>
    Co-authored-by: Martin HS <[email protected]>

commit 38eb8b3e20bf237a78fa57e84fa63c2d05a44635
Author: George Ma <[email protected]>
Date:   Fri Mar 22 20:29:12 2024 +0800

    all: fix docstrings (#29311)

commit d9bde37ac3a5a9569a0c0a35f8c872932d640802
Author: Martin HS <[email protected]>
Date:   Fri Mar 22 13:17:59 2024 +0100

    log: use native log/slog instead of golang/exp (#29302)

commit 6490d9897ab00290d188b1893d1874e977fb4c66
Author: rjl493456442 <[email protected]>
Date:   Fri Mar 22 20:12:10 2024 +0800

    cmd, triedb: implement history inspection (#29267)

    This pull request introduces a database tool for inspecting the state history.
    It can be used for either account history or storage slot history, within a
    specific block range.

    The state output format can be chosen either with

    - the "rlp-encoded" values (those inserted into the merkle trie)
    - the "rlp-decoded" value (the raw state value)

    The latter one needs --raw flag.

commit f46fe62c5d1d25ce0e9869ecbaf0e5722d2bc2f5
Author: Darioush Jalali <[email protected]>
Date:   Fri Mar 22 04:38:24 2024 -0700

    triedb/hashdb: Avoid setting db.cleans on Close (#29309)

commit 14eb8967be7acc54c5dc9a416151ac45c01251b6
Author: Martin HS <[email protected]>
Date:   Thu Mar 21 13:50:13 2024 +0100

    all: use min/max/clear from go1.21 (#29307)

commit bca6c407098fefc757c263ae2da6aeff719e17ca
Author: Felix Lange <[email protected]>
Date:   Wed Mar 20 19:22:44 2024 +0100

    beacon/blsync: support for deneb fork (#29180)

    This adds support for the Deneb beacon chain fork, and fork handling
    in general, to the beacon chain light client implementation.

    Co-authored-by: Zsolt Felfoldi <[email protected]>

commit 04bf1c802ffe9dfc34c34b3e666ee15e96b4a203
Author: Martin HS <[email protected]>
Date:   Wed Mar 20 15:22:52 2024 +0100

    eth/protocols/snap, internal/testlog: fix dataraces (#29301)

commit 8f7fbdfedcbaca2a2bffb00badc75c03d58052ec
Author: Marius van der Wijden <[email protected]>
Date:   Wed Mar 20 14:58:47 2024 +0100

    core: refactor consensus interface (#29283)

    This PR modifies the consensus interface to wrap the body fields.

commit 0444388c746f99186e086f8ea733ea45e91918ac
Author: Aaron Chen <[email protected]>
Date:   Wed Mar 20 21:51:05 2024 +0800

    core/txpool/blobpool: calculate log1.125 faster (#29300)

commit 78c102dec5f1c7b5256c466df4421b4818bfe0e6
Author: rjl493456442 <[email protected]>
Date:   Wed Mar 20 20:11:30 2024 +0800

    core: skip the check the statefulness of head block in repair (#29245)

commit 22ac46cbdbd0601d2c59a74bb29fb0ceb34dddaa
Author: imalasong <[email protected]>
Date:   Wed Mar 20 20:09:46 2024 +0800

    Makefile: update PHONY directive (#29296)

commit 9a7e6ce6f593d1284512032d5757a85a15e6d636
Author: Martin HS <[email protected]>
Date:   Wed Mar 20 10:38:30 2024 +0100

    cmd/evm: fix flag-mismatch from #29290 (#29298)

commit de08f3d62552531f3fb2fc3a64a4bfdb962900eb
Author: Martin HS <[email protected]>
Date:   Wed Mar 20 09:12:58 2024 +0100

    cmd/evm: make staterunner always output stateroot to stderr (#29290)

    This changes makes it so that when `evm statetest` executes, regardless of whether `--json` is specified or not, the stateroot is printed on `stderr` as a `jsonl` line. This enables speedier execution of testcases in goevmlab, in cases where full execution op-by-op is not required.

commit 0ceac8d00e3067b6bb7ddc79670383295ddf7d6d
Author: georgehao <[email protected]>
Date:   Wed Mar 20 15:51:45 2024 +0800

    metrics: fix docstrings (#29279)

commit 45b88abbde92eab99bab6ac1e55aa88bccccfe80
Author: miles <[email protected]>
Date:   Wed Mar 20 15:49:38 2024 +0800

    all: fix typos (#29288)

commit 6f929a0762be92130588779a8535ed0e3fc58d87
Author: zgfzgf <[email protected]>
Date:   Wed Mar 20 15:46:50 2024 +0800

    core/asm: minor code-clarification (#29293)

commit 4c1b57856f0f5ebccb6edb83ab755ab114500078
Author: buddho <[email protected]>
Date:   Tue Mar 19 22:23:55 2024 +0800

    miner: modify header before checking time-based fields (#29242)

    The Prepare-method of consensus engine might modify the time-field in a header, so it should be called prior to checks that rely on it

commit eda9c7e36f120a3e4feb3dfa9472084e88e35054
Author: Tien Nguyen <[email protected]>
Date:   Tue Mar 19 20:05:31 2024 +0700

    accounts/abi/bind: check invalid chainID first (#29275)

commit 6b3d4d068ac720de1c2edab7d1e1a1311811d747
Author: bitcoin-lightning <[email protected]>
Date:   Tue Mar 19 21:05:06 2024 +0800

    beacon/light/sync: fix typo in comment (#29256)

commit ac6060a4c61b99743173c8c88ea1f8f68f6cdbfc
Author: Aaron Chen <[email protected]>
Date:   Tue Mar 19 18:25:30 2024 +0800

    log: replace tmp with bytes.Buffer.AvailableBuffer (#29287)

commit 15eb9773f9b99c29f3cd17be4e4bbd1bf1b48bb7
Author: rjl493456442 <[email protected]>
Date:   Tue Mar 19 10:50:08 2024 +0800

    triedb/pathdb: improve tests (#29278)

commit ab49f228ad6f37ba78be66b34aa5fee740245f57
Author: Martin HS <[email protected]>
Date:   Mon Mar 18 17:36:50 2024 +0100

    all: update to go version 1.22.1 (#28946)

    Since Go 1.22 has deprecated certain elliptic curve operations, this PR removes
    references to the affected functions and replaces them with a custom implementation
    in package crypto. This causes backwards-incompatible changes in some places.

    ---------

    Co-authored-by: Marius van der Wijden <[email protected]>
    Co-authored-by: Felix Lange <[email protected]>

commit c6119247271220ce89e76e1b1b2eaeaaa8fbd9d1
Author: Martin HS <[email protected]>
Date:   Mon Mar 18 08:13:55 2024 +0100

    go.mod: update protobuf (#29270)

commit ba2dd9385c2a51134e520083dc732787a813b107
Author: SanYe <[email protected]>
Date:   Fri Mar 15 17:46:22 2024 +0800

    accounts/abi/bind: remove unused err set and check (#29269)

    accounts/abi: remove unused err set and check

commit 40cac1d0e2cb37e769c3928cc477efb41124bb60
Author: Martin HS <[email protected]>
Date:   Fri Mar 15 10:44:41 2024 +0100

    eth/catalyst: prettier output on bad new payloads (#29259)

    When we receive a bad NewPayload, we currently emit a lot of data to the logging facilities. This PR makes it so we print less data.

commit 95715fdb0317dc7d6ebbec702fe78257380c95a1
Author: shivhg <[email protected]>
Date:   Fri Mar 15 14:37:47 2024 +0530

    eth/downloader, graphql: fix typos (#29243)

commit cffb7c8604d299ac21e0a9714205cc7b52faa501
Author: Haotian <[email protected]>
Date:   Fri Mar 15 16:14:31 2024 +0800

    params: use the same variable name as EIP-4788 (#29195)

    In https://eips.ethereum.org/EIPS/eip-4788 the name `BEACON_ROOTS_ADDRESS` is used. This change makes geth use the same variable name to avoid confusion.

commit d28adb61bf8445f9de58612155c308e5ac3b197a
Author: John Xu <[email protected]>
Date:   Thu Mar 14 21:38:11 2024 +0800

    cmd/emv/internal/t8ntool: fix shadowing of `excessBlobGas` (#29263)

    fix(t8n): unexpected `excessBlobGas` shadowed

commit 20d3e0ac06ef2ad2f5f6500402edc5b6f0bf5b7c
Author: Ng Wei Han <[email protected]>
Date:   Thu Mar 14 17:32:49 2024 +0800

    cmd/devp2p: fix decoding of raw RLP ENR attributes (#29257)

commit 3c26ffeb2968907f68d41faab757dacdcb280941
Author: Haotian <[email protected]>
Date:   Thu Mar 14 07:26:46 2024 +0800

    eth/catalyst: remove error return in delayPayloadImport (#29043)

    Co-authored-by: tmelhao <[email protected]>

commit 57308beecf7040391aee6c3102587063501f6825
Author: Bin <[email protected]>
Date:   Thu Mar 14 07:25:42 2024 +0800

    go.mod: update golang.org/x/crypto from v0.17.0 to v0.21.0 (#29228)

commit f3d18d64bf4c026740ee6c8ae8949a8c19391b49
Author: Martin HS <[email protected]>
Date:   Wed Mar 13 18:12:23 2024 +0100

    tests, appveyor: only execute one in four permutations on CI (#29220)

    tests, appveyor: only execute one in four permutations when flag -short is used

    Also enable -short flag on all appveyor builds (also ubuntu)

commit c170fa277cbf2a9faf9f35665f1ba8f34f94062a
Author: rjl493456442 <[email protected]>
Date:   Wed Mar 13 19:39:30 2024 +0800

    core: improve chain rewinding mechanism (#29196)

    * core: improve chain rewinding mechanism

    * core: address comment

    * core: periodically print progress log

    * core: address comments

    * core: fix comment

    * core: fix rewinding in path

    * core: fix beyondRoot condition

    * core: polish code

    * core: polish code

    * core: extend code comment

    * core: stop rewinding if chain is gapped or genesis is reached

    * core: fix broken tests

commit b80643b7370075262fd6dfad7ae8aa77710e2ef1
Author: Justin Dhillon <[email protected]>
Date:   Tue Mar 12 23:54:40 2024 -0700

    accounts/usbwallet, common/bitutil: fix broken links in docs (#29078)

    fixes some links in documentation

commit d5bacfa4def558a4c7b261c1a9fbfdbfc295e491
Author: Martin HS <[email protected]>
Date:   Wed Mar 13 07:51:46 2024 +0100

    crypto/kz4844: pass blobs by ref (#29050)

    This change makes use of the following underlying changes to the kzg-libraries in order to avoid passing large things on the stack:

    - c-kzg: https://github.com/ethereum/c-kzg-4844/pull/393 and
    - go-kzg: https://github.com/crate-crypto/go-kzg-4844/pull/63

commit eff424cc302152f3914e3f9c8b49efe92e33353f
Author: Sina M <[email protected]>
Date:   Wed Mar 13 07:40:02 2024 +0100

    eth/tracers: fix concurrency issue for JS-tracing a block (#29238)

    This change fixes a concurrency-issue where JS-tracers were accessing the block-ctx GetHash function in a in parallel, which is not safe.

commit 758fce71fab5289e3af711b1fa21a541c77cc435
Author: Felix Lange <[email protected]>
Date:   Tue Mar 12 19:23:24 2024 +0100

    p2p: fix race in dialScheduler (#29235)

    Co-authored-by: Stefan <[email protected]>

commit 6c76b813df6d53b86fac17471e9a31afd20c481e
Author: Marius van der Wijden <[email protected]>
Date:   Tue Mar 12 14:29:35 2024 +0100

    miner: add additional log (#29193)

    Adds a debug level log if the payload building failed for whatever reason

commit 4bd55a064ccc804127de09397273d16966fe8a37
Author: Aaron Chen <[email protected]>
Date:   Tue Mar 12 20:05:31 2024 +0800

    common/math: copy result in Exp (#29233)

    common/math: does not change base parameter

commit 99bbbc0277e34fc3a31512a345ba20874ae98e18
Author: Shiming Zhang <[email protected]>
Date:   Tue Mar 12 19:12:37 2024 +0800

    internal/build, rpc: add missing HTTP response body Close() calls (#29223)

    Co-authored-by: Felix Lange <[email protected]>

commit 89cefe240fd22b01e413786e18ad35263c93a61f
Author: Bin <[email protected]>
Date:   Tue Mar 12 17:00:34 2024 +0800

    cmd: use package filepath over path for file system operations (#29227)

    Package filepath implements utility routines for manipulating filename paths in a way compatible with the target operating system-defined file paths.

    Package path implements utility routines for manipulating slash-separated paths.

    The path package should only be used for paths separated by forward slashes, such as the paths in URLs

commit 4e1116f9c513961b62dff146a7cce069fe7a36b0
Author: San Ye <[email protected]>
Date:   Tue Mar 12 16:49:53 2024 +0800

     crypto/bn256/cloudflare: fix noescape-directive (#29222)

commit ebf9e11af2ff701d0961623e817d37b421b96802
Author: guangwu <[email protected]>
Date:   Mon Mar 11 18:17:16 2024 +0800

    beacon/light/request: fix typos (#29216)

commit fa4ade8ecb4e37687b464fdab6986c01cc1e50c2
Author: Sina Mahmoodi <[email protected]>
Date:   Mon Mar 11 11:05:48 2024 +0100

    core: fix deprecation comment for GenesisAccount (#29218)

    core: fix deprecation comment

commit 00c21128ef62be54bef798f3220f79ae2297be66
Author: Lee Bousfield <[email protected]>
Date:   Mon Mar 11 05:05:17 2024 -0500

    core/txpool/blobpool: return ErrAlreadyKnown for duplicate txs (#29210)

    Signed-off-by: Lee Bousfield <[email protected]>

commit b393ad8d29fe002fe6c0329a09d7715b00030c79
Author: Péter Szilágyi <[email protected]>
Date:   Mon Mar 11 10:06:57 2024 +0200

    cmd, core, metrics: always report expensive metrics (#29191)

    * cmd, core, metrics: always report expensive metrics

    * core, metrics: report block processing metrics as resetting timer

    * metrics: update reporter tests

commit 3dc549b3d75af790e78ef2d7f63a947efb9b0e95
Author: Kero <[email protected]>
Date:   Mon Mar 11 03:01:26 2024 +0800

    p2p/simulations/adapters: fix error messages in TestTCPPipeBidirections (#29207)

commit e31709db6570e302557a9bccd681034ea0dcc246
Author: Haotian <[email protected]>
Date:   Fri Mar 8 19:15:52 2024 +0800

    console: fix the wrong error msg of datadir testcase (#29183)

commit d35c8f0c25d3b5781e016252625b582c9553601a
Author: colin <[email protected]>
Date:   Fri Mar 8 19:13:46 2024 +0800

    ethclient/gethclient: add blob transaction fields in toCallArg (#29198)

commit c41105ce80f12f60ec4bf6c65c4c59c6bf4a86e7
Author: Sebastian Stammler <[email protected]>
Date:   Fri Mar 8 00:01:31 2024 +0100

    log: add Handler getter to Logger interface (#28793)

    log: Add Handler getter to Logger interface

commit cd490608e344e388edd7ef3dd323968d706ccf8c
Author: hyhnet <[email protected]>
Date:   Fri Mar 8 05:56:19 2024 +0800

    all: fix typos in comments (#29186)

commit 3bebabbd036d4f550e32bb20a92bf7da6e6a2797
Author: cuinix <[email protected]>
Date:   Fri Mar 8 05:25:08 2024 +0800

    accounts: remove redundant string conversion (#29184)

commit aadcb886753079d419f966a3bc990f708f8d1c3b
Author: Felföldi Zsolt <[email protected]>
Date:   Wed Mar 6 17:50:22 2024 +0100

    cmd/blsync, beacon/light: beacon chain light client (#28822)

    Here we add a beacon chain light client for use by geth.

    Geth can now be configured to run against a beacon chain API endpoint,
    without pointing a CL to it. To set this up, use the `--beacon.api` flag. Information
    provided by the beacon chain is verified, i.e. geth does not blindly trust the beacon
    API endpoint in this mode. The root of trust are the beacon chain 'sync committees'.

    The configured beacon API endpoint must provide light client data. At this time, only
    Lodestar and Nimbus provide the necessary APIs.

    There is also a standalone tool, cmd/blsync, which uses the beacon chain light client
    to drive any EL implementation via its engine API.

    ---------

    Co-authored-by: Felix Lange <[email protected]>

commit d8e0807da22eb922539d15b0d5d01ccdd58b1267
Author: Marius van der Wijden <[email protected]>
Date:   Wed Mar 6 13:45:03 2024 +0100

    miner: refactor the miner, make the pending block on demand (#28623)

    * miner: untangle miner

    * miner: use common.hash instead of *types.header

    * cmd/geth: deprecate --mine

    * eth: get rid of most miner api

    * console: get rid of coinbase in welcome message

    * miner/stress: get rid of the miner stress test

    * eth: get rid of miner.setEtherbase

    * ethstats: remove miner and hashrate flags

    * ethstats: remove miner and hashrate flags

    * cmd: rename pendingBlockProducer to miner.pending.feeRecipient flag

    * miner: use pendingFeeRecipient instead of etherbase

    * miner: add mutex to protect the pending block

    * miner: add mutex to protect the pending block

    * eth: get rid of etherbase mentions

    * miner: no need to lock the coinbase

    * eth, miner: fix linter

    ---------

    Co-authored-by: Martin Holst Swende <[email protected]>
    Co-authored-by: Péter Szilágyi <[email protected]>

commit 6e379b6fc776668c9a7db6d5b014d0dd89d7118d
Author: Delweng <[email protected]>
Date:   Wed Mar 6 20:36:12 2024 +0800

    eth/tracers: prestate tracer add blob fee (#29168)

    * eth/tracers: prestate balance add blob fee

    Signed-off-by: jsvisa <[email protected]>

    * eth/tracers: prestate test support blob tx

    Signed-off-by: jsvisa <[email protected]>

    * eth/tracers: add prestate blob tx test

    Signed-off-by: jsvisa <[email protected]>

    ---------

    Signed-off-by: jsvisa <[email protected]>

commit a90fe84971183aa0b6c40d71c6586ae3f2eda4c8
Author: Undefinedor <[email protected]>
Date:   Wed Mar 6 18:55:44 2024 +0800

    accounts: remove deprecated function NewPlaintextKeyStore (#29171)

commit e73f55365c458c5185a493935b65dd96bacf6933
Author: Martin HS <[email protected]>
Date:   Wed Mar 6 11:31:50 2024 +0100

    accounts/usbwallet: update hid library (#29176)

commit a000acb61114c2a3a74c065f2e61b4d6bca3ae46
Author: Andrei Kostakov <[email protected]>
Date:   Wed Mar 6 11:53:12 2024 +0200

    rpc: add more test cases for arg types (#29006)

commit 899bb88a4ba19af2d8fe4874561a9d55355acf48
Author: Martin HS <[email protected]>
Date:   Wed Mar 6 10:32:17 2024 +0100

    accounts/usbwallet: revert #28945 (#29175)

commit 588c5480fd1f355a39d3f52a5507ab9d0da334c9
Author: Tom <[email protected]>
Date:   Wed Mar 6 13:23:35 2024 +0800

    internal/ethapi: delete needless error check (#29127)

commit 66e1a6ef496e001abc7ae7433282251a557deb2c
Author: Devon Bear <[email protected]>
Date:   Tue Mar 5 09:15:02 2024 -0500

    go.mod: bump pebble db to official release (#29038)

    bump pebble

commit f4d53133f6e4b13f0dbcfef3bc45e9650d863b73
Author: Péter Szilágyi <[email protected]>
Date:   Tue Mar 5 16:13:28 2024 +0200

    consensus, cmd, core, eth: remove support for non-merge mode of operation (#29169)

    * eth: drop support for forward sync triggers and head block packets

    * consensus, eth: enforce always merged network

    * eth: fix tx looper startup and shutdown

    * cmd, core: fix some tests

    * core: remove notion of future blocks

    * core, eth: drop unused methods and types

commit 9a0fa8093ca5f7b896c3f7e849f7ca532d24e2a6
Author: Marius van der Wijden <[email protected]>
Date:   Tue Mar 5 14:52:44 2024 +0100

    node: remove test which doesn't do a lot (#29159)

    * node: fix test if directory already exists

    * node: remove test

commit 9e129efd7b43242fb5e605065713c27d615e753d
Author: zhiqiangxu <[email protected]>
Date:   Tue Mar 5 21:48:27 2024 +0800

    core: remove useless assignments (#29065)

commit a970295956d602c348dccce034712c14aedce5e0
Author: cui <[email protected]>
Date:   Tue Mar 5 21:45:17 2024 +0800

    rlp: using unsafe.Slice instead of SliceHeader (#29067)

    Co-authored-by: Felix Lange <[email protected]>

commit a6d6e8ac410170eb1085b9e7b0388b1c67f95548
Author: Undefinedor <[email protected]>
Date:   Tue Mar 5 21:44:23 2024 +0800

    rpc: remove deprecated method "Notifier.Closed" (#29162)

commit dfa6c5e9c80e0965d0476909afc26e87aa199e6a
Author: Delweng <[email protected]>
Date:   Tue Mar 5 21:37:26 2024 +0800

    internal/jsre: format blob fields from hexdecimal to int  (#29166)

    * internal/jsre: format receipt.{blobGasPrice,blobGasUsed} to int

    Signed-off-by: jsvisa <[email protected]>

    * internal/jsre: format tx.maxFeePerBlobGas to int

    Signed-off-by: jsvisa <[email protected]>

    * internal/jsre: format blob* in block

    Signed-off-by: jsvisa <[email protected]>

    ---------

    Signed-off-by: jsvisa <[email protected]>

commit 96bf23f1ea95d29a32abe8fe2992b86e892b6c4c
Author: Martin HS <[email protected]>
Date:   Tue Mar 5 14:32:47 2024 +0100

    accounts/usbwallet: use updated hid (only) library (#28945)

    * accounts/usbwallet: use updated hid (only) library

    * deps: update karalabe/hid

commit 7b81cf6362b3bb52762b823edf2a31bbbed4aa84
Author: rjl493456442 <[email protected]>
Date:   Tue Mar 5 21:31:55 2024 +0800

    core/state, trie/triedb/pathdb: remove storage incomplete flag (#28940)

    As SELF-DESTRUCT opcode is disabled in the cancun fork(unless the
    account is created within the same transaction, nothing to delete
    in this case). The account will only be deleted in the following
    cases:

    - The account is created within the same transaction. In this case
    the original storage was empty.

    - The account is empty(zero nonce, zero balance, zero code) and
    is touched within the transaction. Fortunately this kind of accounts
    are not-existent on ethereum-mainnet.

    All in all, after cancun, we are pretty sure there is no large contract
    deletion and we don't need this mechanism for oom protection.

commit e199319fd680aa4b135147f0480549a1c7d95350
Author: buddho <[email protected]>
Date:   Tue Mar 5 17:47:56 2024 +0800

    rlp: remove a moot todo (#29154)

commit d89d7ebdec27d8c8fed217767e2f17b09b5460a0
Author: zhiqiangxu <[email protected]>
Date:   Tue Mar 5 16:47:58 2024 +0800

    core: initialize `gasRemaining` with `=` instead of `+=` (#29149)

    initialize gasRemaining with = instead of +=

commit 9b3ceb2137df125dd0f6957a362e9f08d6c41b66
Author: Vie <[email protected]>
Date:   Tue Mar 5 15:33:52 2024 +0800

    core/types: reuse signtx (#29152)

    * core/types: reuse signtx

    * core/types: inline signtx

commit 5d5b384efd0acabe4d808c46fce9700114d2046f
Author: Domino Valdano <[email protected]>
Date:   Mon Mar 4 12:58:25 2024 -0800

    .mailmap: remove invalid email address (#29163)

commit 19607d1a10d37542ba13ab9db48cf4e501715cce
Author: Andrei Silviu Dragnea <[email protected]>
Date:   Mon Mar 4 20:21:43 2024 +0100

    eth/tracers: Fix prestateTracer pre nonce on contract creation (#29099)

    The prestateTracer was reporting an inaccurate nonce for the contract being created in
    post EIP-158 transactions. Correct nonce is 0, due to the issue nonce was being reported as 1.

commit ca473b81cbe4a96cde4e8424c49b15ab304787bb
Author: rjl493456442 <[email protected]>
Date:   Mon Mar 4 22:25:53 2024 +0800

    core: use finalized block as the chain freeze indicator (#28683)

    * core: use finalized block as the chain freeze indicator

    * core/rawdb: use max(finality, head-90k) as chain freezing threshold

    * core/rawdb: fix tests

    * core/rawdb: fix lint

    * core/rawdb: address comments from peter

    * core/rawdb: fix typo

commit a97d622588c2b71557c6222b95d487f51b46bd78
Author: Felix Lange <[email protected]>
Date:   Mon Mar 4 14:07:41 2024 +0100

    cmd/devp2p: fix commandHasFlag (#29091)

    It got broken in some update of the cli library, and thus bootnodes weren't
    being configured automatically for some of the discovery commands.

commit 35cebc16877c4cfbf48b883ab3bfa02b9100a87a
Author: psogv0308 <[email protected]>
Date:   Mon Mar 4 19:03:53 2024 +0900

    triedb/pathdb: changed the test code to check for verifying state (#29150)

    Co-authored-by: this-is-iron <[email protected]>

commit 679a27a2b36d4f86e6b49c49c0d51c47a7ef6145
Author: buddho <[email protected]>
Date:   Mon Mar 4 17:31:18 2024 +0800

    all: use EmptyUncleHash, EmptyCodeHash instead of raw value (#29134)

commit 5a1e8a6547d6606c7ff1e3f3841fbb1c9f205282
Author: cui <[email protected]>
Date:   Mon Mar 4 17:30:15 2024 +0800

    core: delete unused ErrMaxInitCodeSizeExceeded (#29062)

commit b408b3e5fece3524bf7721ac8dd8d9a898f571a8
Author: yzb <[email protected]>
Date:   Mon Mar 4 17:24:24 2024 +0800

    accounts/abi: delete duplicate error check (#29136)

commit a732ad036488e3d5db33928f0155ffd66e08c08d
Author: yzb <[email protected]>
Date:   Mon Mar 4 17:16:05 2024 +0800

    p2p: remove unused argument 'flags' (#29132)

commit 00905f7dc406cfb67f64cd74113777044fb886d8
Author: Undefinedor <[email protected]>
Date:   Sun Mar 3 04:42:50 2024 +0800

    all: remove redundant import aliases (#29144)

commit 0b1438c3df5da5551e89dddc683d65f4d48ad3d6
Author: Péter Szilágyi <[email protected]>
Date:   Sat Mar 2 22:39:22 2024 +0200

    eth: make transaction propagation paths in the network deterministic (#29034)

    * eth: make transaction propagation paths in the network deterministic

    * eth: avoid potential division by 0

    * eth: make tx propagation dependent on local node id too

    * eth: fix review comments

commit 0a2f33946b95989e8ce36e72a88138adceab6a23
Author: Sina Mahmoodi <[email protected]>
Date:   Thu Feb 29 13:17:32 2024 +0100

    eth/catalyst: update simulated beacon for cancun (#28829)

    * eth/catalyst: update simulated beacon for cancun

    * validate blob hashes

    * compute hashes from commitment

    * fix beacon root and payload version

    * check commitment conversion

    * fix random attr

    * flip dev to cancun

commit 865e1e9f577f4fa804d0246f82cbcedc27db9bf6
Author: Péter Szilágyi <[email protected]>
Date:   Thu Feb 29 12:40:59 2024 +0200

    cmd/utils, core/rawdb, triedb/pathdb: flip hash to path scheme (#29108)

    * cmd/utils, core/rawdb, triedb/pathdb: flip hash to path scheme

    * graphql: run tests in hash mode as the chain maker needs it

commit db4cf6916606e07d908af44e405257925dd9265e
Author: yzb <[email protected]>
Date:   Thu Feb 29 17:56:46 2024 +0800

    all: replace fmt.Errorf() with errors.New() if no param required (#29126)

    replace-fmt-errorf

    Co-authored-by: [email protected] <[email protected]>

commit 28d55218f7d793c184f4220a16a60e309caa70af
Author: Ng Wei Han <[email protected]>
Date:   Thu Feb 29 17:56:17 2024 +0800

    cmd/geth: parseDumpConfig should not return closed db (#29100)

    * cmd: parseDumpConfig should not return closed db

    * fix lint

commit dbc27a199f411fc620eeb8589fd75a144f83ee8c
Author: cui fliter <[email protected]>
Date:   Thu Feb 29 17:29:06 2024 +0800

    all: fix function names in docs (#29128)

    Signed-off-by: cui fliter <[email protected]>

commit 1883438964a7a4c68cee1de619526e8bc1e68b30
Author: lightclient <[email protected]>
Date:   Wed Feb 28 11:59:16 2024 -0700

    eth/catalyst: return invalid payload attributes instead of invalid parms for bad fcu payload (#29115)

commit 9986a69c25452ff0e7ce323446b215e2d0075185
Author: buddho <[email protected]>
Date:   Thu Feb 29 01:38:21 2024 +0800

    internal/ethapi: pass in accesslist in test (#29089)

    Co-authored-by: Sina Mahmoodi <[email protected]>

commit 5bae14f9df498243091078fc8d3ea6ab99669087
Author: rjl493456442 <[email protected]>
Date:   Wed Feb 28 20:40:28 2024 +0800

    triedb/pathdb: fix panic in recoverable (#29107)

    * triedb/pathdb: fix panic in recoverable

    * triedb/pathdb: add todo

    * triedb/pathdb: rename

    * triedb/pathdb: rename

commit 49623bd4697f5b333ae977968186d0717f918927
Author: rjl493456442 <[email protected]>
Date:   Wed Feb 28 20:23:52 2024 +0800

    core, triedb/pathdb: calculate the size for batch pre-allocation (#29106)

    * core, triedb/pathdb: calculate the size for batch pre-allocation

    * triedb/pathdb: address comment

commit 170fcd80c6f5d07d7d839e895765de193c34a8b3
Author: Péter Szilágyi <[email protected]>
Date:   Wed Feb 28 10:01:52 2024 +0200

    params: being major version bump cycle

commit 02d77c98f9e1efaf3fede313b0e9183dc54562b6
Author: cui <[email protected]>
Date:   Wed Feb 28 15:25:12 2024 +0800

    core: using math.MaxUint64 instead of 0xffffffffffffffff (#29094)

commit 57d2b552c74dbd03b9909e6b8cd7b3de1f8b40e9
Author: Péter Szilágyi <[email protected]>
Date:   Tue Feb 27 13:53:30 2024 +0200

    params: begin v1.13.15 cycle

commit 9038ba69428a6ecada1f2acace6981854482748b
Author: Péter Szilágyi <[email protected]>
Date:   Tue Feb 27 13:50:30 2024 +0200

    params: release Geth v1.13.14

commit 51b479e56459d663a12f95fd8eaba82716c0d5ce
Author: Roberto Bayardo <[email protected]>
Date:   Tue Feb 27 03:27:50 2024 -0800

    core/txpool: elevate the 'already reserved' error into a constant (#29095)

    declare the 'already reserved' error in errors.go

commit 5a0f468f8cb15b939bd85445d33c614a36942a8e
Author: Andrei Silviu Dragnea <[email protected]>
Date:   Tue Feb 27 10:29:12 2024 +0100

    eth/tracers: Fix callTracer logs on onlyTopCall == true (#29068)

commit 45a272c7b96cb260528bbc2e31d657488f97c4b0
Author: Delweng <[email protected]>
Date:   Tue Feb 27 00:34:45 2024 +0800

    core/txpool: no need to log loud rotate if no local txs (#29083)

    * core/txpool: no need to run rotate if no local txs

    Signed-off-by: jsvisa <[email protected]>

    * Revert "core/txpool: no need to run rotate if no local txs"

    This reverts commit 17fab173883168c586d57ca9c05dfcbd9e7831b4.

    Signed-off-by: jsvisa <[email protected]>

    * use Debug if todo is empty

    Signed-off-by: jsvisa <[email protected]>

    ---------

    Signed-off-by: jsvisa <[email protected]>

commit 63aaac81007ad46b208570c17cae78b7f60931d4
Author: Péter Szilágyi <[email protected]>
Date:   Mon Feb 26 14:27:56 2024 +0200

    core/txpool/blobpool: reduce default database cap for rollout (#29090)

    xcore/txpool/blobpool: reduce default database cap for rollout

commit c1f59b98f6b0351339767d71953eb4eb5d19c496
Author: cui <[email protected]>
Date:   Mon Feb 26 20:22:13 2024 +0800

    eth/catalyst: remove variable in tx conversion loop (#29076)

commit 821d70240d191ff451a813287a377466337a3cee
Author: Justin Dhillon <[email protected]>
Date:   Mon Feb 26 02:03:59 2024 -0800

    cmd/clef: add spaces in README.md table (#29077)

    Add space after links in so they are clickable in vscode.

commit 8bca93e82c59d04f23b0237292d17fe728f20a5b
Author: maskpp <[email protected]>
Date:   Mon Feb 26 18:02:18 2024 +0800

    internal/ethapi: pass blob hashes to gas estimation (#29085)

commit edffacca8f97d23298636e225d477818e58eafe7
Author: cui <[email protected]>
Date:   Mon Feb 26 17:59:03 2024 +0800

    eth/catalyst: enable some commented-out testcases   (#29073)

commit 26724fc2aaf0cf8711c25ca664c0451f68d977fe
Author: Qt <[email protected]>
Date:   Mon Feb 26 17:25:35 2024 +0800

    p2p, log, rpc: use errors.New to replace fmt.Errorf with no parameters (#29074)

commit 32d4d6e6160432be1cb9780a43253deda7708ced
Author: Roberto Bayardo <[email protected]>
Date:   Mon Feb 26 01:06:52 2024 -0800

    core/txpool: reject blob txs with blob fee cap below the minimum (#29081)

    * make blobpool reject blob transactions with fee below the minimum

    * core/txpool: some minot nitpick polishes and unified error formats

    * core/txpool: do less big.Int constructions with the min blob cap

    ---------

    Co-authored-by: Péter Szilágyi <[email protected]>

commit 93c541ad563124e81d125c7ebe78938175229b2e
Author: Haotian <[email protected]>
Date:   Fri Feb 23 16:57:47 2024 +0800

    eth/catalyst: fix wrong error message of payloadV2 after cancun (#29049)

    * eth/catalyst: the same error format

    Signed-off-by: tmelhao <[email protected]>

    * eth/catalyst: wrong error message for payloadV2 post-cancun

    Signed-off-by: tmelhao <[email protected]>

    * eth/catalyst: parentBeaconBlockRoot -> parentBlockBeaconRoot

    Signed-off-by: tmelhao <[email protected]>

    * apply commit review

    Signed-off-by: tmelhao <[email protected]>

    ---------

    Signed-off-by: tmelhao <[email protected]>
    Co-authored-by: tmelhao <[email protected]>

commit b87b9b45331f87fb1da379c5f17a81ebc3738c6e
Author: colin <[email protected]>
Date:   Thu Feb 22 23:35:23 2024 +0800

    internal/ethapi:fix zero rpc gas cap in eth_createAccessList (#28846)

    This PR enhances eth_createAccessList RPC call to support scenarios where the node is launched with an unlimited gas cap (--rpc.gascap 0). The eth_createAccessList RPC call returns failure if user doesn't explicitly set a gas limit.

commit e47a7c22c40b9037049cb63d74eb1216aabdee60
Author: ArtificialPB <[email protected]>
Date:   Thu Feb 22 14:39:22 2024 +0100

    internal/ethapi: use overriden baseFee for gasPrice (#29051)

    eth_call and debug_traceCall allow users to override various block fields, among them base fee. However the overriden base fee was not considered for computing the effective gas price of that message, and instead base fee of the base block was used. This has been fixed in this commit.

commit b590cae89232299d54aac8aada88c66d00c5b34c
Author: Felix Lange <[email protected]>
Date:   Wed Feb 21 15:49:50 2024 +0100

    params: begin v1.13.14 release cycle

commit 3b4ede74443a15db27fddbb803a6b0cc4180ca75
Author: Felix Lange <[email protected]>
Date:   Wed Feb 21 15:44:02 2024 +0100

    params: release go-ethereum v1.13.13 stable

commit b47cf8fe1de4f97ce38417d8136a58812734a7a9
Author: Sina Mahmoodi <[email protected]>
Date:   Wed Feb 21 12:46:32 2024 +0100

    internal/ethapi: fix defaults for blob fields (#29037)

    Co-authored-by: Martin HS <[email protected]>

commit b9ca38b7358dbf7e236c624043bbab789a8d0389
Author: colin <[email protected]>
Date:   Wed Feb 21 16:00:01 2024 +0800

    core/txpool: fix typo (#29036)

    * fix typos

    * address comments

commit 79e340fb1276cd5f0bbdc3825f90090488e3b978
Author: Haotian <[email protected]>
Date:   Wed Feb 21 15:59:21 2024 +0800

    params: add cancun upgrade banner (#29042)

    params: add cancun banner

    Signed-off-by: tmelhao <[email protected]>
    Co-authored-by: tmelhao <[email protected]>

commit bba3fa9af9709ce6615d994edac7043e064fda0d
Author: buddho <[email protected]>
Date:   Tue Feb 20 19:42:48 2024 +0800

    core,eth,internal: fix typo (#29024)

commit 7f5e96dc6c0d70f793a6a41c059c5dd660357964
Author: buddho <[email protected]>
Date:   Tue Feb 20 18:08:56 2024 +0800

    core/txpool: fix typo (#29031)

commit f4852b8ddc8bef962d34210a4f7774b95767e421
Author: Péter Szilágyi <[email protected]>
Date:   Tue Feb 20 11:37:23 2024 +0200

    core/txpool, eth, miner: retrieve plain and blob txs separately (#29026)

    * core/txpool, eth, miner: retrieve plain and blob txs separately

    * core/txpool: fix typo, no farming

    * miner: farm all the typos

    Co-authored-by: Martin HS <[email protected]>

    ---------

    Co-authored-by: Martin HS <[email protected]>

commit ac0ff044606a663eeb47ef60ed5506f8427530…
jorgemmsilva pushed a commit to iotaledger/go-ethereum that referenced this pull request Jun 17, 2024
@s1na @holiman @jorgemmsilva
internal/ethapi: fix defaults for blob fields (ethereum#29037)
573d7ba 
Co-authored-by: Martin HS <[email protected]>
ryanschneider pushed a commit to ryanschneider/go-ethereum that referenced this pull request Jan 30, 2025
@avalonche @MariusVanDerWijden
@magicxyyz @ucwong @marioevz @jsvisa @jwasinger @fjl @lightclient @estensen @gballet @holiman @cortze @karalabe @weiihann @rjl493456442 @sbs2001 @s1na @jakub-freebit @orenyomtov @BorkBorked @ddl-hust @manav2401 @sandakersmann @zsfelfoldi @guerrierindien @Ursulafe @nnsW3 @FletcherMan @bodhi-crypo @sebastianst @wangyifan @dependabot @cygaar @taeguk @darioush @rosenk @vuittont60 @drstevenbrule @0xmountaintop @hyunchel @niuxiaojie81 @alfiedotwtf @palango @Thabokani @colinlyguo @trocher @protolambda @keienWang @zoereco @ziogaschr @rex4539 @Halimao @lmittmann @krauspt @mask-pp @lindlof @bkellerman @cuiweixie @buddh0 @tmelhao @ArtificialPB @0x2d3c @justindhillon @andreisilviudragnea @dvush
Deneb (ethereum#145)
7577ac8 
* core, trie, rpc: speed up tests (ethereum#28461)

* rpc: make subscription test faster

reduces time for TestClientSubscriptionChannelClose
from 25 sec to < 1 sec.

* trie: cache trie nodes for faster sanity check

This reduces the time spent on TestIncompleteSyncHash
from ~25s to ~16s.

* core/forkid: speed up validation test

This takes the validation test from > 5s to sub 1 sec

* core/state: improve snapshot test run
brings the time for TestSnapshotRandom from 13s down to 6s

* accounts/keystore: improve keyfile test

This removes some unnecessary waits and reduces the
runtime of TestUpdatedKeyfileContents from 5 to 3 seconds

* trie: remove resolver
* trie: only check ~5% of all trie nodes

* ethdb/pebble: don't double-close iterator inside pebbleIterator (ethereum#28566)

Adds 'released' flag to pebbleIterator to avoid double closing cockroachdb/pebble.Iterator as it is an invalid operation.

Fixes ethereum#28565

* eth/filters: reuse error msg for invalid block range (ethereum#28479)

* core/types: make 'v' optional for DynamicFeeTx and BlobTx (ethereum#28564)

This fixes an issue where transactions would not be accepted when they have only
'yParity' and not 'v'.

* rpc: improve performance of subscription notification encoding (ethereum#28328)

It turns out that encoding json.RawMessage is slow because
package json basically parses the message again to ensure it is valid.
We can avoid the slowdown by encoding the entire RPC notification once,
which yields a 30% speedup.

* cmd/utils: validate pre-existing genesis in --dev mode (ethereum#28468)

geth --dev can be used with an existing data directory and genesis block. Since
dev mode only works with PoS, we need to verify that the merge has happened.

Co-authored-by: Felix Lange <[email protected]>

* cmd/geth: add support for --dev flag in dumpgenesis (ethereum#28463)


Co-authored-by: Felix Lange <[email protected]>
Co-authored-by: lightclient <[email protected]>

* les/vflux: run tests in parallel (ethereum#28524)

* cmd/{geth,utils}: add cmd to export preimages in snap enumeration order (ethereum#28256)

Adds a subcommand: `geth snapshot export-preimages`, to export preimages of every hash found during a snapshot enumeration: that is, it exports _only the active state_, and not _all_ preimages that have been used but are no longer part of the state. 

This tool is needed for the verkle transition, in order to distribute the preimages needed for the conversion. Since only the 'active' preimages are exported, the output is shrunk from ~70GB to ~4GB.

The order of the output is the order used by the snapshot enumeration, which avoids database thrashing. However, it also means that storage-slot preimages are not deduplicated.

* cmd/geth: fix build error (ethereum#28585)

* cmd/devp2p/internal/ethtest: undo debug-hack (ethereum#28588)

cmd/devp2p/internal/ethtest: remove a debug-hack flaw which prevented certain tests from running

* params: update discV5 bootnodes (ethereum#28562)

update discV5 bootnodes from https://github.com/eth-clients/eth2-networks/blob/master/shared/mainnet/bootstrap_nodes.txt

* cmd, les, tests: remove light client code (ethereum#28586)

* cmd, les, tests: remove light client code

This commit removes the light client (LES) code.
Since the merge the light client has been broken and
it is hard to maintain it alongside the normal client.
We decided it would be best to remove it for now and
maybe rework and reintroduce it in the future.

* cmd, eth: remove some more mentions of light mode

* cmd: re-add flags and mark as deprecated

* cmd: warn the user about deprecated flags

* eth: better error message

* eth, internal/ethapi: drop some weird indirection (ethereum#28597)

* trie: fix random test generator early terminate (ethereum#28590)

This change fixes a minor bug in the `randTest.Generate` function, which caused the `quick.Check` to be a no-op.

* eth/gasestimator, internal/ethapi: move gas estimator out of rpc (ethereum#28600)

* go.mod: update uint256 to v1.2.4 (ethereum#28612)

* eth/catalyst, eth/downloader: expose more sync information (ethereum#28584)

This change exposes more information from sync module internally

* light: remove package light(ethereum#28614)

This changes removes the package 'light', which is currently unused.

* cmd/evm, core/state: fix post-exec dump of state (statetests, blockchaintests) (ethereum#28504)

There were several problems related to dumping state. 

- If a preimage was missing, even if we had set the `OnlyWithAddresses` to `false`, to export them anyway, the way the mapping was constructed (using `common.Address` as key) made the entries get lost anyway. Concerns both state- and blockchain tests. 
- Blockchain test execution was not configured to store preimages.

This changes makes it so that the block test executor takes a callback, just like the state test executor already does. This callback can be used to examine the post-execution state, e.g. to aid debugging of test failures.

* ethereum: remove TODO comment about subscription (ethereum#28609)

* eth/tracers/js: fix type inconsistencies (ethereum#28488)

This change fixes two type-inconsistencies in the JS tracer:

- In most places we return byte arrays as a `Uint8Array` to the tracer. However it seems we missed doing the conversion for `ctx` fields which are passed to the tracer during `result`. They are passed as simple arrays. I think Uint8Arrays are more suitable and we should change this inconsistency. Note: this will be a breaking-change. But I believe the effect is small. If we look at our tracers we see that these fields (`ctx.from`, `ctx.to`, etc.) are used in 2 ways. Passed to `toHex` which takes both array or buffer. Or the length was measured which is the same for both types.
- The `slice` taking in `int, int` params versus `memory.slice` taking `int64, int64` params. I suggest changing `slice` types to `int64`. This should have no effect almost in any case.

* crypto/secp256k1: fix 32-bit tests when CGO_ENABLED=0 (ethereum#28602)

* consensus: verify the nonexistence of shanghai- and cancun-specific header fields (ethereum#28605)

* eth/gasestimator: allow slight estimation error in favor of less iterations (ethereum#28618)

* eth/gasestimator: early exit for plain transfer and error allowance

* core, eth/gasestimator: hard guess at a possible required gas

* internal/ethapi: update estimation tests with the error ratio

* eth/gasestimator: I hate you linter

* graphql: fix gas estimation test

---------

Co-authored-by: Oren <[email protected]>

* all: replace log15 with slog (ethereum#28187)

This PR replaces Geth's logger package (a fork of [log15](https://github.com/inconshreveable/log15)) with an implementation using slog, a logging library included as part of the Go standard library as of Go1.21.

Main changes are as follows:
* removes any log handlers that were unused in the Geth codebase.
* Json, logfmt, and terminal formatters are now slog handlers.
* Verbosity level constants are changed to match slog constant values.  Internal translation is done to make this opaque to the user and backwards compatible with existing `--verbosity` and `--vmodule` options.
* `--log.backtraceat` and `--log.debug` are removed.

The external-facing API is largely the same as the existing Geth logger.  Logger method signatures remain unchanged.

A small semantic difference is that a `Handler` can only be set once per `Logger` and not changed dynamically.  This just means that a new logger must be instantiated every time the handler of the root logger is changed.

----
For users of the `go-ethereum/log` module. If you were using this module for your own project, you will need to change the initialization. If you previously did 
```golang
log.Root().SetHandler(log.LvlFilterHandler(log.LvlInfo, log.StreamHandler(os.Stderr, log.TerminalFormat(true))))
```
You now instead need to do 
```golang
log.SetDefault(log.NewLogger(log.NewTerminalHandlerWithLevel(os.Stderr, log.LevelInfo, true)))
```
See more about reasoning here: ethereum#28558 (comment)

* core/state: make stateobject.create selfcontain (ethereum#28459)

* trie/triedb/hashdb: take lock around access to dirties cache (ethereum#28542)

Add read locking of db lock around access to dirties cache in hashdb.Database to prevent
data race versus hashdb.Database.dereference which can modify the dirities map by deleting
an item.

Fixes ethereum#28541

---------

Co-authored-by: Gary Rong <[email protected]>

* accounts/abi/bind: fix typo (ethereum#28630)

* slog: faster and less memory-consumption (ethereum#28621)

These changes improves the performance of the non-coloured terminal formatting, _quite a lot_. 

```
name               old time/op    new time/op    delta
TerminalHandler-8    10.2µs ±15%     5.4µs ± 9%  -47.02%  (p=0.008 n=5+5)

name               old alloc/op   new alloc/op   delta
TerminalHandler-8    2.17kB ± 0%    0.40kB ± 0%  -81.46%  (p=0.008 n=5+5)

name               old allocs/op  new allocs/op  delta
TerminalHandler-8      33.0 ± 0%       5.0 ± 0%  -84.85%  (p=0.008 n=5+5)
```

I tried to _somewhat_ organize the commits, but the it might still be a bit chaotic. Some core insights: 

- The function `terminalHandler.Handl` uses a mutex, and writes all output immediately to 'upstream'. Thus, it can reuse a scratch-buffer every time. 
- This buffer can be propagated internally, making all the internal formatters either write directly to it,
- OR, make  use of the `tmp := buf.AvailableBuffer()` in some cases, where a byte buffer "extra capacity" can be temporarily used. 
- The `slog` package  uses `Attr` by value. It makes sense to minimize operating on them, since iterating / collecting into a new slice, iterating again etc causes copy-on-heap. Better to operate on them only once. 
- If we want to do padding, it's better to copy from a constant `space`-buffer than to invoke `bytes.Repeat` every single time.

* eth/tracers: tx-level state in debug_traceCall (ethereum#28460)

* cmd/evm: fix Env struct json tag (ethereum#28635)

* accounts/abi/bind: fixed typos (ethereum#28634)

* Update auth.go

* Update backend.go

* Update bind.go

* Update bind_test.go

* eth/fetcher: fix invalid tracking of received at time for block (ethereum#28637)

eth/fetcher: fix invalid tracking of received at time

* accounts: run tests in parallel (ethereum#28544)

* eth/tracers/logger: make structlog/json-log stack hex again (ethereum#28628)

* common/hexutil: define hex wrappers for uint256.Int

* eth/tracers/logger: make structlog/json-log stack hex again

* common/hexutil: goimports

* log: remove lazy, remove unused interfaces, unexport methods (ethereum#28622)

This change 

- Removes interface `log.Format`, 
- Removes method `log.FormatFunc`, 
- unexports `TerminalHandler.TerminalFormat` formatting methods (renamed to `TerminalHandler.format`)
- removes the notion of `log.Lazy` values


The lazy handler was useful in the old log package, since it
could defer the evaluation of costly attributes until later in the
log pipeline: thus, if the logging was done at 'Trace', we could
skip evaluation if logging only was set to 'Info'.

With the move to slog, this way of deferring evaluation is no longer
needed, since slog introduced 'Enabled': the caller can thus do
the evaluate-or-not decision at the callsite, which is much more
straight-forward than dealing with lazy reflect-based evaluation.

Also, lazy evaluation would not work with 'native' slog, as in, these
two statements would be evaluated differently:

```golang
  log.Info("foo", "my lazy", lazyObj)
  slog.Info("foo", "my lazy", lazyObj)
```

* .github: use github actions to run 32-bit linux tests (ethereum#28549)

use github actions to run 32-bit linux tests

* fix blob fee cap too low error

* update go mod

* ethdb/pebble: remove a dependency (ethereum#28627)

The dependency was not really used anyway, so we can get rid of it.

Co-authored-by: Felix Lange <[email protected]>

* tests/fuzzers/bls12381: deactivate BLS fuzzer when CGO_ENABLED=0 (ethereum#28653)

tests/fuzzers/bls12381: deactivate fuzzer when CGO_ENABLED=0

* build: upgrade -dlgo version to Go 1.21.5 (ethereum#28648)

* rpc: fix ns/µs mismatch in metrics (ethereum#28649)

The rpc/duration/all meter was in nanoseconds, the individual meter in microseconds.
This PR changes it so both of them use nanoseconds.

* cmd/evm: fix dump after state-test exec (ethereum#28650)

The dump after state-test didn't work, the problem was an error, "Already committed", which was silently ignored. 

This change re-initialises the state, so the dumping works again.

* beacon/light: add CommitteeChain (ethereum#27766)

This change implements CommitteeChain which is a key component of the beacon light client. It is a passive data structure that can validate, hold and update a chain of beacon light sync committees and updates, starting from a checkpoint that proves the starting committee through a beacon block hash, header and corresponding state. Once synced to the current sync period, CommitteeChain can also validate signed beacon headers.

* cmd/utils, eth: disallow invalid snap sync / snapshot flag combos (ethereum#28657)

* eth: prevent startup in snap mode without snapshots

* cmd/utils: try to fix bad flag combos wrt snap sync and snapshot generation

* trie: remove inconsistent trie nodes during sync in path mode (ethereum#28595)

This fixes a database corruption issue that could occur during state healing.
When sync is aborted while certain modifications were already committed, and a
reorg occurs, the database would contain incorrect trie nodes stored by path.
These nodes need to detected/deleted in order to obtain a complete and fully correct state
after state healing.

---------

Co-authored-by: Felix Lange <[email protected]>

* cmd/utils: fix HTTPHost, WSHost flag priority (ethereum#28669)


Co-authored-by: Felix Lange <[email protected]>

* eth/protocols/eth: fix typos in comments (ethereum#28652)

* core/txpool : small cleanup refactors (ethereum#28654)

* eth/fetcher, eth/gasestimator: fix typos in comments (ethereum#28675)

* all: fix typos in comments (ethereum#28662)


Co-authored-by: Felix Lange <[email protected]>

* miner: eliminate the dead loop possibility for `newWorkLoop` and `mainLoop` (ethereum#28677)

discard the intervalAdjust message if the channel is full

* all: fix typos in comments (ethereum#28682)

chore(core,eth):fix a couple of typos

* p2p/discover: add liveness check in collectTableNodes (ethereum#28686)

* p2p/discover: add liveness check in collectTableNodes

* p2p/discover: fix test

* p2p/discover: rename to appendLiveNodes

* p2p/discover: add dedup logic back

* p2p/discover: simplify

* p2p/discover: fix issue found by test

* internal/flags: add missing flag types for auto-env-var generation (ethereum#28692)

Certain flags, such as `--rpc.txfeecap` currently do not have an env-var auto-generated for them. This change adds three missing cli flag types to the auto env-var helper function to fix this.

* cmd/evm:  default to mirror mainnet forks enabled (ethereum#28691)

cmd/evm:  default to using dev chain config (all mainnet HFs activated at block/timestamp 0

* cmd/evm, cmd/clef, cmd/bootnode: fix / unify logging (ethereum#28696)

This change fixes a problem with our non-core binaries: evm, clef, bootnode.

First of all, they failed to convert from legacy loglevels 1 to 5, to the new slog loglevels -4 to 4.

Secondly, the logging was actually setup in the init phase, and then overridden in the main. This is not needed for evm, since it used the same flag name as the main geth verbosity. Better to let the flags/internal handle the logging init.

* cmd/evm: t8n support custom tracers (ethereum#28557)

This change implements ability for the `evm t8n` tool to use custom tracers; either 'native' golang tracers or javascript tracers.

* params: release go-ethereum v1.13.6 stable

* params: begin v1.13.7 release cycle

* internal/ethapi: ethSendTransaction check baseFee (ethereum#27834)

If the EIP-1559 is activated, reject 0-priced transactions in the rpc level

* core/rawdb: implement size reporting for live items in freezer_table (ethereum#28525)

This is the fix to issue ethereum#27483. A new hiddenBytes() is introduced to calculate the byte size of hidden items in the freezer table. When reporting the size of the freezer table, size of the hidden items will be subtracted from the total size.

---------

Co-authored-by: Yifan <Yifan Wang>
Co-authored-by: Gary Rong <[email protected]>

* build: make linter emit output (ethereum#28704)

* .travis: set lower GOGC value (ethereum#28705)

As documented on https://golangci-lint.run/usage/performance/ , a lower
GOGC value causes less peak mem consumption when running the linter.

Exceeding 3Gb is a common cause for build failures, according to
https://docs.travis-ci.com/user/common-build-problems/#my-build-script-is-killed-without-any-error

* ci: disable lint on travis (ethereum#28706)

* build(deps): bump golang.org/x/crypto from 0.15.0 to 0.17.0 (ethereum#28702)

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.15.0 to 0.17.0.
- [Commits](golang/crypto@v0.15.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* params: go-ethereum v1.13.7 stable

* params: begin go-ethereum v1.13.8 release cycle

* internal/build: fix crash in MustRunCommandWithOutput (ethereum#28709)

* accounts: properly close managed wallets when closing manager (ethereum#28710)

* build: upgrade to golangci-lint v1.55.2 (ethereum#28712)

This is primarily to make lint work again on macOS 14. The older version of golangci-lint kept crashing. 

Also included is a fix for a goroutine leak in the recently-introduced function MustRunCommandWithOutput.

* cmd/devp2p: update eth/snap protocol test suites for PoS (ethereum#28340)

Here we update the eth and snap protocol test suites with a new test chain,
created by the hivechain tool. The new test chain uses proof-of-stake. As such,
tests using PoW block propagation in the eth protocol are removed. The test suite
now connects to the node under test using the engine API in order to make it
accept transactions. 

The snap protocol test suite has been rewritten to output test descriptions and
log requests more verbosely.

---------

Co-authored-by: Felix Lange <[email protected]>

* core, cmd, trie: fix the condition of pathdb initialization (ethereum#28718)

Original problem was caused by ethereum#28595, where we made it so that as soon as we start to sync, the root of the disk layer is deleted. That is not wrong per se, but another part of the code uses the "presence of the root" as an init-check for the pathdb. And, since the init-check now failed, the code tried to re-initialize it which failed since a sync was already ongoing.

The total impact being: after a state-sync has begun, if the node for some reason is is shut down, it will refuse to start up again, with the error message: `Fatal: Failed to register the Ethereum service: waiting for sync.`. 

This change also modifies how `geth removedb` works, so that the user is prompted for two things: `state data` and `ancient chain`. The former includes both the chaindb aswell as any state history stored in ancients. 

---------

Co-authored-by: Martin HS <[email protected]>

* core/rawdb: improve state scheme checking (ethereum#28724)

This pull request improves the condition to check if path state scheme is in use. 

Originally, root node presence was used as the indicator if path scheme is used or not. However due to fact that root node will be deleted during the initial snap sync, this condition is no longer useful.

If PersistentStateID is present, it shows that we've already configured for path scheme.

* params: go-ethereum v1.13.8 stable

* params: begin v1.13.9 release cycle

* core/state: logic equivalence for GetCodeHash (ethereum#28733)

* tests: add currentExcessBlobGas to state tests (ethereum#28735)

* accounts,signer: fix typos in comments (ethereum#28730)

* build: add support for ubuntu 23.10 (mantic minotaur) (ethereum#28728)

* log: avoid setting default slog logger in init (ethereum#28747)

slog.SetDefault has undesirable side effects. It also sets the default logger destination,
for example. So we should not call it by default in init.

* cmd/evm: fix link in README.md (ethereum#28755)

* core/vm: update comments to match eip number (ethereum#28743)

* cmd/evm: Fix blob-gas-used on invalid transactions in t8n (ethereum#28734)

cmd/evm: fixes the blob gas calculation if a transaction is invalid

* internal/flags: update copyright year to 2024 (ethereum#28760)


Co-authored-by: Felix Lange <[email protected]>

* ethclient: simplify error handling in TransactionReceipt (ethereum#28748)


Co-authored-by: Martin HS <[email protected]>
Co-authored-by: Felix Lange <[email protected]>

* eth/downloader, eth/filters: use defer to call Unsubscribe (ethereum#28762)

* log: emit error level string as "error", not "eror" (ethereum#28774)

* eth/filters: fix early Unsubscribe of log events (ethereum#28769)

* cmd/devp2p/internal/ethtest: fix typos in comments (ethereum#28772)

* params, core/forkid: schedule cancun fork on goerli (ethereum#28719)

This PR schedules the cancun fork for the goerli testnet as discussed on ACD.
Spec: ethereum/execution-specs#860

We schedule:
  goerli at 1705473120

* cmd/geth: make it possible to autopilot removedb (ethereum#28725)

When managing geth, it is sometimes desirable to do a partial wipe; deleting state but retaining freezer data. A partial wipe can be somewhat tricky to accomplish. 

This change implements the ability to perform partial wipe by making it possible to run geth removedb non-interactive, using command line options instead.

* accounts/abi: fix bigInt topic encoding (ethereum#28764)

* cmd/geth: update log test data (ethereum#28780)

update logger test data

* ethclient/simulated: implement new sim backend (ethereum#28202)

This is a rewrite of the 'simulated backend', an implementation of the ethclient interfaces
which is backed by a simulated blockchain. It was getting annoying to maintain the old
version of the simulated backend feature because there was a lot of code duplication with
the main client. 

The new version is built using parts that we already have: an in-memory geth node instance
running in developer mode provides the chain, while the Go API is provided by ethclient.
A backwards-compatibility wrapper is provided, but the simulated backend has also moved to
a more sensible import path: github.com/ethereum/go-ethereum/ethclient/simulated

---------

Co-authored-by: Felix Lange <[email protected]>
Co-authored-by: Gary Rong <[email protected]>

* params: go-ethereum v1.13.9 stable

* params: begin v1.13.10 release cycle

* version: release v1.13.10 to fix bad tag

* params: begin v1.13.11 release cycle

* docs: fix badge in README (ethereum#28796)

* Fix broken badge in README.md

Replaced broken Github link with IPFS link for long-term storage.

* update go badge

Co-authored-by: lightclient <[email protected]>

---------

Co-authored-by: lightclient <[email protected]>

* eth: minor change of config-accessor (ethereum#28782)

eth: refactor `GetVM`

* cmd: fix typos (ethereum#28798)

* build: fix typo in comment (ethereum#28800)

* accounts, ethclient: minor tweaks on the new simulated backend (ethereum#28799)

* accounts, ethclient: minor tweaks on the new simulated backend

* ethclient/simulated: add an initial batch of gas options

* accounts, ethclient: remove mandatory gasLimit constructor param

* accounts, ethclient: minor option naming tweaks

* cmd/geth, internal/debug: get rid of by-default log config (ethereum#28801)

* cmd/devp2p/internal/ethtest: skip large tx test on github build (ethereum#28794)

This test was failling consistently on the github 32-bit build probably due to slow IO. Skipping it for that green check.

* p2p/dnsdisc: use strings.Cut over strings.IndexByte (ethereum#28787)

* internal/ethapi: avoid using pending for defaults (ethereum#28784)

Given the discussions around deprecating pending (see ethereum#28623 or ethereum/execution-apis#495), we can move away from using the pending block internally, and use latest instead

* core/state: unexport GetOrNewStateObject (ethereum#28804)

* cmd/rlpdump: add -pos flag, displaying byte positions (ethereum#28785)

* tests: update reference tests (ethereum#28778)

Updates the reference tests to the latest version

* ethclient: add tests for TransactionInBlock (ethereum#28283)


Co-authored-by: Felix Lange <[email protected]>

* eth: fix potential hang in waitSnapExtension (ethereum#28744)

This should fix a rare hang in waitSnapExtension during shutdown.

* core/txpool/blobpool: fix typos

* acounts/usbwallet: fix typo (ethereum#28815)

acounts:fix typo

* tests: more verbosity if block decoding fails (ethereum#28814)

* tracer: use proper base fee in tests (ethereum#28775)

 In the tracing tests, the base fee was generally set to nil. This commit changes this to pass the proper base instead, and fixes the few tests which become broken by the change.

* miner: fix typo in payload_building_test.go (ethereum#28825)

* internal/ethapi: handle blobs in API methods (ethereum#28786)

EIP-4844 adds a new transaction type for blobs. Users can submit such transactions via `eth_sendRawTransaction`. In this PR we refrain from adding support to `eth_sendTransaction` and in fact it will fail if the user passes in a blob hash.

However since the chain can handle such transactions it makes sense to allow simulating them. E.g. an L2 operator should be able to simulate submitting a rollup blob and updating the L2 state. Most methods that take in a transaction object should recognize blobs. The change boils down to adding `blobVersionedHashes` and `maxFeePerBlobGas` to `TransactionArgs`. In summary:

- `eth_sendTransaction`: will fail for blob txes
- `eth_signTransaction`: will fail for blob txes

The methods that sign txes does not, as of this PR, add support the for new EIP-4844 transaction types. Resuming the summary:

- `eth_sendRawTransaction`: can send blob txes
- `eth_fillTransaction`: will fill in a blob tx. Note: here we simply fill in normal transaction fields + possibly `maxFeePerBlobGas` when blobs are present. One can imagine a more elaborate set-up where users can submit blobs themselves and we fill in proofs and commitments and such. Left for future PRs if desired.
- `eth_call`: can simulate blob messages
- `eth_estimateGas`: blobs have no effect here. They have a separate unit of gas which is not tunable in the transaction.

* eth/filters: reset filter.begin in BenchmarkFilters (ethereum#28830)

* set head in sbundle pool

* crypto/kzg4844: add helpers for versioned blob hashes (ethereum#28827)

The code to compute a versioned hash was duplicated a couple times, and also had a small
issue: if we ever change params.BlobTxHashVersion, it will most likely also cause changes
to the actual hash computation. So it's a bit useless to have this constant in params.

* ethclient: apply accessList field in toCallArg (ethereum#28832)


Co-authored-by: Felix Lange <[email protected]>

* params, core/forkid: enable cancun on sepolia and holesky (ethereum#28834)

This change enables Cancun 

- Sepolia at 1706655072 (Jan 31st, 2024)
- Holesky at 1707305664 (Feb 7th, 2024)

Specification: ethereum/execution-specs#860

* core, core/rawdb, eth/sync: no tx indexing during snap sync (ethereum#28703)

This change simplifies the logic for indexing transactions and enhances the UX when transaction is not found by returning more information to users.

Transaction indexing is now considered as a part of the initial sync, and `eth.syncing` will thus be `true` if transaction indexing is not yet finished. API consumers can use the syncing status to determine if the node is ready to serve users.

* docs: remove reference to being official (ethereum#28858)

* go.{mod,sum}: upgrade go-ole to support arm64 (ethereum#28859)

go.{mod,sum}: upgrade go-ole

* core: fix genesis setup in benchReadChain (ethereum#28856)

* all: use uint256 in state (ethereum#28598)

This change makes use of uin256 to represent balance in state. It touches primarily upon statedb, stateobject and state processing, trying to avoid changes in transaction pools, core types, rpc and tracers.

* build: upgrade -dlgo version to Go 1.21.6 (ethereum#28836)

* core/state/snapshot: use AddHash/ContainHash instead of Hasher interface (ethereum#28849)

This change switches from using the `Hasher` interface to add/query the bloomfilter to implementing it as methods.
This significantly reduces the allocations for Search and Rebloom.

* core/vm: fix misleading comment (ethereum#28860)

fix misleading comment

* eth/catalyst: add timestamp checks to fcu and new payload and improve param checks (ethereum#28230)

 This PR introduces a few changes with respect to payload verification in fcu and new payload requests:

* First of all, it undoes the `verifyPayloadAttributes(..)` simplification I attempted in ethereum#27872. 
* Adds timestamp validation to fcu payload attributes [as required](https://github.com/ethereum/execution-apis/blob/main/src/engine/cancun.md#specification-1) (section 2) by the Engine API spec. 
* For the new payload methods, I also update the verification of the executable data. For `newPayloadV2`, it does not currently ensure that cancun values are `nil`. Which could make it possible to submit cancun payloads through it. 
* On `newPayloadV3` the same types of checks are added. All shanghai and cancun related fields in the executable data must be non-nil, with the addition that the timestamp is _only_ with cancun.
* Finally it updates a newly failing catalyst test to call the correct fcu and new payload methods depending on the fork.

* core/txpool, eth/catalyst: fix racy simulator due to txpool background reset (ethereum#28837)

This PR fixes an issues in the new simulated backend. The root cause is the fact that the transaction pool has an internal reset operation that runs on a background thread.

When a new transaction is added to the pool via the RPC, the transaction is added to a non-executable queue and will be moved to its final location on a background thread. If the machine is overloaded (or simply due to timing issues), it can happen that the simulated backend will try to produce the next block, whilst the pool has not yet marked the newly added transaction executable. This will cause the block to not contain the transaction. This is an issue because we want determinism from the simulator: add a tx, mine a block. It should be in there.

The PR fixes it by adding a Sync function to the txpool, which waits for the current reset operation (if any) to finish, and then runs an entire round of reset on top. The new round is needed because resets are only triggered by new head events, so newly added transactions will not trigger the outer resets that we can wait on. The transaction pool would eventually internally do a reset even on transaction addition, but there's no easy way to wait on that and there's no meaningful reason to bubble that across everything. A clean outer reset will at worse be a small noop goroutine.

* core: move tx indexer to its own file (ethereum#28857)

This change moves all the transaction indexing functions to a separate txindexer.go file and defines a txIndexer structure as a refactoring.

* eth/catalyst: prefix payload id with version (ethereum#28246)

GetPayloadVX should only return payloads which match its version. GetPayloadV2 is a special snowflake that supports v1 and v2 payloads. This change uses a a version-specific prefix within in the payload id, basically a namespace for the version number.

* ethclient: fix flaky test (ethereum#28864)

Fix flaky test due to incomplete transaction indexing

* params: go-ethereum v1.13.11 stable

* params: begin v.1.13.12 release cycle

* merge v1.13.11

* internal/flags: fix typo (ethereum#28876)

* core/types: fix and test handling of faulty nil-returning signer (ethereum#28879)

This adds an error if the signer returns a nil value for one of the signature value fields.

* README.md: fix travis badge (ethereum#28889)

The hyperlink in the README file that directs to the Travis CI build was broken.
This commit updates the link to point to the corrent build page.

* eth/catalyst: allow payload attributes v1 in fcu v2 (ethereum#28882)

At some point, `ForkchoiceUpdatedV2` stopped working for `PayloadAttributesV1` while `paris` was active. This was causing a few failures in hive. This PR fixes that, and also adds a gate in `ForkchoiceUpdatedV1` to disallow `PayloadAttributesV3`.

* docs/postmortems: fix outdated link (ethereum#28893)

* core: reset tx lookup cache if necessary (ethereum#28865)

This pull request resets the txlookup cache if chain reorg happens, 
preventing them from remaining reachable. It addresses failures in
the hive tests.

* build: fix problem with windows line-endings in CI download (ethereum#28900)

fixes ethereum#28890

* eth/downloader: fix skeleton cleanup (ethereum#28581)

* eth/downloader: fix skeleton cleanup

* eth/downloader: short circuit if nothing to delete

* eth/downloader: polish the logic in cleanup

* eth/downloader: address comments

* deps: update memsize (ethereum#28916)

* core/txpool/blobpool: post-crash cleanup and addition/removal metrics (ethereum#28914)

* core/txpool/blobpool: clean up resurrected junk after a crash

* core/txpool/blobpool: track transaction insertions and rejections

* core/txpool/blobpool: linnnnnnnt

* core/txpool: don't inject lazy resolved transactions into the container (ethereum#28917)

* core/txpool: don't inject lazy resolved transactions into the container

* core/txpool: minor typo fixes

* add bundle support

* core/types: fix typo (ethereum#28922)

* fix tests

* add blob fields

* fix logging

* p2p: fix accidental termination of portMappingLoop (ethereum#28911)

* internal/flags: fix --miner.gasprice default listing (ethereum#28932)

* all: fix typos in comments (ethereum#28881)

* Makefile: add help target to display available targets (ethereum#28845)


Co-authored-by: Martin HS <[email protected]>
Co-authored-by: Felix Lange <[email protected]>

* core: cache transaction indexing tail in memory (ethereum#28908)

* eth, miner: fix enforcing the minimum miner tip (ethereum#28933)

* eth, miner: fix enforcing the minimum miner tip

* ethclient/simulated: fix failing test due the min tip change

* accounts/abi/bind: fix simulater gas tip issue

* remove private txs from blobs

* core/state, core/vm: minor uint256 related perf improvements (ethereum#28944)

* cmd,internal/era: implement `export-history` subcommand (ethereum#26621)

* all: implement era format, add history importer/export

* internal/era/e2store: refactor e2store to provide ReadAt interface

* internal/era/e2store: export HeaderSize

* internal/era: refactor era to use ReadAt interface

* internal/era: elevate anonymous func to named

* cmd/utils: don't store entire era file in-memory during import / export

* internal/era: better abstraction between era and e2store

* cmd/era: properly close era files

* cmd/era: don't let defers stack

* cmd/geth: add description for import-history

* cmd/utils: better bytes buffer

* internal/era: error if accumulator has more records than max allowed

* internal/era: better doc comment

* internal/era/e2store: rm superfluous reader, rm superfluous testcases, add fuzzer

* internal/era: avoid some repetition

* internal/era: simplify clauses

* internal/era: unexport things

* internal/era,cmd/utils,cmd/era: change to iterator interface for reading era entries

* cmd/utils: better defer handling in history test

* internal/era,cmd: add number method to era iterator to get the current block number

* internal/era/e2store: avoid double allocation during write

* internal/era,cmd/utils: fix lint issues

* internal/era: add ReaderAt func so entry value can be read lazily

Co-authored-by: lightclient <[email protected]>
Co-authored-by: Martin Holst Swende <[email protected]>

* internal/era: improve iterator interface

* internal/era: fix rlp decode of header and correctly read total difficulty

* cmd/era: fix rebase errors

* cmd/era: clearer comments

* cmd,internal: fix comment typos

---------

Co-authored-by: Martin Holst Swende <[email protected]>

* core,params: add holesky to default genesis function (ethereum#28903)

* fix tests

* node, rpc: add configurable HTTP request limit (ethereum#28948)

Adds a configurable HTTP request limit, and bumps the engine default

* all: fix docstring names (ethereum#28923)

* fix wrong comment

* reviewers input

* Update log/handler_glog.go

---------

Co-authored-by: Martin HS <[email protected]>

* ethclient/simulated: fix typo (ethereum#28952)

(ethclient/simulated):fix typo

* eth/gasprice: fix percentile validation in eth_feeHistory (ethereum#28954)

* cmd/devp2p, eth: drop support for eth/67 (ethereum#28956)

* params, core/forkid: add mainnet timestamp for Cancun (ethereum#28958)

* params: add cancun timestamp for mainnet

* core/forkid: add test for mainnet cancun forkid

* core/forkid: update todo tests for cancun

* internal/ethapi: add support for blobs in eth_fillTransaction (ethereum#28839)

This change adds support for blob-transaction in certain API-endpoints, e.g. eth_fillTransaction. A follow-up PR will add support for signing such transactions.

* internal/era: update block index format to be based on record offset (ethereum#28959)

As mentioned in ethereum#26621, the block index format for era1 is not in line with the regular era block index. This change modifies the index so all relative offsets are based against the beginning of the block index record.

* params: go-ethereum v1.13.12 stable

* params: begin v1.13.13 release cycle

* build: remove ubuntu 'lunar' build (ethereum#28962)

* fix: update outdated link to trezor docs (ethereum#28966)

fix: update link to trezor

* internal/ethapi: fix gas estimation bug in eth_fillTransaction for blob tx (ethereum#28929)

* fix nil pointer resolving tx

* fix memory leak in prefetcher

* core/txpool/legacypool: use uint256.Int instead of big.Int (ethereum#28606)

This change makes the legacy transaction pool use of `uint256.Int` instead of `big.Int`. The changes are made primarily only on the internal functions of legacypool. 

---------

Co-authored-by: Martin Holst Swende <[email protected]>

* internal/ethapi, signer/core: fix documentation-links (ethereum#28979)

fix: management api links

* all: remove the dependency from trie to triedb (ethereum#28824)

This change removes the dependency from trie package to triedb package.

* cmd/utils: fix merge-breakage in test (ethereum#28985)

* tests: fix goroutine leak related to state snapshot generation (ethereum#28974)


---------

Co-authored-by: Felix Lange <[email protected]>

* ethereum, ethclient: add blob transaction fields in CallMsg (ethereum#28989)


Co-authored-by: Felix Lange <[email protected]>

* core/txpool/blobpool: rename variables in comments (ethereum#28981)


Co-authored-by: Felix Lange <[email protected]>

* cmd/devp2p: fix modulo in makeBlobTxs (ethereum#28970)

* eth/catalyst,beacon/engine: implement GetClientVersionV1 (ethereum#28915)

* tests: update execution spec tests + split statetest exec (ethereum#28993)

* eth/catalyst: add getClientVersion to capabilities (ethereum#28994)

* cmd/evm: fix typo in test script (ethereum#28995)

* cmd/devp2p/internal/ethtest: some fixes for the eth test suite (ethereum#28996)

Improving two things here:

On hive, where we look at these tests, the Go code comment above the test
is not visible. When there is a failure, it's not obvious what the test is actually
expecting. I have converted the comments in to printed log messages to
explain the test more.

Second, I noticed that besu is failing some tests because it happens to request
a header when we want it to send transactions. Trying the minimal fix here to
serve the headers.

Co-authored-by: lightclient <[email protected]>

* core/txpool/legacypool: remove a redundant heap.Init (ethereum#28910)


Co-authored-by: Martin HS <[email protected]>
Co-authored-by: Felix Lange <[email protected]>

* core/txpool/blobpool: update the blob db with corruption handling (ethereum#29001)

Updates billy to a more recent version which is more robust in the face of corrupt data (e.g. after a hard crash)

* core: move genesis alloc types to core/types (ethereum#29003)

We want to use these types in public user-facing APIs, so they shouldn't be in core.

Co-authored-by: Felix Lange <[email protected]>

* core/txpool, eth, miner: pre-filter dynamic fees during pending tx retrieval (ethereum#29005)

* core/txpool, eth, miner: pre-filter dynamic fees during pending tx retrieval

* miner: fix typo

* core/txpool: handle init-error in blobpool without panicing

---------

Co-authored-by: Martin Holst Swende <[email protected]>

* ethstats: prevent panic if head block is not available (ethereum#29020)

This pull request fixes a flaw in ethstats which can lead to node crash

A panic could happens when the local blockchain is reorging which causes the original head block not to be  reachable (since number->hash canonical mapping is deleted). In order to prevent the panic, the block nilness is now checked in ethstats.

* core: using math.MaxUint64 instead of 0xffffffffffffffff (ethereum#29022)

* core/txpool, miner: speed up blob pool pending retrievals (ethereum#29008)

* core/txpool, miner: speed up blob pool pending retrievals

* miner: fix test merge issue

* eth: same same

* core/txpool/blobpool: speed up blobtx creation in benchmark a bit

* core/txpool/blobpool: fix linter

---------

Co-authored-by: Martin Holst Swende <[email protected]>

* core/vm, params: ensure order of forks, prevent overflow (ethereum#29023)

This PR fixes an overflow which can could happen if inconsistent blockchain rules were configured. Additionally, it tries to prevent such inconsistencies from occurring by making sure that merge cannot be enabled unless previous fork(s) are also enabled.

* core/txpool, eth, miner: retrieve plain and blob txs separately (ethereum#29026)

* core/txpool, eth, miner: retrieve plain and blob txs separately

* core/txpool: fix typo, no farming

* miner: farm all the typos

Co-authored-by: Martin HS <[email protected]>

---------

Co-authored-by: Martin HS <[email protected]>

* core/txpool: fix typo (ethereum#29031)

* core,eth,internal: fix typo (ethereum#29024)

* params: add cancun upgrade banner (ethereum#29042)

params: add cancun banner

Signed-off-by: tmelhao <[email protected]>
Co-authored-by: tmelhao <[email protected]>

* core/txpool: fix typo (ethereum#29036)

* fix typos

* address comments

* internal/ethapi: fix defaults for blob fields (ethereum#29037)


Co-authored-by: Martin HS <[email protected]>

* params: release go-ethereum v1.13.13 stable

* params: begin v1.13.14 release cycle

* internal/ethapi: use overriden baseFee for gasPrice (ethereum#29051)

eth_call and debug_traceCall allow users to override various block fields, among them base fee. However the overriden base fee was not considered for computing the effective gas price of that message, and instead base fee of the base block was used. This has been fixed in this commit.

* internal/ethapi:fix zero rpc gas cap in eth_createAccessList (ethereum#28846)

This PR enhances eth_createAccessList RPC call to support scenarios where the node is launched with an unlimited gas cap (--rpc.gascap 0). The eth_createAccessList RPC call returns failure if user doesn't explicitly set a gas limit.

* eth/catalyst: fix wrong error message of payloadV2 after cancun (ethereum#29049)

* eth/catalyst: the same error format

Signed-off-by: tmelhao <[email protected]>

* eth/catalyst: wrong error message for payloadV2 post-cancun

Signed-off-by: tmelhao <[email protected]>

* eth/catalyst: parentBeaconBlockRoot -> parentBlockBeaconRoot

Signed-off-by: tmelhao <[email protected]>

* apply commit review

Signed-off-by: tmelhao <[email protected]>

---------

Signed-off-by: tmelhao <[email protected]>
Co-authored-by: tmelhao <[email protected]>

* fix tests

* core/txpool: reject blob txs with blob fee cap below the minimum (ethereum#29081)

* make blobpool reject blob transactions with fee below the minimum

* core/txpool: some minot nitpick polishes and unified error formats

* core/txpool: do less big.Int constructions with the min blob cap

---------

Co-authored-by: Péter Szilágyi <[email protected]>

* p2p, log, rpc: use errors.New to replace fmt.Errorf with no parameters (ethereum#29074)

* eth/catalyst: enable some commented-out testcases   (ethereum#29073)

* internal/ethapi: pass blob hashes to gas estimation (ethereum#29085)

* cmd/clef: add spaces in README.md table (ethereum#29077)

Add space after links in so they are clickable in vscode.

* eth/catalyst: remove variable in tx conversion loop (ethereum#29076)

* core/txpool/blobpool: reduce default database cap for rollout (ethereum#29090)

xcore/txpool/blobpool: reduce default database cap for rollout

* core/txpool: no need to log loud rotate if no local txs (ethereum#29083)

* core/txpool: no need to run rotate if no local txs

Signed-off-by: jsvisa <[email protected]>

* Revert "core/txpool: no need to run rotate if no local txs"

This reverts commit 17fab17.

Signed-off-by: jsvisa <[email protected]>

* use Debug if todo is empty

Signed-off-by: jsvisa <[email protected]>

---------

Signed-off-by: jsvisa <[email protected]>

* eth/tracers: Fix callTracer logs on onlyTopCall == true (ethereum#29068)

* core/txpool: elevate the 'already reserved' error into a constant (ethereum#29095)

declare the 'already reserved' error in errors.go

* params: release Geth v1.13.14

* fix statedb.Finalize()

* minimize diff from upstream (ethereum#147)

* add back private tx logic

* add excess blob gas to mev sim bundle (ethereum#148)

* remove panic from worker.go

---------

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: tmelhao <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Co-authored-by: Marius van der Wijden <[email protected]>
Co-authored-by: Maciej Kulawik <[email protected]>
Co-authored-by: ucwong <[email protected]>
Co-authored-by: Mario Vega <[email protected]>
Co-authored-by: Delweng <[email protected]>
Co-authored-by: jwasinger <[email protected]>
Co-authored-by: Felix Lange <[email protected]>
Co-authored-by: lightclient <[email protected]>
Co-authored-by: Håvard Anda Estensen <[email protected]>
Co-authored-by: Guillaume Ballet <[email protected]>
Co-authored-by: Martin Holst Swende <[email protected]>
Co-authored-by: Mikel Cortes <[email protected]>
Co-authored-by: Péter Szilágyi <[email protected]>
Co-authored-by: Ng Wei Han <[email protected]>
Co-authored-by: rjl493456442 <[email protected]>
Co-authored-by: lightclient <[email protected]>
Co-authored-by: Shivam Sandbhor <[email protected]>
Co-authored-by: Sina Mahmoodi <[email protected]>
Co-authored-by: Jakub Freebit <[email protected]>
Co-authored-by: Oren <[email protected]>
Co-authored-by: BorkBorked <[email protected]>
Co-authored-by: ddl <[email protected]>
Co-authored-by: Manav Darji <[email protected]>
Co-authored-by: Marius Kjærstad <[email protected]>
Co-authored-by: Felföldi Zsolt <[email protected]>
Co-authored-by: Ford <[email protected]>
Co-authored-by: Ursulafe <[email protected]>
Co-authored-by: Elias Rad <[email protected]>
Co-authored-by: FletcherMan <[email protected]>
Co-authored-by: alex <[email protected]>
Co-authored-by: Sebastian Stammler <[email protected]>
Co-authored-by: wangyifan <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: cygaar <[email protected]>
Co-authored-by: Taeguk Kwon <[email protected]>
Co-authored-by: ddl <[email protected]>
Co-authored-by: Darioush Jalali <[email protected]>
Co-authored-by: Rossen Krastev <[email protected]>
Co-authored-by: vuittont60 <[email protected]>
Co-authored-by: drstevenbrule <[email protected]>
Co-authored-by: HAOYUatHZ <[email protected]>
Co-authored-by: hyunchel <[email protected]>
Co-authored-by: 牛晓婕 <[email protected]>
Co-authored-by: Alfie John <[email protected]>
Co-authored-by: Paul Lange <[email protected]>
Co-authored-by: Thabokani <[email protected]>
Co-authored-by: colin <[email protected]>
Co-authored-by: trocher <[email protected]>
Co-authored-by: protolambda <[email protected]>
Co-authored-by: KeienWang <[email protected]>
Co-authored-by: zoereco <[email protected]>
Co-authored-by: Chris Ziogas <[email protected]>
Co-authored-by: Dimitris Apostolou <[email protected]>
Co-authored-by: Halimao <[email protected]>
Co-authored-by: lmittmann <[email protected]>
Co-authored-by: Peter Straus <[email protected]>
Co-authored-by: maskpp <[email protected]>
Co-authored-by: Lindlof <[email protected]>
Co-authored-by: bk <[email protected]>
Co-authored-by: cui <[email protected]>
Co-authored-by: buddho <[email protected]>
Co-authored-by: Haotian <[email protected]>
Co-authored-by: tmelhao <[email protected]>
Co-authored-by: ArtificialPB <[email protected]>
Co-authored-by: Roberto Bayardo <[email protected]>
Co-authored-by: Qt <[email protected]>
Co-authored-by: Justin Dhillon <[email protected]>
Co-authored-by: Andrei Silviu Dragnea <[email protected]>
Co-authored-by: Vitaly Drogan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman holiman left review comments

@fjl fjl fjl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.13.13
Development

Successfully merging this pull request may close these issues.
3 participants
@s1na @fjl @holiman