Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ethclient: add tests for TransactionInBlock #28283

Merged
merged 4 commits into from
Jan 15, 2024

Conversation

hyunchel
Copy link
Contributor

@hyunchel hyunchel commented Oct 8, 2023

This commit also asserts context.Cancel error upon canceling, and removes unnecessary newlines in logs messages.

ethclient/ethclient_test.go Outdated Show resolved Hide resolved
@fjl fjl changed the title ethclient: add tests on TxInBlock function ethclient: add tests for TransactionInBlock Nov 22, 2023
@holiman holiman added this to the 1.13.11 milestone Jan 15, 2024
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hyunchel and others added 4 commits January 15, 2024 09:29
This commit also asserts context.Cancel error upon canceling,
and removes unnecessary newlines in logs messages.
@holiman holiman force-pushed the add-ethclient-test branch from 7b6f7bd to 11c0987 Compare January 15, 2024 08:40
@fjl fjl merged commit 7596db5 into ethereum:master Jan 15, 2024
2 of 3 checks passed
Dergarcon pushed a commit to specialmechanisms/mev-geth-0x2mev that referenced this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants