Update EIP-7702: update EXTCODE* opcodes to act on full "delegation designator"
#9248
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: updates EIP-7702 EXTCODE* behavior
github-actions
bot
added
c-update
|
✅ All reviewers have approved. |
jochem-brouwer
suggested changes
Jan 16, 2025
EIPS/eip-7702.md
Outdated
|
|
||
| For example, `EXTCODESIZE` would return `2` (the size of `0xef01`) instead of `23` which would represent the delegation designation, `EXTCODEHASH` would return `0xeadcdba66a79ab5dce91622d1d75c8cff5cff0b96944c3bf1072cd08ce018329` (`keccak256(0xef01)`), and `CALL` would load the code from `address` and execute it in the context of `authority`. | ||
| For example, `EXTCODESIZE` would return `23` (the size of `0xef0100 || address`), `EXTCODEHASH` would return (`keccak256(0xef0100 || address)`), and `CALL` would load the code from `address` and execute it in the context of `authority`. |
There was a problem hiding this comment.
Suggested change
| For example, `EXTCODESIZE` would return `23` (the size of `0xef0100 || address`), `EXTCODEHASH` would return (`keccak256(0xef0100 || address)`), and `CALL` would load the code from `address` and execute it in the context of `authority`. | |
| For example, `EXTCODESIZE` would return `23` (the size of `0xef0100 || address`), `EXTCODEHASH` would return `keccak256(0xef0100 || address)`, and `CALL` would load the code from `address` and execute it in the context of `authority`. |
There was a problem hiding this comment.
Thanks for the feedback! Just fixed this 👍
Fix style feedback
Jrachman
approved these changes
Jan 20, 2025
16 tasks
|
Fully support, introspection is good! |
31 tasks
10 tasks
lightclient
approved these changes
Jan 23, 2025
eth-bot
approved these changes
Jan 23, 2025
marioevz
reviewed
Jan 23, 2025
|
|
||
| For example, `EXTCODESIZE` would return `2` (the size of `0xef01`) instead of `23` which would represent the delegation designation, `EXTCODEHASH` would return `0xeadcdba66a79ab5dce91622d1d75c8cff5cff0b96944c3bf1072cd08ce018329` (`keccak256(0xef01)`), and `CALL` would load the code from `address` and execute it in the context of `authority`. | ||
| For example, `EXTCODESIZE` would return `23` (the size of `0xef0100 || address`), `EXTCODEHASH` would return `keccak256(0xef0100 || address)`, and `CALL` would load the code from `address` and execute it in the context of `authority`. |
There was a problem hiding this comment.
Suggested change
| For example, `EXTCODESIZE` would return `23` (the size of `0xef0100 || address`), `EXTCODEHASH` would return `keccak256(0xef0100 || address)`, and `CALL` would load the code from `address` and execute it in the context of `authority`. | |
| For example, `EXTCODESIZE` would return `23` (the size of `0xef0100 || address`), `EXTCODEHASH` would return `keccak256(0xef0100 || address)`, `EXTCODECOPY` would return `(0xef0100 || address)`, and `CALL` would load the code from `address` and execute it in the context of `authority`. |
Maybe just add EXTCODECOPY too here to make it explicit?
There was a problem hiding this comment.
Ah it's merged, if necessary I can add another PR with the clarification 👍
8 tasks
lightclient
pushed a commit
to ethereum/go-ethereum
that referenced
this pull request
Jan 30, 2025
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the proposed changes to
EXTCODE*behavior over concerns brought up in this post on HackMD. The proposed changes were discussed at ACD (1/16/25) and agreed upon by those present.