Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-7702: Set EOA account code [devnet-4 version] #961

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented Jul 25, 2024

Current status:

  • Some EEST failures due to changed state test format (too wide values for s, chain_id, nonce in authorizations)
    • should be fixed in test fixtures
  • Need some optimizations, related to new StateDiff API, see TODOs in recent commits

Depends on ethereum/evmc#720

@gumb0 gumb0 self-assigned this Jul 25, 2024
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 96.42857% with 14 lines in your changes missing coverage. Please review.

Project coverage is 94.33%. Comparing base (94582ff) to head (681d562).

Files with missing lines Patch % Lines
lib/evmone/instructions.hpp 89.18% 4 Missing ⚠️
test/state/errors.hpp 0.00% 4 Missing ⚠️
lib/evmone/instructions_calls.cpp 81.25% 3 Missing ⚠️
test/state/state.cpp 96.77% 2 Missing ⚠️
test/statetest/statetest.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #961      +/-   ##
==========================================
+ Coverage   94.29%   94.33%   +0.04%     
==========================================
  Files         157      158       +1     
  Lines       17080    17448     +368     
==========================================
+ Hits        16105    16460     +355     
- Misses        975      988      +13     
Flag Coverage Δ
eof_execution_spec_tests 23.29% <15.60%> (-0.24%) ⬇️
ethereum_tests 26.12% <11.76%> (-0.38%) ⬇️
ethereum_tests_silkpre 18.84% <9.43%> (-0.26%) ⬇️
execution_spec_tests 21.01% <37.85%> (+0.78%) ⬆️
unittests 89.45% <87.72%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
test/blockchaintest/blockchaintest.cpp 87.50% <ø> (ø)
test/blockchaintest/blockchaintest.hpp 0.00% <ø> (ø)
test/state/account.hpp 100.00% <ø> (ø)
test/state/host.cpp 100.00% <100.00%> (ø)
test/state/state_diff.hpp 100.00% <ø> (ø)
test/state/test_state.cpp 100.00% <100.00%> (ø)
test/state/transaction.cpp 95.45% <100.00%> (+1.16%) ⬆️
test/state/transaction.hpp 100.00% <ø> (ø)
test/statetest/statetest.cpp 92.85% <100.00%> (+0.54%) ⬆️
test/statetest/statetest_loader.cpp 98.33% <100.00%> (+0.17%) ⬆️
... and 8 more

@gumb0 gumb0 force-pushed the eip-7702 branch 4 times, most recently from 5e9c460 to 7f9d123 Compare July 29, 2024 13:27
@gumb0 gumb0 changed the title WIP EIP-7702 implementation EIP-7702: Set EOA account code Jul 29, 2024
@gumb0 gumb0 force-pushed the eip-7702 branch 9 times, most recently from ccc3776 to 90c05f4 Compare August 2, 2024 18:22
@gumb0 gumb0 force-pushed the eip-7702 branch 8 times, most recently from 056e8ae to a919431 Compare August 8, 2024 09:31
@gumb0 gumb0 force-pushed the eip-7702 branch 6 times, most recently from e19a72a to 3ff5253 Compare August 19, 2024 16:26
@gumb0 gumb0 force-pushed the eip-7702 branch 6 times, most recently from fd6fe82 to 9b1315e Compare November 6, 2024 10:40
@gumb0 gumb0 marked this pull request as ready for review November 6, 2024 10:47
@gumb0 gumb0 force-pushed the eip-7702 branch 2 times, most recently from 24eece6 to 94ab6b8 Compare November 6, 2024 11:25
@gumb0 gumb0 force-pushed the eip-7702 branch 2 times, most recently from 15c5ce5 to dcdb8c8 Compare November 25, 2024 12:00
@gumb0 gumb0 changed the title EIP-7702: Set EOA account code EIP-7702: Set EOA account code [devnet-4 version] Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants