Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(cheatcodes): slight change to EIP-7702 spec #9751

Closed
dave-carroll7 opened this issue Jan 23, 2025 · 2 comments · Fixed by #9779
Closed

bug(cheatcodes): slight change to EIP-7702 spec #9751

dave-carroll7 opened this issue Jan 23, 2025 · 2 comments · Fixed by #9779
Labels
A-cheatcodes Area: cheatcodes A-evm Area: EVM T-bug Type: bug

Comments

@dave-carroll7
Copy link

dave-carroll7 commented Jan 23, 2025

There was a recent change made to the EIP-7702 spec surrounding EXTCODE* opcode behavior for delegated EOAs. Here's a link to the PR for that change.

Spec change TLDR: EXTCODE* opcodes will now operate on the full "delegation designator" i.e. 0xef0100 || delegate_address instead of just the designator prefix.

We have been using the new cheatcode vm.signAndAttachDelegation (implemented in this PR) for writing unit tests and it has been super helpful! We'd just like to request that this cheatcode get updated such that EXTCODE* opcodes behave according to the new spec when called on delegated EOAs.

@github-project-automation github-project-automation bot moved this to Todo in Foundry Jan 23, 2025
@grandizzy grandizzy added T-bug Type: bug A-cheatcodes Area: cheatcodes labels Jan 24, 2025
@grandizzy
Copy link
Collaborator

grandizzy commented Jan 24, 2025

depends on revm supporting the change, will add as soon as it is in

@grandizzy grandizzy added the A-evm Area: EVM label Jan 24, 2025
@Jrachman
Copy link

depends on revm supporting the change, will add as soon as it is in

@grandizzy bluealloy/revm#2016 <- looks like revm was updated! Looking forward to getting this upgrade in :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cheatcodes Area: cheatcodes A-evm Area: EVM T-bug Type: bug
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants