Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update from dev #425

Merged
merged 158 commits into from
Jan 25, 2023
Merged

Update from dev #425

merged 158 commits into from
Jan 25, 2023

Conversation

tensionhead
Copy link
Contributor

No description provided.

KatharineShapcott and others added 30 commits December 30, 2022 10:13
@KatharineShapcott
FIX: Replace very inefficient discrete _get_trial
533425b 
On my data x20 speedup
@KatharineShapcott
FIX: end of slice incremented by 1
8c1db01
@KatharineShapcott
FIX: return empty array NOT all data
f28eead
@KatharineShapcott
CHG: remove unique from sample
f2c280c
@KatharineShapcott
CHG: new _trialslice property for DiscreteData
1cd9b03
@KatharineShapcott
CHG: Update DiscreteData to use _trialslice
321c2d3 
Removed custom .trials property
@dfsp-spirit
ise logger in SpyWarning
f6a6cf3
@dfsp-spirit
NEW: set logger name
f777295
@dfsp-spirit
Merge branch 'dev' into 208-headless-logging
c7b6162
@dfsp-spirit
FIX: add import
6464c91
@dfsp-spirit
CHG: disable test using a slice
686f517
@dfsp-spirit
FIX: remove slice test
d8fbb8c
@dfsp-spirit
CHG: replace all print calls with logger calls in errors.py
481a00e
@dfsp-spirit
FIX: minor, fix typo
98ca825
@dfsp-spirit
FIX: prevent teardown method from being called in parallel test
857fd83
@dfsp-spirit
NEW: add logging documentation to dev docs
dc183f6
@dfsp-spirit
CHG: fix typo
25d7403
@dfsp-spirit
CHG: extend logging documenation
4ce4e1c
@kshapcott
FIX: no data returns empty array
ccbff5c
@tensionhead
Merge pull request #411 from esi-neuroscience/dev
a946403 
update from Dev
@tensionhead
CHG: revert sample property
b730e92 
Changes to be committed:
	modified:   syncopy/datatype/discrete_data.py
@dfsp-spirit
set default log level
40b9348
@dfsp-spirit
Merge branch '208-headless-logging' of https://github.com/esi-neurosc…
ae8ab31 
…ience/syncopy into 208-headless-logging
@dfsp-spirit
NEW: allow silencing of module import message
49a8241
@dfsp-spirit
NEW: better checking of default log level
8c9cbf2
@dfsp-spirit
NEW: add logdir, move temp storage folder
2f98f24
@dfsp-spirit
merge dev, resolve minor conflict in test
1011bdb
@dfsp-spirit
FIX: recursively create dir
7172970
@dfsp-spirit
DIX: fix makedirs usage
404006c
@dfsp-spirit
FIX: allow existing dir
c8063e9
kshapcott and others added 28 commits January 18, 2023 13:03
@kshapcott
Merge branch 'dev' into discrete-get-methods
4753f88
@tensionhead
Update Changelog
4ec7eac 
Changes to be committed:
	modified:   CHANGELOG.md
@tensionhead
Merge pull request #424 from esi-neuroscience/discrete-get-methods
040888e 
Another discrete speedup
@dfsp-spirit
NEW: resolve merge condflict with dev
bd134e0
@dfsp-spirit
CHG: move logging setup to function
73a5fe1
@kajal5888
replay test for configuration added
50e87f1
@tensionhead
Merge pull request #416 from esi-neuroscience/Add_CSD_Connectivity
99e723f 
Add csd connectivity
@dfsp-spirit
Merge branch 'dev' into 208-headless-logging
5ddf312
@tensionhead
CHG: Print log path on package init
d3d8960 
Changes to be committed:
	modified:   syncopy/__init__.py
	modified:   syncopy/shared/log.py
@dfsp-spirit
CHG: minor change to log dir info message
65d8313
@dfsp-spirit
NEW: support setting both tempfir and logdir via SPYDIR env var
6310382
@dfsp-spirit
CHG: refactor to reduce code duplication
d25fc84
@dfsp-spirit
CHG: more logging in parallel mode, separate format
ad65b9a
@dfsp-spirit
NEW: add new IMPORTANT log level, set as default for loggers.
cc3aa9e
@dfsp-spirit
NEW: add convenience function set_loglevel
137dffe
@dfsp-spirit
FIX: pass session to log init func
a39bfd4
@dfsp-spirit
FIX: change expected log level in test, do not err on custom log leve…
d4adf50 
…l already set.2
@dfsp-spirit
FIX: adapt numeric value of new IMPORTANT level
3f14e67
@dfsp-spirit
FIX: fix typo
8836bbe
@dfsp-spirit
NEW: add test for par log file
4e7b13b
@dfsp-spirit
NEW: test parallel logger
b65c43a
@dfsp-spirit
FIX: minor, fix typo in log message in test
b3d82d6
@dfsp-spirit
CHG: remove SessionLogger
059604c
@dfsp-spirit
CHG: Update new default log level in docs.
bab250c
@dfsp-spirit
CHG: set log level of logfile locations on startup to DEBUG
e9701c8
@tensionhead
CHG: Elevate parallel processing log level
822edd0 
Changes to be committed:
	modified:   syncopy/shared/kwarg_decorators.py
@tensionhead
CHG: Shorten time format, remove milliseconds
16afe42 
Changes to be committed:
	modified:   syncopy/shared/log.py
@tensionhead
Merge pull request #409 from esi-neuroscience/208-headless-logging
fe1d424 
Add logging to syncopy
@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Base: 68.64% // Head: 68.20% // Decreases project coverage by -0.45% ⚠️

Coverage data is based on head (fe1d424) compared to base (f64d8dd).
Patch coverage: 73.98% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #425      +/-   ##
==========================================
- Coverage   68.64%   68.20%   -0.45%     
==========================================
  Files          79       81       +2     
  Lines        9610     9826     +216     
  Branches     1995     2034      +39     
==========================================
+ Hits         6597     6702     +105     
- Misses       2505     2591      +86     
- Partials      508      533      +25
Impacted Files Coverage Δ
syncopy/io/load_ft.py 9.47% <0.00%> (ø)
syncopy/io/load_nwb.py 8.48% <0.00%> (ø)
syncopy/io/load_tdt.py 5.58% <0.00%> (ø)
syncopy/io/utils.py 22.36% <0.00%> (ø)
syncopy/nwanalysis/csd.py 86.95% <ø> (ø)
syncopy/tests/helpers.py 100.00% <ø> (ø)
syncopy/datatype/base_data.py 76.72% <63.63%> (-1.21%) ⬇️
syncopy/shared/errors.py 41.80% <64.86%> (+4.82%) ⬆️
syncopy/datatype/discrete_data.py 66.55% <66.66%> (-11.76%) ⬇️
syncopy/shared/log.py 66.66% <66.66%> (ø)
... and 31 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tensionhead tensionhead merged commit daf4ba5 into master Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tensionhead @KatharineShapcott @dfsp-spirit @kshapcott @kajal5888