Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Another discrete speedup #424

Merged
merged 4 commits into from
Jan 18, 2023
Merged

Another discrete speedup #424

merged 4 commits into from
Jan 18, 2023

Conversation

KatharineShapcott
Copy link
Contributor

@KatharineShapcott KatharineShapcott commented Jan 18, 2023 •
edited by tensionhead
Loading

Changes Summary

Use _trialslice wherever possible to make things more efficient

Reviewer Checklist

  • Are testing routines present?
  • Do objects in the global package namespace perform proper parsing of their input?
  • Are all docstrings complete and accurate?
  • Is the CHANGELOG.md up to date?

tensionhead
tensionhead approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@tensionhead tensionhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha true, that was part of your original idea right?! I will just commit a changelog entry, then good to merge 👍

@tensionhead
Update Changelog
4ec7eac 
Changes to be committed:
	modified:   CHANGELOG.md
@tensionhead tensionhead merged commit 040888e into dev Jan 18, 2023
@tensionhead tensionhead deleted the discrete-get-methods branch March 31, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tensionhead tensionhead tensionhead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KatharineShapcott @tensionhead @kshapcott