-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add csd connectivity #416
Add csd connectivity #416
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @kajal5888 ! See my detailed comments below, I think most critical would be to rename the new_cfg
entry for this frontend, as this right now breaks replayability.
You would also see this in a proper test however, would be great you could add a class TestCSD
in /tests/test_connectivity.py
. The easiest test I could think of, is to take the same synth data as in TestCoherence
, and plug the new output generated with method='csd'
into an existing csd normalization routine to recover the coherence from that csd.
Codecov ReportBase: 68.70% // Head: 68.04% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev #416 +/- ##
==========================================
- Coverage 68.70% 68.04% -0.67%
==========================================
Files 79 80 +1
Lines 9610 9632 +22
Branches 1995 2010 +15
==========================================
- Hits 6603 6554 -49
- Misses 2502 2559 +57
- Partials 505 519 +14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…ncopy into Add_CSD_Connectivity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thx @kajal5888 !
Author Guidelines
Reviewer Checklist