Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bp/1.30] repo: Move examples to own repo (#35471) #36261

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

phlax
Copy link
Member

@phlax phlax commented Sep 20, 2024

fix #32737

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Sep 20, 2024
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @mattklein123

🐱

Caused by: #36261 was opened by phlax.

see: more, trace.

@phlax phlax changed the title [bp/1.30] repo: Move examples to own repo (#35471) [WIP/bp/1.30] repo: Move examples to own repo (#35471) Sep 20, 2024
@phlax phlax marked this pull request as draft September 20, 2024 12:55
@phlax phlax changed the title [WIP/bp/1.30] repo: Move examples to own repo (#35471) [bp/1.30] repo: Move examples to own repo (#35471) Sep 20, 2024
@phlax phlax marked this pull request as ready for review September 20, 2024 14:49
@phlax phlax force-pushed the bp-1.30-ex-amples branch 3 times, most recently from 961d620 to 49dc695 Compare September 20, 2024 17:55
@phlax phlax enabled auto-merge (rebase) September 20, 2024 17:55
phlax and others added 2 commits September 20, 2024 19:53
fix envoyproxy#32737

---------

Signed-off-by: Ryan Northey <[email protected]>

Signed-off-by: phlax <[email protected]>
see also envoyproxy#32737 and
envoyproxy#32737 (comment),

Commit Message: update git repo url in docs to refer to the new examples
repo
Additional Description: might fix docs
Risk Level: none
Testing: none
Docs Changes: changes docs/root/start/sandboxes/setup.rst to refer to
the right github repo (examples)

---------

Signed-off-by: David Goodwin <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
project_name = "envoy_examples",
project_desc = "Envoy proxy examples",
project_url = "https://github.com/envoyproxy/examples",
version = "8c8748bb024740df7c294a84780930df1488f7db",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this and 1.29 version use the lte-1.30 branch in the examples repo

@phlax phlax merged commit e2d93ee into envoyproxy:release/v1.30 Sep 20, 2024
29 of 30 checks passed
@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants