docs/examples: Shift rst files into example folders #34429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/docs |
|
Docs for this Pull Request will be rendered here: https://storage.googleapis.com/envoy-pr/34429/docs/index.html The docs are (re-)rendered each time the CI |
phlax
force-pushed
the
examples-rst
branch
2 times, most recently
from
e72f0dc to
7bf445c
Compare
phlax
changed the title
|
/retest |
phlax
force-pushed
the
examples-rst
branch
4 times, most recently
from
0aac24c to
b685f7a
Compare
phlax
changed the title
Signed-off-by: Ryan Northey <[email protected]>
phlax
changed the title
adisuissa
approved these changes
Jun 5, 2024
| outs = ["examples_docs.tar.gz"], | ||
| cmd = """ | ||
| TEMP=$$(mktemp -d) | ||
| for location in $(locations :docs_rst); do |
There was a problem hiding this comment.
IMHO having the list of toctree explicit in the index.rst has the added value of debuggability/maintainability of this code (when failures occur), but I don't feel strong about this.
There was a problem hiding this comment.
its pretty common for people to forget this and have to (re)cycle ci to fix - also this ensures alpha order
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Sep 20, 2024
Signed-off-by: Ryan Northey <[email protected]> Signed-off-by: phlax <[email protected]>
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Sep 20, 2024
Signed-off-by: Ryan Northey <[email protected]> Signed-off-by: phlax <[email protected]>
phlax
added a commit
that referenced
this pull request
Sep 20, 2024
Signed-off-by: Ryan Northey <[email protected]> Signed-off-by: phlax <[email protected]>
phlax
added a commit
that referenced
this pull request
Sep 23, 2024
Signed-off-by: Ryan Northey <[email protected]> Signed-off-by: phlax <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step towards #32737
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]