Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate example/sandboxes to their own repo #32737

Closed
phlax opened this issue Mar 6, 2024 · 6 comments · Fixed by #35471
Closed

Separate example/sandboxes to their own repo #32737

phlax opened this issue Mar 6, 2024 · 6 comments · Fixed by #35471
Assignees
@phlax
Labels
area/ci area/dependency area/docs area/examples no stalebot Disables stalebot from closing an issue

Comments

@phlax
Copy link
Member

phlax commented Mar 6, 2024

The examples create a lot of dependency noise in the envoy repo, which apart from being annoying is a constraint on adding more examples.

The reasons for not separating these previously is that we want to keep the CI coupled and that they are used in creation of docs

I think these issues are surmountable. For CI we can pull in the examples repo (at HEAD) and run the ci we currently do in envoy, and in the examples repo we can pull in latest envoy docker image on change. Similarly for docs we can just pull in the examples when we build the docs.

This should be fairly straightforward but will require some bazel, CI and dependabot setup
@phlax phlax added the triage Issue requires triage label Mar 6, 2024
@phlax
Copy link
Member Author

phlax commented Mar 6, 2024

cc @mattklein123 @mmorel-35

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 5, 2024

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Apr 5, 2024
@phlax phlax added no stalebot Disables stalebot from closing an issue and removed stale stalebot believes this issue/PR has not been touched recently labels Apr 5, 2024
@phlax
Copy link
Member Author

phlax commented May 1, 2024

i think we should prioritize this - it will potentially reduce the CI burden a lot, as well as quietening depedency changes in envoy repo

@phlax phlax mentioned this issue May 30, 2024
Merged
@phlax phlax self-assigned this Jul 31, 2024
@phlax phlax mentioned this issue Jul 31, 2024
Merged
phlax added a commit that referenced this issue Aug 6, 2024
@phlax
repo: Move examples to own repo (#35471)
56be4f4 
fix #32737

---------

Signed-off-by: Ryan Northey <[email protected]>
martinduke pushed a commit to martinduke/envoy that referenced this issue Aug 8, 2024
@phlax @martinduke
repo: Move examples to own repo (envoyproxy#35471)
e0b1deb 
fix envoyproxy#32737

---------

Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Martin Duke <[email protected]>
asingh-g pushed a commit to asingh-g/envoy that referenced this issue Aug 20, 2024
@phlax @asingh-g
repo: Move examples to own repo (envoyproxy#35471)
1fd21fa 
fix envoyproxy#32737

---------

Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: asingh-g <[email protected]>
@DavidGoodwin
Copy link
Contributor

the docs need updating - e.g. https://www.envoyproxy.io/docs/envoy/latest/start/sandboxes/setup#clone-the-envoy-repository - is still referencing .... https://github.com/envoyproxy/envoy.git and should instead point to .... https://github.com/envoyproxy/examples.git

@phlax
Copy link
Member Author

phlax commented Sep 3, 2024

are you up for creating a PR @DavidGoodwin ?

DavidGoodwin added a commit to DavidGoodwin/envoy that referenced this issue Sep 3, 2024
@DavidGoodwin
change git repo link for where examples are - see envoyproxy#32737 (c…
62237e2 
…omment)
@DavidGoodwin DavidGoodwin mentioned this issue Sep 3, 2024
Merged
@DavidGoodwin
Copy link
Contributor

are you up for creating a PR @DavidGoodwin ?

I'll try, but if you come back asking me to reword my commits to match something, or something else, I'm going to lose interest.

I'm just trying to scope out envoy for whether it could work for $employer ...

DavidGoodwin added a commit to DavidGoodwin/envoy that referenced this issue Sep 3, 2024
@DavidGoodwin
change git repo link for where examples are - see envoyproxy#32737 (c…
5490a79 
…omment)

Signed-off-by: David Goodwin <[email protected]>
phlax pushed a commit that referenced this issue Sep 3, 2024
@DavidGoodwin
change git repo link for where examples are (#35949)
69da813 
see also #32737 and
#32737 (comment),

Commit Message: update git repo url in docs to refer to the new examples
repo
Additional Description: might fix docs
Risk Level: none
Testing: none
Docs Changes: changes docs/root/start/sandboxes/setup.rst to refer to
the right github repo (examples)

---------

Signed-off-by: David Goodwin <[email protected]>
phlax added a commit to phlax/envoy that referenced this issue Sep 19, 2024
@phlax
repo: Move examples to own repo (envoyproxy#35471)
6ea505e 
fix envoyproxy#32737

---------

Signed-off-by: Ryan Northey <[email protected]>

Signed-off-by: phlax <[email protected]>
@phlax phlax mentioned this issue Sep 19, 2024
Merged
phlax added a commit to phlax/envoy that referenced this issue Sep 20, 2024
@phlax
repo: Move examples to own repo (envoyproxy#35471)
d3bbd0c 
fix envoyproxy#32737

---------

Signed-off-by: Ryan Northey <[email protected]>

Signed-off-by: phlax <[email protected]>
phlax added a commit to phlax/envoy that referenced this issue Sep 20, 2024
@phlax
repo: Move examples to own repo (envoyproxy#35471)
1441651 
fix envoyproxy#32737

---------

Signed-off-by: Ryan Northey <[email protected]>

Signed-off-by: phlax <[email protected]>
@phlax phlax mentioned this issue Sep 20, 2024
Merged
phlax added a commit to phlax/envoy that referenced this issue Sep 20, 2024
@phlax
repo: Move examples to own repo (envoyproxy#35471)
8296e86 
fix envoyproxy#32737

---------

Signed-off-by: Ryan Northey <[email protected]>

Signed-off-by: phlax <[email protected]>
phlax pushed a commit to phlax/envoy that referenced this issue Sep 20, 2024
@DavidGoodwin @phlax
change git repo link for where examples are (envoyproxy#35949)
8e5ebec 
see also envoyproxy#32737 and
envoyproxy#32737 (comment),

Commit Message: update git repo url in docs to refer to the new examples
repo
Additional Description: might fix docs
Risk Level: none
Testing: none
Docs Changes: changes docs/root/start/sandboxes/setup.rst to refer to
the right github repo (examples)

---------

Signed-off-by: David Goodwin <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
phlax pushed a commit to phlax/envoy that referenced this issue Sep 20, 2024
@DavidGoodwin @phlax
change git repo link for where examples are (envoyproxy#35949)
523862d 
see also envoyproxy#32737 and
envoyproxy#32737 (comment),

Commit Message: update git repo url in docs to refer to the new examples
repo
Additional Description: might fix docs
Risk Level: none
Testing: none
Docs Changes: changes docs/root/start/sandboxes/setup.rst to refer to
the right github repo (examples)

---------

Signed-off-by: David Goodwin <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
phlax added a commit that referenced this issue Sep 20, 2024
@phlax
repo: Move examples to own repo (#35471)
3717150 
fix #32737

---------

Signed-off-by: Ryan Northey <[email protected]>

Signed-off-by: phlax <[email protected]>
phlax pushed a commit that referenced this issue Sep 20, 2024
@DavidGoodwin @phlax
change git repo link for where examples are (#35949)
fd56cad 
see also #32737 and
#32737 (comment),

Commit Message: update git repo url in docs to refer to the new examples
repo
Additional Description: might fix docs
Risk Level: none
Testing: none
Docs Changes: changes docs/root/start/sandboxes/setup.rst to refer to
the right github repo (examples)

---------

Signed-off-by: David Goodwin <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
phlax added a commit to phlax/envoy that referenced this issue Sep 20, 2024
@phlax
repo: Move examples to own repo (envoyproxy#35471)
47d7874 
fix envoyproxy#32737

---------

Signed-off-by: Ryan Northey <[email protected]>

Signed-off-by: phlax <[email protected]>
phlax pushed a commit to phlax/envoy that referenced this issue Sep 20, 2024
@DavidGoodwin @phlax
change git repo link for where examples are (envoyproxy#35949)
a4758ef 
see also envoyproxy#32737 and
envoyproxy#32737 (comment),

Commit Message: update git repo url in docs to refer to the new examples
repo
Additional Description: might fix docs
Risk Level: none
Testing: none
Docs Changes: changes docs/root/start/sandboxes/setup.rst to refer to
the right github repo (examples)

---------

Signed-off-by: David Goodwin <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
phlax pushed a commit to phlax/envoy that referenced this issue Sep 20, 2024
@DavidGoodwin @phlax
change git repo link for where examples are (envoyproxy#35949)
ec93fc7 
see also envoyproxy#32737 and
envoyproxy#32737 (comment),

Commit Message: update git repo url in docs to refer to the new examples
repo
Additional Description: might fix docs
Risk Level: none
Testing: none
Docs Changes: changes docs/root/start/sandboxes/setup.rst to refer to
the right github repo (examples)

---------

Signed-off-by: David Goodwin <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
phlax added a commit to phlax/envoy that referenced this issue Sep 20, 2024
@phlax
repo: Move examples to own repo (envoyproxy#35471)
34486bc 
fix envoyproxy#32737

---------

Signed-off-by: Ryan Northey <[email protected]>

Signed-off-by: phlax <[email protected]>
phlax pushed a commit to phlax/envoy that referenced this issue Sep 20, 2024
@DavidGoodwin @phlax
change git repo link for where examples are (envoyproxy#35949)
961d620 
see also envoyproxy#32737 and
envoyproxy#32737 (comment),

Commit Message: update git repo url in docs to refer to the new examples
repo
Additional Description: might fix docs
Risk Level: none
Testing: none
Docs Changes: changes docs/root/start/sandboxes/setup.rst to refer to
the right github repo (examples)

---------

Signed-off-by: David Goodwin <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
phlax added a commit to phlax/envoy that referenced this issue Sep 20, 2024
@phlax
repo: Move examples to own repo (envoyproxy#35471)
00ea799 
fix envoyproxy#32737

---------

Signed-off-by: Ryan Northey <[email protected]>

Signed-off-by: phlax <[email protected]>
phlax pushed a commit to phlax/envoy that referenced this issue Sep 20, 2024
@DavidGoodwin @phlax
change git repo link for where examples are (envoyproxy#35949)
ff8e355 
see also envoyproxy#32737 and
envoyproxy#32737 (comment),

Commit Message: update git repo url in docs to refer to the new examples
repo
Additional Description: might fix docs
Risk Level: none
Testing: none
Docs Changes: changes docs/root/start/sandboxes/setup.rst to refer to
the right github repo (examples)

---------

Signed-off-by: David Goodwin <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
phlax added a commit to phlax/envoy that referenced this issue Sep 20, 2024
@phlax
repo: Move examples to own repo (envoyproxy#35471)
d959662 
fix envoyproxy#32737

---------

Signed-off-by: Ryan Northey <[email protected]>

Signed-off-by: phlax <[email protected]>
phlax pushed a commit to phlax/envoy that referenced this issue Sep 20, 2024
@DavidGoodwin @phlax
change git repo link for where examples are (envoyproxy#35949)
49dc695 
see also envoyproxy#32737 and
envoyproxy#32737 (comment),

Commit Message: update git repo url in docs to refer to the new examples
repo
Additional Description: might fix docs
Risk Level: none
Testing: none
Docs Changes: changes docs/root/start/sandboxes/setup.rst to refer to
the right github repo (examples)

---------

Signed-off-by: David Goodwin <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
phlax added a commit to phlax/envoy that referenced this issue Sep 20, 2024
@phlax
repo: Move examples to own repo (envoyproxy#35471)
b5ce731 
fix envoyproxy#32737

---------

Signed-off-by: Ryan Northey <[email protected]>

Signed-off-by: phlax <[email protected]>
phlax pushed a commit to phlax/envoy that referenced this issue Sep 20, 2024
@DavidGoodwin @phlax
change git repo link for where examples are (envoyproxy#35949)
aaef895 
see also envoyproxy#32737 and
envoyproxy#32737 (comment),

Commit Message: update git repo url in docs to refer to the new examples
repo
Additional Description: might fix docs
Risk Level: none
Testing: none
Docs Changes: changes docs/root/start/sandboxes/setup.rst to refer to
the right github repo (examples)

---------

Signed-off-by: David Goodwin <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
phlax added a commit to phlax/envoy that referenced this issue Sep 20, 2024
@phlax
repo: Move examples to own repo (envoyproxy#35471)
6263636 
fix envoyproxy#32737

---------

Signed-off-by: Ryan Northey <[email protected]>

Signed-off-by: phlax <[email protected]>
phlax pushed a commit to phlax/envoy that referenced this issue Sep 20, 2024
@DavidGoodwin @phlax
change git repo link for where examples are (envoyproxy#35949)
7a2eb11 
see also envoyproxy#32737 and
envoyproxy#32737 (comment),

Commit Message: update git repo url in docs to refer to the new examples
repo
Additional Description: might fix docs
Risk Level: none
Testing: none
Docs Changes: changes docs/root/start/sandboxes/setup.rst to refer to
the right github repo (examples)

---------

Signed-off-by: David Goodwin <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
phlax added a commit that referenced this issue Sep 20, 2024
@phlax
repo: Move examples to own repo (#35471)
701d603 
fix #32737

---------

Signed-off-by: Ryan Northey <[email protected]>

Signed-off-by: phlax <[email protected]>
phlax pushed a commit that referenced this issue Sep 20, 2024
@DavidGoodwin @phlax
change git repo link for where examples are (#35949)
e2d93ee 
see also #32737 and
#32737 (comment),

Commit Message: update git repo url in docs to refer to the new examples
repo
Additional Description: might fix docs
Risk Level: none
Testing: none
Docs Changes: changes docs/root/start/sandboxes/setup.rst to refer to
the right github repo (examples)

---------

Signed-off-by: David Goodwin <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
phlax added a commit that referenced this issue Sep 23, 2024
@phlax
repo: Move examples to own repo (#35471)
fead1c7 
fix #32737

---------

Signed-off-by: Ryan Northey <[email protected]>

Signed-off-by: phlax <[email protected]>
phlax pushed a commit that referenced this issue Sep 23, 2024
@DavidGoodwin @phlax
change git repo link for where examples are (#35949)
7cecb9f 
see also #32737 and
#32737 (comment),

Commit Message: update git repo url in docs to refer to the new examples
repo
Additional Description: might fix docs
Risk Level: none
Testing: none
Docs Changes: changes docs/root/start/sandboxes/setup.rst to refer to
the right github repo (examples)

---------

Signed-off-by: David Goodwin <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phlax phlax

Labels
area/ci area/dependency area/docs area/examples no stalebot Disables stalebot from closing an issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

repo: Move examples to own repo phlax/envoy
2 participants
@DavidGoodwin @phlax