-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove printers_include with printers_lib #14442
Conversation
0dc7c8e
to
66fa6ec
Compare
In this present draft, I'm removing The present proposal is a bit simpler, since we just need to add the missing dependency in a handful of places. Conceivably one could put more complicated deduplication logic into the Starlark rule, but that would seem to be unhealthy. @alyssawilk, @qiwzhang: could you please advise on the preferred direction? |
This change removes the defunct library printers_include and changes printers_lib to export the printers.h header. The Starlark rule envoy_cc_test_library no longer adds the printer dependency, and instead the now-missing dependencies on the new printers_lib target are added to a small number of targets that need them. Signed-off-by: Thomas Köppe <[email protected]>
I think the only reason to have separation would have been some cyclic dependency, so this makes sense. |
@htuch: Perhaps, though in my experience you can never really work around circular dependencies like that -- try |
* master: (30 commits) Deflaked: Guarddog_impl_test (envoyproxy#14475) [fuzz] add fuzz tests for hpack encoding and decoding (envoyproxy#13315) [filters] Prevent a filter from sending local reply and continue (envoyproxy#14416) oauth2: improving coverage (envoyproxy#14479) owners: Change dio email address (envoyproxy#14498) macos build: Fix ninja install (envoyproxy#14495) http: use OptRef helper to reduce some boilerplate (envoyproxy#14361) doc: update test/integration/README.md (envoyproxy#14485) server: wait workers to start before draining parent. (envoyproxy#14319) api: relax inline_string length limitation in DataSource (envoyproxy#14461) oauth: properly stop filter chain when a response was sent (envoyproxy#14476) listener: deprecate use_proxy_proto (envoyproxy#14406) deps: update cel and remove a patch (envoyproxy#14473) preconnect: rename: (envoyproxy#14474) coverage: ratcheting limits (envoyproxy#14472) grpc mux: fix sending node again after stream is reset (envoyproxy#14080) [test] Replace printers_include with printers_lib. (envoyproxy#14442) tcp: nodelay in the new pool (envoyproxy#14453) test: replace mock_methodn macros with mock_method (envoyproxy#14450) tcp: extending tcp integration test (envoyproxy#14451) ... Signed-off-by: Michael Puncel <[email protected]>
Commit Message: Remove the "printers_include" library in favour of "printers_lib".
Additional Description: The partial, header-only library :printers_include provided no service that wasn't already subsumed by :printers_lib.
Risk Level: low
Testing: in progress
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a