Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove printers_include with printers_lib #14442

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Remove printers_include with printers_lib #14442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions bazel/envoy_test.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,10 +209,6 @@ def envoy_cc_test_library(
copts = [],
alwayslink = 1,
**kargs):
deps = deps + [
repository + "//test/test_common:printers_includes",
]

_envoy_cc_test_infrastructure_library(
name,
srcs,
Expand Down
1 change: 1 addition & 0 deletions test/config/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ envoy_cc_test_library(
"//test/integration:server_stats_interface",
"//test/test_common:environment_lib",
"//test/test_common:network_utility_lib",
"//test/test_common:printers_lib",
"//test/test_common:resources_lib",
"//test/test_common:utility_lib",
"@envoy_api//envoy/config/bootstrap/v3:pkg_cc_proto",
Expand Down
1 change: 1 addition & 0 deletions test/extensions/filters/network/common/redis/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ envoy_cc_mock(
"//source/common/common:assert_lib",
"//source/extensions/filters/network/common/redis:client_lib",
"//source/extensions/filters/network/common/redis:codec_lib",
"//test/test_common:printers_lib",
],
)

Expand Down
1 change: 1 addition & 0 deletions test/extensions/filters/network/redis_proxy/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ envoy_cc_mock(
"//source/extensions/filters/network/redis_proxy:command_splitter_interface",
"//source/extensions/filters/network/redis_proxy:conn_pool_interface",
"//source/extensions/filters/network/redis_proxy:router_interface",
"//test/test_common:printers_lib",
],
)

Expand Down
1 change: 1 addition & 0 deletions test/mocks/buffer/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ envoy_cc_mock(
deps = [
"//source/common/buffer:buffer_lib",
"//source/common/buffer:watermark_buffer_lib",
"//test/test_common:printers_lib",
"//test/test_common:utility_lib",
],
)
16 changes: 3 additions & 13 deletions test/test_common/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,6 @@ licenses(["notice"]) # Apache 2

envoy_package()

envoy_basic_cc_library(
name = "printers_includes",
hdrs = ["printers.h"],
deps = [
":printers_lib",
"//include/envoy/network:address_interface",
],
)

envoy_cc_test_library(
name = "environment_lib",
srcs = ["environment.cc"],
Expand Down Expand Up @@ -87,10 +78,8 @@ envoy_cc_test_library(

envoy_cc_library(
name = "printers_lib",
srcs = [
"printers.cc",
"printers.h",
],
srcs = ["printers.cc"],
hdrs = ["printers.h"],
deps = [
"//include/envoy/network:address_interface",
"//source/common/buffer:buffer_lib",
Expand Down Expand Up @@ -121,6 +110,7 @@ envoy_cc_test_library(
],
deps = [
":file_system_for_test_lib",
":printers_lib",
":resources_lib",
":test_time_lib",
":thread_factory_for_test_lib",
Expand Down