[test_common/BUILD] Start dissolving :printers_include rule. #14429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @tkoeppe, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
A rule that exports a header without defining all the symbols declared by that header causes ODR violations. Basically, Bazel rules should never contain "include" rules like this. Rather, printer.h and printer.cc should be served from the same library. This change is a cautious, local first step. A second step can later remove the printer_include rule and replace its uses with printer_lib. Signed-off-by: Thomas Köppe <[email protected]>
qiwzhang
approved these changes
Dec 16, 2020
alyssawilk
reviewed
Dec 16, 2020
|
Thanks! Let's do it in steps please if that's OK. I already tested this change against Google's codebase, and it's nice and small. For the follow-up, we'll have to touch a couple of users (and it has the potential to break external users whom we can't test), so it might be nice to keep that as a separate step. I'll make the next PR now if you like. |
alyssawilk
approved these changes
Dec 16, 2020
|
Thanks! I'll test the next step locally first. |
|
Next step in #14442. |
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Dec 16, 2020
* master: (49 commits) sds: allow multiple init managers share sds target (envoyproxy#14357) [http] Remove legacy codecs (envoyproxy#14381) http2: Add integration tests for METADATA and RST_STREAM frame flood mitigation for upstream servers (envoyproxy#14365) test: start dissolving :printers_include rule. (envoyproxy#14429) integration tests: re-enable set_node_on_first_message_only (envoyproxy#14270) formatter: add a formatter that returns a google::protobuf::Struct rather than a string (envoyproxy#14258) ratelimit: support returning custom response bodies for non-OK responses from the external ratelimit service (envoyproxy#14189) deps: update protobuf to 3.14 (envoyproxy#14253) stream_info: add setResponseCode and update local_reply to take a normal StreamInfo (envoyproxy#14402) http: alpn upstream (envoyproxy#13922) Moved starttls integration test to test/extensions/transport_sockets/starttls. (envoyproxy#14425) generic conn pool: directly use thread local cluster (envoyproxy#14423) wasm: add mathetake to CODEOWNERS (envoyproxy#14427) wasm: clear route cache when modifying HTTP request headers. (envoyproxy#14318) tls: disable TLS inspector injection (envoyproxy#14404) aggregate cluster: cleanups (envoyproxy#14411) Mark starttls_integration_test flaky on Windows (envoyproxy#14419) tcp: improved unit testing (envoyproxy#14415) config: making protocol config explicit (envoyproxy#14362) wasm: dead code (envoyproxy#14407) ... Signed-off-by: Michael Puncel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
[test_common/BUILD] Start dissolving :printers_include rule.
Additional Description:
A rule that exports a header without defining all the symbols declared
by that header causes ODR violations. Basically, Bazel rules should
never contain "include" rules like this. Rather, printer.h and
printer.cc should be served from the same library.
This change is a cautious, local first step. A second step can later
remove the printer_include rule and replace its uses with printer_lib.
Risk Level: low(?)
Testing:
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a