Lua filter: support encoding binary data via base64Escape #13057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lihao Luo <[email protected]>
dio
reviewed
Sep 11, 2020
Comment on lines
2220
to
2221
| EXPECT_CALL(*filter_, scriptLog(spdlog::level::trace, StrEq("YmFyZm9v"))); | ||
| EXPECT_EQ(Http::FilterHeadersStatus::Continue, filter_->encodeHeaders(response_headers, true)); |
There was a problem hiding this comment.
Should we keep a test with a simple string as input as well?
dio
reviewed
Sep 11, 2020
|
|
||
| EXPECT_CALL(*filter_, scriptLog(spdlog::level::trace, StrEq("YmFyZm9v"))); | ||
| EXPECT_EQ(Http::FilterHeadersStatus::Continue, filter_->encodeHeaders(response_headers, true)); | ||
| // base64 encoding should also work for binary data |
There was a problem hiding this comment.
Super nit.
// Base64 encoding should also work for binary data.
dio
reviewed
Sep 11, 2020
|
@dio thanks for reviewing! Updated PR to address your comments. |
Signed-off-by: Lihao Luo <[email protected]>
lhluo
force-pushed
the
binary-lua-b64-encode
branch
from
cfa5e3d to
962affd
Compare
|
Force push to fix DCO |
|
@lhluo could you merge master? Thanks! Seems like there is a fix for that coverage failure. |
…code * upstream/master: lint: add more linters for using absl:: over std:: (envoyproxy#13043) udpa: filesystem list collection support for inline entries. (envoyproxy#13028) filter: http: jwt: implement matching for HTTP CONNECT (envoyproxy#13064) [fuzz] split http filter logic into a fuzzing class (envoyproxy#13016) xds: allow empty delta update (envoyproxy#12699) CacheFilter: parses the allowed_vary_headers from the cache config. (envoyproxy#12928) router: extend HTTP CONNECT route matching criteria (envoyproxy#13056) docs: clarify use of Extended CONNECT for h/2 (envoyproxy#13051) build: shellcheck tools/ (envoyproxy#13007) [fuzz] Refactored Health Checker Impl Tests (envoyproxy#13017) Signed-off-by: Lihao Luo <[email protected]>
|
@dio done! |
|
hi @dio could you help merge these changes today? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Support binary data in Lua Base64 encoding
Additional Description:
base64Escapewas introduced in #12552 to allow Lua filters to Base64 encode strings. The input is stored instring_viewwhich assumes a null-terminated string by default. However, raw binary data is not supported because it can have null bytes anywhere. This PR fixes the issue by setting the input_size explicitly.Risk Level: Low
Testing: Added a test case in unit tests
Docs Changes: N/A
Release Notes: N/A
Signed-off-by: Lihao Luo [email protected]