docs: clarify use of Extended CONNECT for h/2 #13051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tweak the HTTP upgrades documentation to mention RFC8841 in the documentation body (complementing the existing link to the RFC). Minor fix to the warning text for CONNECT support. Make explicit mention of "Extended CONNECT" in the API docs for `RouteMatch`. Closes envoyproxy#13044. Signed-off-by: Nick Travers <[email protected]>
|
cc: @alyssawilk |
nicktrav
commented
Sep 10, 2020
| @@ -85,7 +85,7 @@ and forward the HTTP payload upstream. On receipt of initial TCP data from upstr | |||
| will synthesize 200 response headers, and then forward the TCP data as the HTTP response body. | |||
|
|
|||
| .. warning:: | |||
| This mode of CONNECT support can create major security holes if configured correctly, as the upstream | |||
| This mode of CONNECT support can create major security holes if not configured correctly, as the upstream | |||
There was a problem hiding this comment.
I noticed this along the way, and assumed this was the intention.
Could have also possibly meant "... create holes even if configured correctly ..."?
alyssawilk
approved these changes
Sep 10, 2020
|
cc @mattklein123 or @htuch for the extra word in the APIs :-P |
lhluo
pushed a commit
to lhluo/envoy
that referenced
this pull request
Sep 11, 2020
…code * upstream/master: lint: add more linters for using absl:: over std:: (envoyproxy#13043) udpa: filesystem list collection support for inline entries. (envoyproxy#13028) filter: http: jwt: implement matching for HTTP CONNECT (envoyproxy#13064) [fuzz] split http filter logic into a fuzzing class (envoyproxy#13016) xds: allow empty delta update (envoyproxy#12699) CacheFilter: parses the allowed_vary_headers from the cache config. (envoyproxy#12928) router: extend HTTP CONNECT route matching criteria (envoyproxy#13056) docs: clarify use of Extended CONNECT for h/2 (envoyproxy#13051) build: shellcheck tools/ (envoyproxy#13007) [fuzz] Refactored Health Checker Impl Tests (envoyproxy#13017) Signed-off-by: Lihao Luo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
Tweak the HTTP upgrades documentation to mention RFC8841 in the
documentation body (complementing the existing link to the RFC).
Minor fix to the warning text for CONNECT support.
Make explicit mention of "Extended CONNECT" in the API docs for
RouteMatch.Closes #13044.
Additional Description: n/a
Risk Level: Low
Testing: n/a
Docs Changes: Minor clarification in API docs + Upgrade docs
Release Notes: n/a