-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xds: allow empty delta update #12699
Conversation
f13846e
to
95cf8c4
Compare
Signed-off-by: ouyangxu <[email protected]>
95cf8c4
to
3223759
Compare
ping @htuch 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; if you really want to future proof this you could also add an integration test, but don't feel super strong on that. One tiny nit.
/wait
Signed-off-by: ouyangxu <[email protected]>
This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
LGTM, thanks! |
…code * upstream/master: lint: add more linters for using absl:: over std:: (envoyproxy#13043) udpa: filesystem list collection support for inline entries. (envoyproxy#13028) filter: http: jwt: implement matching for HTTP CONNECT (envoyproxy#13064) [fuzz] split http filter logic into a fuzzing class (envoyproxy#13016) xds: allow empty delta update (envoyproxy#12699) CacheFilter: parses the allowed_vary_headers from the cache config. (envoyproxy#12928) router: extend HTTP CONNECT route matching criteria (envoyproxy#13056) docs: clarify use of Extended CONNECT for h/2 (envoyproxy#13051) build: shellcheck tools/ (envoyproxy#13007) [fuzz] Refactored Health Checker Impl Tests (envoyproxy#13017) Signed-off-by: Lihao Luo <[email protected]>
Commit Message:
when delta xds recv empty repsonce, it should be call onConfigUpdate, instead of do nothing, and stop init process 15s (initial_fetch_timeout)
Additional Description:
a first delta xds repsonce can't call wildcard subscription's onConfigUpdate (ex: empty CDS), and stop init process 15s. It don't like SOTW part:
envoy/source/common/config/watch_map.cc
Lines 104 to 115 in 7f4e35e
Risk Level: Low
Testing: Manual Pass
Docs Changes: None
Release Notes: None