Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update links to jaegertracing-plugin.tar.gz #16866

Closed
codefromthecrypt opened this issue Jun 8, 2021 · 12 comments · Fixed by #17497
Closed

update links to jaegertracing-plugin.tar.gz #16866

codefromthecrypt opened this issue Jun 8, 2021 · 12 comments · Fixed by #17497

Comments

@codefromthecrypt
Copy link
Contributor

Title: update links to jaegertracing-plugin.tar.gz

Description:

It is super cool that there are examples, but these are pointing to a GitHub repository which will become archived. Can these plugins be re-hosted here or at jaeger instead?

That or remove the content, doesn't matter to me, just I don't want these links to break without knowing cc @phlax

examples/front-proxy/Dockerfile-jaeger-service
14:         && curl -Ls https://github.com/tetratelabs/getenvoy-package/files/3518103/getenvoy-centos-jaegertracing-plugin.tar.gz \

examples/jaeger-native-tracing/Dockerfile-frontenvoy
15:         && curl -Ls https://github.com/tetratelabs/getenvoy-package/files/3518103/getenvoy-centos-jaegertracing-plugin.tar.gz \
@codefromthecrypt codefromthecrypt added the triage Issue requires triage label Jun 8, 2021
@phlax phlax added area/examples area/tracing and removed triage Issue requires triage labels Jun 8, 2021
@phlax phlax self-assigned this Jun 8, 2021
@phlax
Copy link
Member

phlax commented Jun 8, 2021

thanks @codefromthecrypt - yep - this was a hacky workaround

not sure exactly where best to keep this binary - but i guess if nowhere else then in the repo

cc @lizan

@phlax
Copy link
Member

phlax commented Jun 8, 2021

for reference - related tickets - that gave rise to the hacky workaround...

in envoy repo - #12287

and in tetrate repo - tetratelabs-attic/getenvoy-package#35

im wondering how tetrate derived this binary - and whether it would be possible to eg add a bazel rule to compile it in the envoy repo, or perhaps just as part of building the example

@lizan
Copy link
Member

lizan commented Jun 22, 2021

I did it in a hacky way to derive the binary, the recipe is tetratelabs-attic/getenvoy-package#35 (comment) . We should be able to do that in CI if it is desired.

@phlax
Copy link
Member

phlax commented Jun 22, 2021

@lizan any thoughts about the best way forward on this ?

im tempted to initially just copy the binary into the repo - and then open a ticket re adding build instructions etc

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Jul 22, 2021
@codefromthecrypt
Copy link
Contributor Author

GitHub has packages also. This could be done with an OCI tool using ghcr.io and envoyproxy in the repo name

Another way is to create a junk repo in envoyproxy org and add a release named "jaeger", and upload the files here into that release. Then you can use the raw URLs here.

Regardless, something should be done, ideally without checking these into the source tree as it is already expensive to clone.

Even a junk repo in the envoyproxy org is better than a strange dependency on a 3rd party site, even if that site wasn't a dead domain.

food for thought.

@github-actions github-actions bot removed the stale stalebot believes this issue/PR has not been touched recently label Jul 23, 2021
@mattklein123
Copy link
Member

@codefromthecrypt frankly we have limited resources to deal with all of these types of issues. If you are willing/able to help I'm happy to create a repo for you in envoyproxy and you can fix?

@mattklein123 mattklein123 added the help wanted Needs help! label Jul 23, 2021
@phlax
Copy link
Member

phlax commented Jul 23, 2021

Even a junk repo in the envoyproxy org is better than a strange dependency on a 3rd party site, even if that site wasn't a dead domain.

its on my list of things to do, i just havent got round to it yet, any help appreciated

@codefromthecrypt
Copy link
Contributor Author

sure. If it were me, I would call the repo "misc" or similar

given a release called "jeagertracing-plugin", we could upload these artifacts and the download url would look like this:

https://github.com/envoyproxy/misc/releases/download/jeagertracing-plugin/jeagertracing-plugin-centos.tar.gz

this could be used for any other opaque or otherwise informal artifacts that help in docs but aren't worth making a separate project over.

If you like this, go ahead and create the repo and add me. I'll move the things there and send a PR to update the links accordingly. I don't feel strongly on repo name so feel free to change it.

@codefromthecrypt
Copy link
Contributor Author

also if there are any issues with the format of the link or we want make them permalinks, we can in any case setup redirects here https://github.com/envoyproxy/envoyproxy.github.io/blob/main/netlify.toml

@mattklein123
Copy link
Member

@codefromthecrypt I made you https://github.com/envoyproxy/misc and gave you write access. Please let me know if you need other access. Please also setup a README on the new repo. Thank you a ton for helping with this.

codefromthecrypt pushed a commit to codefromthecrypt/envoy that referenced this issue Jul 26, 2021
This moves links used by example Docker configuration to a 1st party
repository.

Fixes envoyproxy#16866

Signed-off-by: Adrian Cole <[email protected]>
@codefromthecrypt
Copy link
Contributor Author

ok done. #17497

feel free to revise the README or anything as you see fit

mattklein123 pushed a commit that referenced this issue Jul 27, 2021
This moves links used by example Docker configuration to a 1st party
repository.

Fixes #16866

Signed-off-by: Adrian Cole <[email protected]>
leyao-daily pushed a commit to leyao-daily/envoy that referenced this issue Sep 30, 2021
This moves links used by example Docker configuration to a 1st party
repository.

Fixes envoyproxy#16866

Signed-off-by: Adrian Cole <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants