-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update links to jaegertracing-plugin.tar.gz #16866
Comments
thanks @codefromthecrypt - yep - this was a hacky workaround not sure exactly where best to keep this binary - but i guess if nowhere else then in the repo cc @lizan |
for reference - related tickets - that gave rise to the hacky workaround... in envoy repo - #12287 and in tetrate repo - tetratelabs-attic/getenvoy-package#35 im wondering how tetrate derived this binary - and whether it would be possible to eg add a bazel rule to compile it in the envoy repo, or perhaps just as part of building the example |
I did it in a hacky way to derive the binary, the recipe is tetratelabs-attic/getenvoy-package#35 (comment) . We should be able to do that in CI if it is desired. |
@lizan any thoughts about the best way forward on this ? im tempted to initially just copy the binary into the repo - and then open a ticket re adding build instructions etc |
This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions. |
GitHub has packages also. This could be done with an OCI tool using ghcr.io and envoyproxy in the repo name Another way is to create a junk repo in envoyproxy org and add a release named "jaeger", and upload the files here into that release. Then you can use the raw URLs here. Regardless, something should be done, ideally without checking these into the source tree as it is already expensive to clone. Even a junk repo in the envoyproxy org is better than a strange dependency on a 3rd party site, even if that site wasn't a dead domain. food for thought. |
@codefromthecrypt frankly we have limited resources to deal with all of these types of issues. If you are willing/able to help I'm happy to create a repo for you in envoyproxy and you can fix? |
its on my list of things to do, i just havent got round to it yet, any help appreciated |
sure. If it were me, I would call the repo "misc" or similar given a release called "jeagertracing-plugin", we could upload these artifacts and the download url would look like this:
this could be used for any other opaque or otherwise informal artifacts that help in docs but aren't worth making a separate project over. If you like this, go ahead and create the repo and add me. I'll move the things there and send a PR to update the links accordingly. I don't feel strongly on repo name so feel free to change it. |
also if there are any issues with the format of the link or we want make them permalinks, we can in any case setup redirects here https://github.com/envoyproxy/envoyproxy.github.io/blob/main/netlify.toml |
@codefromthecrypt I made you https://github.com/envoyproxy/misc and gave you write access. Please let me know if you need other access. Please also setup a README on the new repo. Thank you a ton for helping with this. |
This moves links used by example Docker configuration to a 1st party repository. Fixes envoyproxy#16866 Signed-off-by: Adrian Cole <[email protected]>
This moves links used by example Docker configuration to a 1st party repository. Fixes #16866 Signed-off-by: Adrian Cole <[email protected]>
This moves links used by example Docker configuration to a 1st party repository. Fixes envoyproxy#16866 Signed-off-by: Adrian Cole <[email protected]>
Title: update links to jaegertracing-plugin.tar.gz
Description:
It is super cool that there are examples, but these are pointing to a GitHub repository which will become archived. Can these plugins be re-hosted here or at jaeger instead?
That or remove the content, doesn't matter to me, just I don't want these links to break without knowing cc @phlax
The text was updated successfully, but these errors were encountered: