Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes most references to getenvoy #16868

Merged
merged 1 commit into from
Jun 22, 2021

Conversation

codefromthecrypt
Copy link
Contributor

Commit Message: Removes most references to getenvoy

Additional Description:
This removes the website links of getenvoy for everything except system
packages which #16867 will solve.

It also removes the section about nightlies as I don't think they are being
maintained and certainly won't be moving forward.

Risk Level: Low
Testing: None
Docs Changes: Only Docs
Release Notes: No
Platform Specific Features: No

There seem to be some concerns about getenvoy's distributions, and most
of them are moot at this point. As the getenvoy project stops building
and publishing envoy, we should make sure users are aware where
"official" things are. Right now, there are official and more maintained
alternatives for everything except system packages.

This removes the website links of getenvoy for everything except system
packages. It also removes the section about nightlies as I don't think
they are being maintained and certainly won't be moving forward.

See:

envoyproxy#16867
envoyproxy#16830 (comment)

Signed-off-by: Adrian Cole <[email protected]>
@repokitteh-read-only
Copy link

Hi @codefromthecrypt, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

🐱

Caused by: #16868 was opened by codefromthecrypt.

see: more, trace.

@codefromthecrypt
Copy link
Contributor Author

@phlax once #16866 is also solved, there should be no confusion left around getenvoy especially as I'll be following up to change the website and remove content except CLI usage.

@phlax
Copy link
Member

phlax commented Jun 8, 2021

@codefromthecrypt can we keep this as is for now - im hoping we can resolve most of the issues you have posted so far fairly quickly

@codefromthecrypt
Copy link
Contributor Author

@phlax the main problem is people are coming to getenvoy because of these links and looking for support and we can't give it to them. So, I think it is probably better to remove the links. The ones removed here are completely redundant to upstream. Make sense?

@phlax
Copy link
Member

phlax commented Jun 8, 2021

yep, i see - let me look over this a bit further later today

@codefromthecrypt
Copy link
Contributor Author

I know there's often confusion, but there's basically no more work happening on these repos, and there is no plan to do anything except archive them. There is no plan for example, to migrate these redundant repos to CNCF. So, we should remove the links to the tetrate repos especially ones that cause confusion (the redundant ones)

codefromthecrypt added a commit to tetratelabs-attic/homebrew-getenvoy that referenced this pull request Jun 8, 2021
This is redundant and no longer maintained. See envoyproxy/envoy#16868

Signed-off-by: Adrian Cole <[email protected]>
@codefromthecrypt
Copy link
Contributor Author

fyi this is follow-up as we're pretty much good except getenvoy website edits after the various things I raised tetratelabs-attic/getenvoy-package#119

much appreciate the support @phlax!

codefromthecrypt added a commit to tetratelabs-attic/homebrew-getenvoy that referenced this pull request Jun 8, 2021
This is redundant and no longer maintained. See envoyproxy/envoy#16868

Signed-off-by: Adrian Cole <[email protected]>
@phlax phlax self-assigned this Jun 8, 2021
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - we can iterate the messaging here as we develop

thanks @codefromthecrypt

@phlax phlax merged commit 5e248dc into envoyproxy:main Jun 22, 2021
chrisxrepo pushed a commit to chrisxrepo/envoy that referenced this pull request Jul 8, 2021
There seem to be some concerns about getenvoy's distributions, and most
of them are moot at this point. As the getenvoy project stops building
and publishing envoy, we should make sure users are aware where
"official" things are. Right now, there are official and more maintained
alternatives for everything except system packages.

This removes the website links of getenvoy for everything except system
packages. It also removes the section about nightlies as I don't think
they are being maintained and certainly won't be moving forward.

See:

envoyproxy#16867
envoyproxy#16830 (comment)

Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: chris.xin <[email protected]>
leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021
There seem to be some concerns about getenvoy's distributions, and most
of them are moot at this point. As the getenvoy project stops building
and publishing envoy, we should make sure users are aware where
"official" things are. Right now, there are official and more maintained
alternatives for everything except system packages.

This removes the website links of getenvoy for everything except system
packages. It also removes the section about nightlies as I don't think
they are being maintained and certainly won't be moving forward.

See:

envoyproxy#16867
envoyproxy#16830 (comment)

Signed-off-by: Adrian Cole <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants