Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates links to jaegertracing-plugin.tar.gz #17497

Merged
merged 1 commit into from
Jul 27, 2021

Conversation

codefromthecrypt
Copy link
Contributor

@codefromthecrypt codefromthecrypt commented Jul 26, 2021

This moves links used by example Docker configuration to a 1st party
repository: misc

Fixes #16866

Signed-off-by: Adrian Cole [email protected]

This moves links used by example Docker configuration to a 1st party
repository.

Fixes envoyproxy#16866

Signed-off-by: Adrian Cole <[email protected]>
@codefromthecrypt
Copy link
Contributor Author

I'm not sure if the example docker files are built with CI. In case not, I built them and they didn't crash

Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @codefromthecrypt

@phlax
Copy link
Member

phlax commented Jul 27, 2021

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #17497 (comment) was created by @phlax.

see: more, trace.

@phlax
Copy link
Member

phlax commented Jul 27, 2021

I'm not sure if the example docker files are built with CI

yep, the container is built in ci and the jaeger plugin is tested

@asraa
Copy link
Contributor

asraa commented Jul 27, 2021

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #17497 (comment) was created by @asraa.

see: more, trace.

@asraa asraa assigned phlax and asraa Jul 27, 2021
@phlax
Copy link
Member

phlax commented Jul 27, 2021

not sure why it wasnt retesting, i kicked ci directly, and its retesting now

Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thank you @codefromthecrypt!

@mattklein123 mattklein123 merged commit dc202cd into envoyproxy:main Jul 27, 2021
@codefromthecrypt codefromthecrypt deleted the bronze-links branch July 27, 2021 22:05
baojr added a commit to baojr/envoy that referenced this pull request Jul 29, 2021
…bridge-stream

* upstream/main: (140 commits)
  quiche: remove google quic support (envoyproxy#17465)
  runtime: removing envoy.reloadable_features.check_ocsp_policy (envoyproxy#17524)
  upstream: not trying to do HTTP/3 where not configured (envoyproxy#17454)
  api: Remove confusing line about auto-generation (envoyproxy#17536)
  v2: removing bootstrap (envoyproxy#17523)
  connpool: Fix crash in pool removal if the cluster was already deleted (envoyproxy#17522)
  Enhance the comments clearly (envoyproxy#17517)
  mysql proxy: connection attributes parsing  (envoyproxy#17209)
  [ci] fix false positive CVE scan from node (envoyproxy#17510)
  Fixing Envoy Mobile factory strings (envoyproxy#17509)
  http3: validating codec (envoyproxy#17452)
  quic: add QUIC upstream stream reset error stats (envoyproxy#17496)
  thrift proxy: move UpstreamRequest into its own file (envoyproxy#17498)
  docs: Fixed FaultDelay docs. (envoyproxy#17495)
  updates links to jaegertracing-plugin.tar.gz (envoyproxy#17497)
  http: make custom inline headers bootstrap configurable (envoyproxy#17330)
  deps: update yaml-cpp to latest master (envoyproxy#17489)
  improving tracer coverage (envoyproxy#17493)
  Increase buffer size of `Win32RedirectRecords` (envoyproxy#17471)
  ext_proc: Fix problem with buffered body mode with empty or no body (envoyproxy#17430)
  ...

Signed-off-by: Garrett Bourg <[email protected]>
leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021
This moves links used by example Docker configuration to a 1st party
repository.

Fixes envoyproxy#16866

Signed-off-by: Adrian Cole <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update links to jaegertracing-plugin.tar.gz
4 participants