Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix benchmark actions #8350

Closed
wants to merge 1 commit into from
Closed

Fix benchmark actions #8350

wants to merge 1 commit into from

Conversation

Akirathan
Copy link
Member

Pull Request Description

Fix engine-benchmarks and std-libs-benchmarks actions that have been failing since #7991.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@Akirathan Akirathan self-assigned this Nov 21, 2023
@Akirathan Akirathan requested a review from mwu-tow as a code owner November 21, 2023 10:57
@Akirathan
Copy link
Member Author

@mwu-tow f8c25cb fixes Benchmark Engine and Benchmark Standard Libraries actions. Please, push any changes needed to also make the Nightly Release work.

@Akirathan Akirathan added the CI: No changelog needed Do not require a changelog entry for this PR. label Nov 21, 2023
@Akirathan
Copy link
Member Author

Akirathan commented Nov 21, 2023

I have just manually started https://github.com/enso-org/enso/actions/runs/6942823371 - a dry run of Engine benchmarks.

GitHub
Hybrid visual and textual functional programming. Contribute to enso-org/enso development by creating an account on GitHub.

@JaroslavTulach
Copy link
Member

@mwu-tow, this PR fixes InvalidaPathException which is also happening in the nightly builds. As a result we don't have benchmarks and don't have daily builds right now. Can you please approve/integrate this quickfix (use it in daily builds as well) so we unluck everyone who's waiting for daily build or benchmark results?

@Akirathan
Copy link
Member Author

Dropping this PR in favor of #8285 that contains better fixes for the LC_ALL problem, among other fixes.

@Akirathan Akirathan closed this Nov 22, 2023
@Akirathan Akirathan deleted the wip/akirathan/fix-benchs branch December 21, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants