-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade enso to GraalVM for jdk 21 #7991
Merged
mergify
merged 177 commits into
develop
from
wip/akirathan/7851-Upgrade-Enso-to-GraalVM-for-JDK-21
Nov 17, 2023
Merged
Upgrade enso to GraalVM for jdk 21 #7991
mergify
merged 177 commits into
develop
from
wip/akirathan/7851-Upgrade-Enso-to-GraalVM-for-JDK-21
Nov 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"-Dorg.graalvm.launcher.home=" + System.getProperty( | ||
"java.home" | ||
), | ||
"--language:java" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably removes a way to build engine with Espresso - the documentation needs an update (at least) or the build script needs a fix.
…g.graalvm.polyglot:polyglot
This reverts commit b173751.
…ageBin. Now we can call just runtime-with-instruments/assembly and it works even after enso/clean
This fixes, e.g., std-benchmarks/Bench/compile
Akirathan
force-pushed
the
wip/akirathan/7851-Upgrade-Enso-to-GraalVM-for-JDK-21
branch
from
November 17, 2023 11:35
bcd5fef
to
71bcd1c
Compare
GregoryTravis
approved these changes
Nov 17, 2023
mwu-tow
approved these changes
Nov 17, 2023
They are failing on StackOverflow, let's postpone the investigation
mergify
bot
deleted the
wip/akirathan/7851-Upgrade-Enso-to-GraalVM-for-JDK-21
branch
November 17, 2023 18:02
This was referenced Nov 20, 2023
Closed
5 tasks
mwu-tow
pushed a commit
that referenced
this pull request
Nov 29, 2023
This is a follow-up of #7991. #7991 broken `runtime-version-manager`. This is mostly reverts. ### Important Notes Launcher now correctly recognizes that the newest engine needs some runtime: ```sh > java -jar launcher.jar list Enso 2023.2.1-nightly.2023.10.31 -> GraalVM 23.0.0-java17.0.7 Enso 0.0.0-dev -> GraalVM 23.1.0-java21.0.1 ``` (this has not worked before)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI: Clean build required
CI runners will be cleaned before and after this PR is built.
CI: Ready to merge
This PR is eligible for automatic merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7851
Pull Request Description
Upgrade to GraalVM JDK 21.
With SDKMan, download with
sdk install java 21-graalce
.Important Notes
sbt bootstrap
hack and all the other build time related hacks related to the handling of GraalVM distribution.project-manager
remains backward compatible - it can open older engines with runtimes. New engines now do no longer require a separate runtime to be downloaded.module-info.java
files in mixed projects - JDK9: Support module-info.java sbt/sbt#3368module-info.java
files only for Java-only projects.module-info.class
in the resultingruntime.jar
fat jar.runtime.jar
is assembled inruntime-with-instruments
with a custom merge strategy (sbt-assembly
plugin). Caching is disabled for custom merge strategies, which means that re-assembly ofruntime.jar
will be more frequent.component
directory, along withrunner/runner.jar
that is hidden inside a nested directory.runner.jar
, which is not a module.--source 21
option, only--source 20
.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.