Fix bundled GraalVM path #7948
Merged
Fix bundled GraalVM path #7948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4e6
added
the
CI: No changelog needed
4e6
requested review from
JaroslavTulach,
hubertp and
Akirathan
as code owners
Akirathan
approved these changes
Oct 3, 2023
JaroslavTulach
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
I'd prefer a bit more of automated testing:
- checking the consistency between YAML and
build.sbt - executing the final bundle without internet connection
|
Note that there is #7851 high in my backlog that will, once again, mess with the configuration of all the GraalVM-related paths and artifacts. |
hubertp
approved these changes
Oct 4, 2023
mwu-tow
approved these changes
Oct 5, 2023
4e6
added
the
CI: Clean build required
…k-without-downloading
Akirathan
reviewed
Oct 6, 2023
| @@ -20,8 +20,7 @@ import java.io.File | |||
| // ============================================================================ | |||
|
|
|||
| val scalacVersion = "2.13.11" | |||
| // Since the release of GraalVM 23.0.0, the versioning is the same for Graal and OpenJDK. | |||
| val graalVersion = "17.0.7" | |||
| val graalVersion = "17.0.7" | |||
There was a problem hiding this comment.
Note that the newest Graal (PR is at #7991) does not have minor or patch version. It is just 21:
> java -version
openjdk version "21" 2023-09-19
OpenJDK Runtime Environment GraalVM CE 21+35.1 (build 21+35-jvmci-23.1-b15)
OpenJDK 64-Bit Server VM GraalVM CE 21+35.1 (build 21+35-jvmci-23.1-b15, mixed mode, sharing)
mergify
bot
deleted the
wip/db/7871-enso-engine-bundle-doesnt-work-without-downloading
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
close #7871
close #7698
Changelog:
runscript logic to place the GraalVM runtime in the expected directory when building the bundlemakeBundlesSBT logic to place the GraalVM runtime in the expected directoryImportant Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.