Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build script fixes & improvements #8285

Merged
merged 6 commits into from
Nov 23, 2023
Merged

Conversation

mwu-tow
Copy link
Contributor

@mwu-tow mwu-tow commented Nov 13, 2023

Pull Request Description

This PR adds several minor fixes for the build scripts and CI:

  • removed some unused dependencies;
  • cleaner fix for the LC_ALL issue;
  • simplified wrapper scripts and worked around the pwsh 7.4.0 issue.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@mwu-tow mwu-tow changed the title CI generator fix + crates cleanup Build script fixes & improvements Nov 22, 2023
@Akirathan Akirathan mentioned this pull request Nov 22, 2023
5 tasks
@mwu-tow mwu-tow marked this pull request as ready for review November 23, 2023 19:09
@mwu-tow mwu-tow self-assigned this Nov 23, 2023
@mwu-tow mwu-tow added the CI: No changelog needed Do not require a changelog entry for this PR. label Nov 23, 2023
@mwu-tow mwu-tow merged commit 8021109 into develop Nov 23, 2023
25 of 32 checks passed
@mwu-tow mwu-tow deleted the wip/mwu/build-script-cleanups branch November 23, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant